Done ! https://wso2.org/jira/browse/ESBJAVA-2624
On Wed, Nov 6, 2013 at 11:50 AM, Kishanthan Thangarajah <[email protected] > wrote: > Can you create a jira for this please? I'll look into it. > > > On Wed, Nov 6, 2013 at 10:02 AM, Dushan Abeyruwan <[email protected]> wrote: > >> Ok..whats the final verdict ? this blocks 480 release ... >> >> >> On Tue, Nov 5, 2013 at 11:05 PM, Manoj Kumara <[email protected]> wrote: >> >>> Hi Kishanthan, >>> >>> We removed this due to [1] which was a blocker on chunk-01 release. The >>> reason for this ConcurrentModificationException was adding the cApp >>> deployer separately at runtime. As I can remember during this fix this >>> deployer adding part from the StartupFinalizerComponent was also >>> removed. >>> >>> If we are to fix this we need to consider testing the problem we faced >>> on [1] since this was an intermittent issue. >>> >>> [1] https://wso2.org/jira/browse/CARBON-14471 >>> >>> >>> Thanks, >>> Manoj >>> >>> Best Regards.. >>> >>> >>> Manoj Kumara >>> Software Engineer >>> WSO2, Inc.; http://wso2.com >>> >>> Twitter: http://twitter.com/ManKuma >>> Mobile: +94713448188 >>> >>> >>> On Tue, Nov 5, 2013 at 9:08 PM, Kishanthan Thangarajah < >>> [email protected]> wrote: >>> >>>> To handle this particular scenario, we had to delay the CAppDeployer >>>> initialization (common to all servers). It was done by moving the >>>> initialization part to server start-up finalization component. Then once >>>> tenantServiceBus gets initialized, we could retrieve the related deployer >>>> using synapseEnvService as per above code. Seems like this change has been >>>> removed from StartupFinalizerComponent. >>>> @Sameera, any reason for this change? >>>> >>>> >>>> On Tue, Nov 5, 2013 at 6:50 PM, Dushan Abeyruwan <[email protected]>wrote: >>>> >>>>> $subject, due to recent major re-factoring in deployments, the CAR >>>>> deployment has been totally broken, did kind of investigation found >>>>> that... >>>>> >>>>> in synapse Deployer >>>>> >>>>> private Deployer getDeployer(AxisConfiguration axisConfig, String >>>>> directory) { >>>>> Deployer deployer = null; >>>>> // access the deployment engine through axis config >>>>> DeploymentEngine deploymentEngine = (DeploymentEngine) >>>>> axisConfig.getConfigurator(); >>>>> String tenantId = >>>>> AppDeployerUtils.getTenantIdString(axisConfig); >>>>> *SynapseEnvironmentService environmentService = >>>>> DataHolder.getInstance().* >>>>> * >>>>> getSynapseEnvironmentService(Integer.parseInt(tenantId));* >>>>> if (environmentService != null) { >>>>> String synapseConfigPath = >>>>> ServiceBusUtils.getSynapseConfigAbsPath( >>>>> >>>>> environmentService.getSynapseEnvironment().getServerContextInformation()); >>>>> String endpointDirPath = synapseConfigPath >>>>> + File.separator + directory; >>>>> deployer = deploymentEngine.getDeployer(endpointDirPath, >>>>> >>>>> ServiceBusConstants.ARTIFACT_EXTENSION); >>>>> } >>>>> return deployer; >>>>> } >>>>> >>>>> >>>>> the above highlighted section..(basically SynapseAppDeployer) >>>>> getting invoked before TenantServiceBusInitializer component initialized, >>>>> thus it can not find relevant synapse env... any thoughts how we should >>>>> mitigate this problem ? >>>>> >>>>> anyway have we EVER done any sort of testings with those >>>>> deployment changers with ESB specially in the *context of >>>>> Multitenancy mode ? *sounds like never.. >>>>> >>>>> >>>>> Cheers, >>>>> Dushan Abeyruwan >>>>> Associate Tech Lead >>>>> *Integration Technologies Team* >>>>> *WSO2 Inc. http://wso2.com/ <http://wso2.com/>* >>>>> *Mobile:(+94)714408632 <%28%2B94%29714408632>* >>>>> >>>> >>>> >>>> >>>> -- >>>> *Kishanthan Thangarajah* >>>> Senior Software Engineer, >>>> Platform Technologies Team, >>>> WSO2, Inc. >>>> lean.enterprise.middleware >>>> >>>> Mobile - +94773426635 >>>> Blog - *http://kishanthan.wordpress.com >>>> <http://kishanthan.wordpress.com>* >>>> Twitter - *http://twitter.com/kishanthan >>>> <http://twitter.com/kishanthan>* >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> [email protected] >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >> >> >> -- >> Dushan Abeyruwan >> Associate Tech Lead >> *Integration Technologies Team* >> *WSO2 Inc. http://wso2.com/ <http://wso2.com/>* >> *Mobile:(+94)714408632 <%28%2B94%29714408632>* >> > > > > -- > *Kishanthan Thangarajah* > Senior Software Engineer, > Platform Technologies Team, > WSO2, Inc. > lean.enterprise.middleware > > Mobile - +94773426635 > Blog - *http://kishanthan.wordpress.com <http://kishanthan.wordpress.com>* > Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>* > -- Dushan Abeyruwan Associate Tech Lead *Integration Technologies Team* *WSO2 Inc. http://wso2.com/ <http://wso2.com/>* *Mobile:(+94)714408632*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
