On Mon, Feb 17, 2014 at 1:52 PM, Pushpalanka Jayawardhana <la...@wso2.com>wrote:
> Hi Sameera, > > I am not sure why they are declared final. Just looking it the code it > seems for 'updateUserListOfRole' method, it has been avoiding overriding > the method such that, admin user can be removed from admin role. > > Use case is related with Appfactory, OT user store, where we needs to keep > some virtual roles for user. > AFAIK, Most of the methods in the "UserStoreManager" have been declared as "final" inside the Abstract user store manager. Because common set of functions for most of the user store implementation, have been done there (also multiple user store functions , listeners and so on). And Abstract user store manager introduces new methods (such as "doUpdateUserListOfRole" method) to implement. But, if you want to modify the functions of Abstract user store manager, I guess you can implement the your user store implementation directly from "UserStoreManager" interface. However if there is an issue or improvement on removing admin user from admin role. We may need to fix it. Thanks, Asela. > > Thanks, > > On Tue, Feb 11, 2014 at 2:42 PM, Sameera Jayasoma <same...@wso2.com>wrote: > >> Hi Pushpalanka, >> >> Do you know why these method declared as final? Can we give it a try to >> implement your solution without changing the existing API? >> >> What is your user-case? >> >> Thanks, >> Sameera. >> >> >> On Tue, Feb 11, 2014 at 11:04 AM, Pushpalanka Jayawardhana < >> la...@wso2.com> wrote: >> >>> Hi, >>> >>> We have patched the Kernel as attached(removing final) to have the >>> freedom at implementing the OTUserStoreManager to override the two methods, >>> >>> updateUserListOfRole >>> getUserListOfRole >>> >>> This is not yet committed to Kernel, but used as a custom patch. Are we >>> ok to go ahead and commit this? >>> >>> Thanks, >>> -- >>> >>> Pushpalanka Jayawardhana >>> >>> Software Engineer >>> >>> WSO2 Lanka (pvt) Ltd >>> [image: >>> Facebook]<http://s.wisestamp.com/links?url=http%3A%2F%2Fwww.facebook.com%2Fpushpalanka> >>> [image: >>> Twitter]<http://s.wisestamp.com/links?url=http%3A%2F%2Ftwitter.com%2FPushpalanka> >>> [image: >>> LinkedIn]<http://s.wisestamp.com/links?url=http%3A%2F%2Fwww.linkedin.com%2Fprofile%2Fview%3Fid%3D75175642%26trk%3Dtab_pro> >>> [image: >>> Blogger]<http://s.wisestamp.com/links?url=http%3A%2F%2Fpushpalankajaya.blogspot.com%2F> >>> [image: >>> SlideShare]<http://s.wisestamp.com/links?url=http%3A%2F%2Fwww.slideshare.net%2FPushpalanka> >>> Mobile: +94779716248 >>> >>> _______________________________________________ >>> Dev mailing list >>> Dev@wso2.org >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> Sameera Jayasoma, >> Architect, >> >> WSO2, Inc. (http://wso2.com) >> email: same...@wso2.com >> blog: http://sameera.adahas.org >> twitter: https://twitter.com/sameerajayasoma >> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections >> Mobile: 0094776364456 >> >> Lean . Enterprise . Middleware >> > > > > -- > > Pushpalanka Jayawardhana > > Software Engineer > > WSO2 Lanka (pvt) Ltd > [image: > Facebook]<http://s.wisestamp.com/links?url=http%3A%2F%2Fwww.facebook.com%2Fpushpalanka> > [image: > Twitter]<http://s.wisestamp.com/links?url=http%3A%2F%2Ftwitter.com%2FPushpalanka> > [image: > LinkedIn]<http://s.wisestamp.com/links?url=http%3A%2F%2Fwww.linkedin.com%2Fprofile%2Fview%3Fid%3D75175642%26trk%3Dtab_pro> > [image: > Blogger]<http://s.wisestamp.com/links?url=http%3A%2F%2Fpushpalankajaya.blogspot.com%2F> > [image: > SlideShare]<http://s.wisestamp.com/links?url=http%3A%2F%2Fwww.slideshare.net%2FPushpalanka> > Mobile: +94779716248 > -- Thanks & Regards, Asela ATL Mobile : +94 777 625 933
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
