On Mon, May 5, 2014 at 8:43 AM, Ruchira Wageesha <ruch...@wso2.com> wrote:

> I don't thing you need to worry about branches, master branch always
> accepts PRs. If you can't make the pull request for master due to some
> reason, just create a github issue and attach the patch.
>

​Will do.​



>
> /Ruchira
>
>
> On Mon, May 5, 2014 at 8:07 AM, Chan <duli...@wso2.com> wrote:
>
>> Hi folks,
>> In the app.js in store [1] - the ports 9763 and 9443 are hardcoded. The
>> ports is determined by variety of factors including proxies if used. I did
>> a contribution to jaggery few months back on this [2] which can be used to
>> get the current address of the server. That uses several System properties
>> and takes in to account the proxy setup as well. Hope you guys take this in
>> to account.
>>
>> Note:- I could have sent a PR on this but I don't know what branch
>> accepts PR.
>>
>> Cheers~
>>
>> [1] -
>> https://github.com/wso2/enterprise-store/blob/master/modules/apps/store/config/app.js#L12
>> [2] -
>> https://github.com/wso2/jaggery-extensions/blob/master/carbon/module/scripts/server/server.js#L93
>>  --
>> Chan (Dulitha Wijewantha)
>> Software Engineer - Mobile Development
>> WSO2Mobile
>> Lean.Enterprise.Mobileware
>>  * ~Email       duli...@wso2.com <duli...@wso2mobile.com>*
>> *  ~Mobile     +94712112165 <%2B94712112165>*
>> *  ~Website   dulitha.me <http://dulitha.me>*
>>  *  ~Twitter     @dulitharw <https://twitter.com/dulitharw>*
>>   *~Github     @dulichan <https://github.com/dulichan>*
>>   *~SO     @chan <http://stackoverflow.com/users/813471/chan>*
>>
>
>
>
> --
>
> *Ruchira Wageesha**Associate Technical Lead*
> *WSO2 Inc. - lean . enterprise . middleware |  wso2.com <http://wso2.com>*
>
> *email: ruch...@wso2.com <ruch...@wso2.com>,   blog:
> ruchirawageesha.blogspot.com <http://ruchirawageesha.blogspot.com>,
> mobile: +94 77 5493444 <%2B94%2077%205493444>*
>



-- 
Chan (Dulitha Wijewantha)
Software Engineer - Mobile Development
WSO2Mobile
Lean.Enterprise.Mobileware
 * ~Email       duli...@wso2.com <duli...@wso2mobile.com>*
*  ~Mobile     +94712112165*
*  ~Website   dulitha.me <http://dulitha.me>*
*  ~Twitter     @dulitharw <https://twitter.com/dulitharw>*
  *~Github     @dulichan <https://github.com/dulichan>*
  *~SO     @chan <http://stackoverflow.com/users/813471/chan>*
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to