Hi all, Please find the review notes below:
Participants: SupunS, Suho, Lasantha, Mohan, SachiniJ, Tishan, Dilini *Notes:* - Good if we can use the file name and decide the algorithm type. This will be more user friendly, because some users might give wrong algorithm type as a parameter. - Make algorithm names constants. - Create an attribute in the algorithm class for algorithm type. At init, do the string matching and assign the type (use enum); Then at the process event, use switch. - 'result' should not be a map. - Minimize object creation and garbage collection inside processEvent method. - For extensions - use different package names; otherwise only one package will be picked up by OSGI. - Better use same extension name for both. *Improvements:* - Use registry path instead of file path. - Put all Mahout models into a separate package. In the same package, define algorithm types etc. Then use those classes. This will reduce the complexity in the implementation. - Rename getModelPrediction to 'predictModel'. i.e. Get rid of 'get' prefix. OR use two extensions: one for classifying and another for predicting values. Please add/correct if I've missed/misinterpreted anything. Regards, Dilini On Fri, Aug 1, 2014 at 3:28 PM, Supun Sethunga <sup...@wso2.com> wrote: > more details » > <https://www.google.com/calendar/event?action=VIEW&eid=NjdvdnI3aWJjNXN1ZTJoamZoaWM5ZTduOTAgZGV2QHdzbzIub3Jn&tok=MTUjc3VwdW5zQHdzbzIuY29tZTczODAxYjBjMGI4ZGIxMjJmY2MxMjZmM2VhMTc5NTM0NThjOTc1OQ&ctz=Asia/Colombo&hl=en> > Code Review - CEP Extension to apply Machine Learning Models > *When* > Mon Aug 4, 2014 11am – 12pm Colombo > *Where* > LK 3rd Floor Meeting Room - Kernel (map > <http://maps.google.lk/maps?q=LK+3rd+Floor+Meeting+Room+-+Kernel&hl=en>) > *Video call* > https://plus.google.com/hangouts/_/wso2.com/code-review-cep > <https://plus.google.com/hangouts/_/wso2.com/code-review-cep?hceid=c3VwdW5zQHdzbzIuY29t.67ovr7ibc5sue2hjfhic9e7n90> > *Calendar* > Supun Sethunga > *Who* > • > Supun Sethunga - organizer > • > Seshika Fernando > • > Lasantha Fernando > • > dev@wso2.org > • > Mohanadarshan Vivekanandalingam > • > Sriskandarajah Suhothayan > • > Sajith Ravindra > • > Rajeev Sampath > > Going? *Yes > <https://www.google.com/calendar/event?action=RESPOND&eid=NjdvdnI3aWJjNXN1ZTJoamZoaWM5ZTduOTAgZGV2QHdzbzIub3Jn&rst=1&tok=MTUjc3VwdW5zQHdzbzIuY29tZTczODAxYjBjMGI4ZGIxMjJmY2MxMjZmM2VhMTc5NTM0NThjOTc1OQ&ctz=Asia/Colombo&hl=en> > - Maybe > <https://www.google.com/calendar/event?action=RESPOND&eid=NjdvdnI3aWJjNXN1ZTJoamZoaWM5ZTduOTAgZGV2QHdzbzIub3Jn&rst=3&tok=MTUjc3VwdW5zQHdzbzIuY29tZTczODAxYjBjMGI4ZGIxMjJmY2MxMjZmM2VhMTc5NTM0NThjOTc1OQ&ctz=Asia/Colombo&hl=en> > - No > <https://www.google.com/calendar/event?action=RESPOND&eid=NjdvdnI3aWJjNXN1ZTJoamZoaWM5ZTduOTAgZGV2QHdzbzIub3Jn&rst=2&tok=MTUjc3VwdW5zQHdzbzIuY29tZTczODAxYjBjMGI4ZGIxMjJmY2MxMjZmM2VhMTc5NTM0NThjOTc1OQ&ctz=Asia/Colombo&hl=en>* > more options » > <https://www.google.com/calendar/event?action=VIEW&eid=NjdvdnI3aWJjNXN1ZTJoamZoaWM5ZTduOTAgZGV2QHdzbzIub3Jn&tok=MTUjc3VwdW5zQHdzbzIuY29tZTczODAxYjBjMGI4ZGIxMjJmY2MxMjZmM2VhMTc5NTM0NThjOTc1OQ&ctz=Asia/Colombo&hl=en> > > Invitation from Google Calendar <https://www.google.com/calendar/> > > You are receiving this courtesy email at the account dev@wso2.org because > you are an attendee of this event. > > To stop receiving future notifications for this event, decline this event. > Alternatively you can sign up for a Google account at > https://www.google.com/calendar/ and control your notification settings > for your entire calendar. > > _______________________________________________ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- *Dilini Muthumala* Software Engineer, WSO2 Inc. *E-mail :* dil...@wso2.com *Mobile: *+94713 400 029
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
