Hi Gokul, Merged the Hazelcast upgrade request to the kernel git repo, please re apply ntask. It isn't that easy to merge a fix like this as we need to think about all the downstream builds. However sorry for the delay and inconvenience this made.
Thanks, Shameera. On Fri, Aug 15, 2014 at 4:43 PM, Gokul Balakrishnan <go...@wso2.com> wrote: > The Hz pull request was 6 days old and should by rights have been merged, > unless there was some compelling reason stopping it (if there was, it was > never communicated). Since the change was already propagated to SVN (and > was causing a build failure) I made the fix and sent the corresponding pull > request to the carbon-utils. IMO the discrepancy between SVN and Git is > what causes situations like this. > > @Kernel team please let us know once the pull request has been merged so > that we can re-apply the fix for ntask. > > > On 15 August 2014 16:27, Gayashan Amarasinghe <gayas...@wso2.com> wrote: > >> Hi Gokul, >> >> >> On Fri, Aug 15, 2014 at 3:39 PM, Gokul Balakrishnan <go...@wso2.com> >> wrote: >> >>> I've reverted the change to ntask in Git so that the build will pass for >>> the time being, but it will have to be made again once the version upgrade >>> is merged; so IMO this is not the correct way to deal this situation, as we >>> should have merged the Hz version upgrade pull request instead. >>> >> >> +1, Agree with you on this. We need to find a better process to handle >> scenarios like this. (I have came across the same scenario when fixing >> [1].) Anyway it shouldn't have been merged to utils since the HZ upgrade >> was not there in the first place. As KasunG has mentioned it might take >> some time to get this merged to kernel. >> >> [1] https://wso2.org/jira/browse/CARBON-14867 >> >> >> >>> Any reason why we haven't done so? >>> >>> >>> On 15 August 2014 15:30, Gayashan Amarasinghe <gayas...@wso2.com> wrote: >>> >>>> Hi Gokul, >>>> >>>> Hazelcast upgrade [1] has not been merged to the >>>> wso2-dev/carbon4-kernel yet. I did check with the hazelcast upgrade on a >>>> local merge and carbon-utils (with your changes on ntask) get built without >>>> an issue. So might need to revert the changes done to carbon-utils until >>>> the relevant hz changes are merged to kernel. >>>> >>>> [1] https://github.com/wso2-dev/carbon4-kernel/pull/62 >>>> >>>> Thanks. >>>> >>>> /Gayashan >>>> >>>> >>>> On Fri, Aug 15, 2014 at 2:58 PM, Gokul Balakrishnan <go...@wso2.com> >>>> wrote: >>>> >>>>> Hi Kasun, >>>>> >>>>> Has the Hazelcast upgrade in question not been done in the git repo, >>>>> because the fix causes build failures in the ntask component under >>>>> wso2-dev >>>>> (as per mail "Build Failure in Carbon-utils")? Can you please clarify? >>>>> >>>>> Thanks, >>>>> >>>>> >>>>> On 14 August 2014 11:40, Gokul Balakrishnan <go...@wso2.com> wrote: >>>>> >>>>>> Fixed in r206532. >>>>>> >>>>>> >>>>>> On 14 August 2014 09:36, Sinthuja Ragendran <sinth...@wso2.com> >>>>>> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> Still the issue exists. Please fix it ASAP, since we need to get the >>>>>>> pack out for testing. >>>>>>> >>>>>>> Thanks, >>>>>>> Sinthuja >>>>>>> >>>>>>> >>>>>>> On Wed, Aug 13, 2014 at 10:48 AM, Shameera Rathnayaka < >>>>>>> shame...@wso2.com> wrote: >>>>>>> >>>>>>>> Hi Kasun, >>>>>>>> >>>>>>>> Please fix this, This is downstream build error with hazelcast >>>>>>>> upgrade. >>>>>>>> >>>>>>>> Cheers, >>>>>>>> Shameera. >>>>>>>> >>>>>>>> >>>>>>>> On Wed, Aug 13, 2014 at 9:53 AM, Dinusha Senanayaka < >>>>>>>> dinu...@wso2.com> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Getting following build failure. Should be relate with patch0009 >>>>>>>>> updates ? >>>>>>>>> >>>>>>>>> [ERROR] Failed to execute goal >>>>>>>>> org.apache.maven.plugins:maven-compiler-plugin:2.0.2:compile >>>>>>>>> (default-compile) on project org.wso2.carbon.ntask.core: Compilation >>>>>>>>> failure >>>>>>>>> [ERROR] >>>>>>>>> /opt/checkout_chunk13/platform/branches/turing/components/ntask/org.wso2.carbon.ntask.core/4.2.4/src/main/java/org/wso2/carbon/ntask/core/impl/clustered/ClusterGroupCommunicator.java:[45,7] >>>>>>>>> org.wso2.carbon.ntask.core.impl.clustered.ClusterGroupCommunicator is >>>>>>>>> not >>>>>>>>> abstract and does not override abstract method >>>>>>>>> memberAttributeChanged(com.hazelcast.core.MemberAttributeEvent) in >>>>>>>>> com.hazelcast.core.MembershipListener >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> Dinusha. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Dinusha Dilrukshi >>>>>>>>> Senior Software Engineer >>>>>>>>> WSO2 Inc.: http://wso2.com/ >>>>>>>>> Mobile: +94725255071 >>>>>>>>> Blog: http://dinushasblog.blogspot.com/ >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> *Software Engineer - WSO2 Inc.* >>>>>>>> *email: shameera AT wso2.com <shame...@wso2.com> , shameera AT >>>>>>>> apache.org <shame...@apache.org>* >>>>>>>> *phone: +9471 922 1454 <%2B9471%20922%201454>* >>>>>>>> >>>>>>>> *Linked in : * >>>>>>>> http://lk.linkedin.com/pub/shameera-rathnayaka/1a/661/561 >>>>>>>> *Twitter : *https://twitter.com/Shameera_R >>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> Dev mailing list >>>>>>>> Dev@wso2.org >>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Sinthuja Rajendran* >>>>>>> Senior Software Engineer <http://wso2.com/> >>>>>>> WSO2, Inc.:http://wso2.com >>>>>>> >>>>>>> Blog: http://sinthu-rajan.blogspot.com/ >>>>>>> Mobile: +94774273955 >>>>>>> >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Dev mailing list >>>>>>> Dev@wso2.org >>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Balakrishnan Gokulakrishnan* >>>>>> Software Engineer, >>>>>> WSO2, Inc. http://wso2.com >>>>>> Mob: +94 77 593 5789 | +1 650 272 9927 >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> *Balakrishnan Gokulakrishnan* >>>>> Software Engineer, >>>>> WSO2, Inc. http://wso2.com >>>>> Mob: +94 77 593 5789 | +1 650 272 9927 >>>>> >>>>> _______________________________________________ >>>>> Dev mailing list >>>>> Dev@wso2.org >>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> *Gayashan Amarasinghe* >>>> Software Engineer | Platform TG >>>> WSO2, Inc. | http://wso2.com >>>> lean. enterprise. middleware >>>> >>>> Mobile : +94718314517 >>>> Blog : gayashan-a.blogspot.com >>>> >>> >>> >>> >>> -- >>> *Balakrishnan Gokulakrishnan* >>> Software Engineer, >>> WSO2, Inc. http://wso2.com >>> Mob: +94 77 593 5789 | +1 650 272 9927 >>> >> >> >> >> -- >> *Gayashan Amarasinghe* >> Software Engineer | Platform TG >> WSO2, Inc. | http://wso2.com >> lean. enterprise. middleware >> >> Mobile : +94718314517 >> Blog : gayashan-a.blogspot.com >> > > > > -- > *Balakrishnan Gokulakrishnan* > Software Engineer, > WSO2, Inc. http://wso2.com > Mob: +94 77 593 5789 | +1 650 272 9927 > > _______________________________________________ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- *Software Engineer - WSO2 Inc.* *email: shameera AT wso2.com <shame...@wso2.com> , shameera AT apache.org <shame...@apache.org>* *phone: +9471 922 1454* *Linked in : *http://lk.linkedin.com/pub/shameera-rathnayaka/1a/661/561 *Twitter : *https://twitter.com/Shameera_R
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
