Hi Sagara, I was able to remove the CassandraLogProvider and get the commits reapplied to carbon-utils after resolving merge conflicts, etc. However in addition to the changes made to the platform by Shameera, there are couple of more places which needs changes as well. Without those changes the platform build will fail. I will send the pull request to carbon-utils after fixing those places (and sending relevant pull requests) as well.
Thanks. /Gayashan On Tue, Sep 2, 2014 at 11:59 AM, Gayashan Amarasinghe <gayas...@wso2.com> wrote: > Hi Sagara, > > I went through the changes and had a chat with Sameera as well. > > +1 for removing the cassandra-thrift and hector-core dependencies from the > carbon-utils repo since carbon-utils is depended upon by many products. If > we are to remove these dependencies then we have to remove the > CassandraLogProvider from the package as well. Since this is a useful class > for some of the products however we have to move this class to a different > repo, which ensures that this can be used by products as and when needed. I > will send a separate mail regarding this. > > I'll also resend the pull request with the changes. > > Thanks. > /Gayashan > > > On Tue, Sep 2, 2014 at 11:16 AM, Gayashan Amarasinghe <gayas...@wso2.com> > wrote: > >> Hi Sagara, >> >> These changes were done by Shameera as a result of simplifying the carbon >> logging story [1]. Since he is not available I will look in to these >> changes and provide an update asap. >> >> [1] https://wso2.org/jira/browse/COMMONS-110 >> >> Thanks. >> /Gayashan >> >> >> >> On Tue, Sep 2, 2014 at 11:10 AM, Sagara Gunathunga <sag...@wso2.com> >> wrote: >> >>> >>> Hi Gayashan, >>> >>> It seems like new logging service introduces cassandra-thrift, >>> hector-core as dependencies into carbon-util (carbon-common) project bit >>> IMHO neither Carbon logging service nor carbon-util should have these >>> dependencies, shall we get rid of them ? >>> >>> Anyway I'm getting following build fail with PR-16 [1] . >>> >>> [ERROR] Failed to execute goal on project >>> org.wso2.carbon.logging.service: Could not resolve dependencies for project >>> org.wso2.carbon:org.wso2.carbon.logging.service:bundle:4.3.0-SNAPSHOT: >>> Failure to find org.apache.cassandra.wso2:cassandra-thrift:jar:1.1.0.wso2v1 >>> in http://maven.wso2.org/nexus/content/groups/wso2-public/ was cached >>> in the local repository, resolution will not be reattempted until the >>> update interval of wso2-nexus has elapsed or updates are forced -> [Help 1] >>> >>> [1] - https://github.com/wso2-dev/carbon-utils/pull/16/files >>> >>> Thanks ! >>> -- >>> Sagara Gunathunga >>> >>> Senior Technical Lead; WSO2, Inc.; http://wso2.com >>> V.P Apache Web Services; http://ws.apache.org/ >>> Linkedin; http://www.linkedin.com/in/ssagara >>> Blog ; http://ssagara.blogspot.com >>> >>> >> >> >> -- >> *Gayashan Amarasinghe* >> Software Engineer | Platform TG >> WSO2, Inc. | http://wso2.com >> lean. enterprise. middleware >> >> Mobile : +94718314517 >> Blog : gayashan-a.blogspot.com >> > > > > -- > *Gayashan Amarasinghe* > Software Engineer | Platform TG > WSO2, Inc. | http://wso2.com > lean. enterprise. middleware > > Mobile : +94718314517 > Blog : gayashan-a.blogspot.com > -- *Gayashan Amarasinghe* Software Engineer | Platform TG WSO2, Inc. | http://wso2.com lean. enterprise. middleware Mobile : +94718314517 Blog : gayashan-a.blogspot.com
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
