Hi Akalanka, I have updated the pull request with your suggestions.
Regards, Firzhan On Tue, Nov 11, 2014 at 8:33 AM, Akalanka Pagoda Arachchi < darsha...@wso2.com> wrote: > Hi Firzhan, > > Isn't it a good idea to completely delete the lines you have commented out > in > 'components/bpmn/org.wso2.carbon.bpmn/src/main/java/org/wso2/carbon/bpmn/core/db/Database.java' > file if they are not necessary? Or else I think it's better to add a > comment why you have commented out those, to help the one who's editing > this after you. Also I believe after this change the method description > should change as well? > > Thanks, > Akalanka > > On Mon, Nov 10, 2014 at 10:43 PM, Firzhan Naqash <firz...@wso2.com> wrote: > >> Hi, >> >> Please commit the pull request [1] . The changes are related on updating >> the activiti version. >> >> [1] https://github.com/wso2-dev/carbon-business-process/pull/21 >> Regards, >> Firzhan >> >> _______________________________________________ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > *Darshana Akalanka Pagoda Arachchi,* > *Software Engineer* > *078-4721791* >
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
