On Fri, Jan 23, 2015 at 1:37 PM, Afkham Azeez <az...@wso2.com> wrote:
> +1 from me to adding this since like Dimuthu explained, this public method > should be called only from within registry code and not from bundles > outside registry. > +1 Even within the registry code Mount bean is only used to read mount configuration from registry.xml file, other than that there is no any other use cases. Thanks ! > > On Fri, Jan 23, 2015 at 6:04 AM, Chandana Napagoda <chand...@wso2.com> > wrote: > >> HI Sameera/Azeez, >> >> Can you please share your thought on this? We want to sort out this ASAP. >> >> Regards, >> Chandana >> >> On Wed, Jan 21, 2015 at 3:29 PM, Dimuthu Leelarathne <dimut...@wso2.com> >> wrote: >> >>> Hi Manoj, >>> >>> The Mount bean is not an API. Mount bean is meant be used within >>> registry itself. Nowhere else. >>> >>> thanks, >>> dimuthu >>> >>> On Wed, Jan 21, 2015 at 3:08 PM, Chandana Napagoda <chand...@wso2.com> >>> wrote: >>> >>>> Hi Manoj, >>>> >>>> Yes, We have introduced a public getter method and a setter for Mount >>>> beans. It was not possible to use protected or private variables/methods to >>>> perform this operation, since RegistryConfigurationProcessor and >>>> RegistryUtils classes are in two different packages. Therefore we >>>> introduced these methods since newly added getter and setter methods are >>>> referred inside the same bundle only. So there will not be any impact on >>>> the existing code base. >>>> >>>> Regards, >>>> Chandana >>>> >>>> On Wed, Jan 21, 2015 at 12:59 PM, Manoj Kumara <ma...@wso2.com> wrote: >>>> >>>>> Hi Chandana, >>>>> >>>>> Attached diff contain some public getter and setter additions. We >>>>> don't allow API changes during kernel patches. >>>>> >>>>> Thanks, >>>>> Manoj >>>>> >>>>> >>>>> *Manoj Kumara* >>>>> Software Engineer >>>>> WSO2 Inc. http://wso2.com/ >>>>> *lean.enterprise.middleware* >>>>> Mobile: +94713448188 >>>>> >>>>> On Wed, Jan 21, 2015 at 10:25 AM, Chandana Napagoda <chand...@wso2.com >>>>> > wrote: >>>>> >>>>>> Hi Manoj, >>>>>> >>>>>> Please apply the patch attached to below JIRA [1]. >>>>>> >>>>>> [1] https://wso2.org/jira/browse/REGISTRY-2391 >>>>>> >>>>>> Regards, >>>>>> Chandana >>>>>> >>>>>> -- >>>>>> *Chandana Napagoda* >>>>>> Senior Software Engineer >>>>>> WSO2 Inc. - http://wso2.org >>>>>> >>>>>> *Email : chand...@wso2.com <chand...@wso2.com>**Mobile : >>>>>> +94718169299 <%2B94718169299>* >>>>>> >>>>>> *Blog : http://cnapagoda.blogspot.com >>>>>> <http://cnapagoda.blogspot.com>* >>>>>> >>>>>> >>>>> >>>> >>>> >>>> -- >>>> *Chandana Napagoda* >>>> Senior Software Engineer >>>> WSO2 Inc. - http://wso2.org >>>> >>>> *Email : chand...@wso2.com <chand...@wso2.com>**Mobile : >>>> +94718169299 <%2B94718169299>* >>>> >>>> *Blog : http://cnapagoda.blogspot.com >>>> <http://cnapagoda.blogspot.com>* >>>> >>>> >>> >>> >>> -- >>> Dimuthu Leelarathne >>> Architect & Product Lead of App Factory >>> >>> WSO2, Inc. (http://wso2.com) >>> email: dimut...@wso2.com >>> Mobile : 0773661935 >>> >>> Lean . Enterprise . Middleware >>> >> >> >> >> -- >> *Chandana Napagoda* >> Senior Software Engineer >> WSO2 Inc. - http://wso2.org >> >> *Email : chand...@wso2.com <chand...@wso2.com>**Mobile : +94718169299 >> <%2B94718169299>* >> >> *Blog : http://cnapagoda.blogspot.com <http://cnapagoda.blogspot.com>* >> >> > > > -- > *Afkham Azeez* > Director of Architecture; WSO2, Inc.; http://wso2.com > Member; Apache Software Foundation; http://www.apache.org/ > * <http://www.apache.org/>* > *email: **az...@wso2.com* <az...@wso2.com> > * cell: +94 77 3320919 <%2B94%2077%203320919>blog: * > *http://blog.afkham.org* <http://blog.afkham.org> > *twitter: **http://twitter.com/afkham_azeez* > <http://twitter.com/afkham_azeez> > *linked-in: **http://lk.linkedin.com/in/afkhamazeez > <http://lk.linkedin.com/in/afkhamazeez>* > > *Lean . Enterprise . Middleware* > -- Sagara Gunathunga Senior Technical Lead; WSO2, Inc.; http://wso2.com V.P Apache Web Services; http://ws.apache.org/ Linkedin; http://www.linkedin.com/in/ssagara Blog ; http://ssagara.blogspot.com
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
