Also have you done a final test on these orbits (after all the changes) with the product?
On Wed, Feb 18, 2015 at 9:38 AM, Pulasthi Mahawithana <pulast...@wso2.com> wrote: > Hi Kishanthan, > > I had missed that one, Corrected now. > > On Wed, Feb 18, 2015 at 9:33 AM, Kishanthan Thangarajah < > kishant...@wso2.com> wrote: > >> So DynamicImport-Package * is needed for bcpkix-jdk15on? >> >> On Wed, Feb 18, 2015 at 12:00 AM, Pulasthi Mahawithana < >> pulast...@wso2.com> wrote: >> >>> Hi Kishanthan, >>> >>> Resolved the new comments and removed the dynamic imports. The previous >>> comments had been resolved, but some are still visible since they had no >>> new changes to the commented line. >>> >>> On Tue, Feb 17, 2015 at 7:53 PM, Kishanthan Thangarajah < >>> kishant...@wso2.com> wrote: >>> >>>> I still see dynamic imports in these orbits. If it is not needed you >>>> need to remove them. Also some comments that were added are not resolved >>>> yet. >>>> >>>> On Tue, Feb 17, 2015 at 6:12 PM, Dilshan Edirisuriya <dils...@wso2.com> >>>> wrote: >>>> >>>>> Hi Kishanthan/Maheshika, >>>>> >>>>> Can you please look into this since we have a dependencies to these >>>>> orbit bundles as well for our next milestone which is due this week. >>>>> >>>>> Regards, >>>>> >>>>> Dilshan >>>>> >>>>> On Tue, Feb 17, 2015 at 12:21 PM, Dilshan Edirisuriya < >>>>> dils...@wso2.com> wrote: >>>>> >>>>>> As far as I can remember this does not need it. So we can remove it. >>>>>> >>>>>> Regards, >>>>>> >>>>>> Dilshan >>>>>> >>>>>> On Tue, Feb 17, 2015 at 12:16 PM, Pulasthi Mahawithana < >>>>>> pulast...@wso2.com> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> On Mon, Feb 16, 2015 at 7:50 PM, Kishanthan Thangarajah < >>>>>>> kishant...@wso2.com> wrote: >>>>>>> >>>>>>>> I added some comments/concerns. Can you look into them? >>>>>>>> >>>>>>> >>>>>>> Corrected them. Thanks for pointing out. >>>>>>> >>>>>>> @ Dilshan, >>>>>>> Removed dynamic imports from the initial versions of jscep and >>>>>>> bcpkix, since I could not find any need for that in their sources. >>>>>>> Please >>>>>>> comment if that is still needed. >>>>>>> >>>>>>>> >>>>>>>> On Mon, Feb 16, 2015 at 12:27 PM, Pulasthi Mahawithana < >>>>>>>> pulast...@wso2.com> wrote: >>>>>>>> >>>>>>>>> Hi Sameera, >>>>>>>>> >>>>>>>>> Please review and merge [1]. It has updates to following >>>>>>>>> >>>>>>>>> 1. Commons-IO - 2.4.0.wso2v1 - Required by JSCEP >>>>>>>>> 2. JSCEP - 2.0.2.wso2v2 - Updated with commons-io 2.4 >>>>>>>>> 3. BCPKIX - 1.49.0.wso2v2 - Fix for signature validation issue >>>>>>>>> (similar to what was done to bcprov) >>>>>>>>> >>>>>>>>> >>>>>>>>> [1] https://github.com/wso2/orbit/pull/63 >>>>>>>>> >>>>>>>>> -- >>>>>>>>> *Pulasthi Mahawithana* >>>>>>>>> Software Engineer >>>>>>>>> WSO2 Inc., http://wso2.com/ >>>>>>>>> Mobile: +94-71-5179022 >>>>>>>>> Blog: http://blog.pulasthi.org >>>>>>>>> >>>>>>>>> _______________________________________________ >>>>>>>>> Dev mailing list >>>>>>>>> Dev@wso2.org >>>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> *Kishanthan Thangarajah* >>>>>>>> Senior Software Engineer, >>>>>>>> Platform Technologies Team, >>>>>>>> WSO2, Inc. >>>>>>>> lean.enterprise.middleware >>>>>>>> >>>>>>>> Mobile - +94773426635 >>>>>>>> Blog - *http://kishanthan.wordpress.com >>>>>>>> <http://kishanthan.wordpress.com>* >>>>>>>> Twitter - *http://twitter.com/kishanthan >>>>>>>> <http://twitter.com/kishanthan>* >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Pulasthi Mahawithana* >>>>>>> Software Engineer >>>>>>> WSO2 Inc., http://wso2.com/ >>>>>>> Mobile: +94-71-5179022 >>>>>>> Blog: http://blog.pulasthi.org >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dilshan Edirisuriya >>>>>> Senior Software Engineer - WSO2 >>>>>> Mob: + 94 777878905 >>>>>> http://wso2.com/ >>>>>> https://www.linkedin.com/profile/view?id=50486426 >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Dilshan Edirisuriya >>>>> Senior Software Engineer - WSO2 >>>>> Mob: + 94 777878905 >>>>> http://wso2.com/ >>>>> https://www.linkedin.com/profile/view?id=50486426 >>>>> >>>> >>>> >>>> >>>> -- >>>> *Kishanthan Thangarajah* >>>> Senior Software Engineer, >>>> Platform Technologies Team, >>>> WSO2, Inc. >>>> lean.enterprise.middleware >>>> >>>> Mobile - +94773426635 >>>> Blog - *http://kishanthan.wordpress.com >>>> <http://kishanthan.wordpress.com>* >>>> Twitter - *http://twitter.com/kishanthan >>>> <http://twitter.com/kishanthan>* >>>> >>> >>> >>> >>> -- >>> *Pulasthi Mahawithana* >>> Software Engineer >>> WSO2 Inc., http://wso2.com/ >>> Mobile: +94-71-5179022 >>> Blog: http://blog.pulasthi.org >>> >> >> >> >> -- >> *Kishanthan Thangarajah* >> Senior Software Engineer, >> Platform Technologies Team, >> WSO2, Inc. >> lean.enterprise.middleware >> >> Mobile - +94773426635 >> Blog - *http://kishanthan.wordpress.com >> <http://kishanthan.wordpress.com>* >> Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>* >> > > > > -- > *Pulasthi Mahawithana* > Software Engineer > WSO2 Inc., http://wso2.com/ > Mobile: +94-71-5179022 > Blog: http://blog.pulasthi.org > -- *Kishanthan Thangarajah* Senior Software Engineer, Platform Technologies Team, WSO2, Inc. lean.enterprise.middleware Mobile - +94773426635 Blog - *http://kishanthan.wordpress.com <http://kishanthan.wordpress.com>* Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>*
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
