DimuthuD, I still see submodule dependencies having version defined even though they are defined in the parent pom Eg: distribution/integration/test-common/integration-test-utils/pom.xml.
Also when adding new dependencies to dependencyManagement section, check whether they are already added. If yes, we will end up having duplicated dependencies. On Fri, Feb 13, 2015 at 4:26 PM, Dimuthu De Lanerolle <dimut...@wso2.com> wrote: > Hi Krishantha / Kishanthan, > > The pull request is updated accordingly. > > Regards > > On Fri, Feb 13, 2015 at 11:08 AM, Krishantha Samaraweera < > krishan...@wso2.com> wrote: > >> Hi Dimuthu, >> >> Can you fix all the problems and send a pull again. >> >> Thanks, >> Krishantha. >> >> On Tue, Feb 10, 2015 at 10:18 PM, Kishanthan Thangarajah < >> kishant...@wso2.com> wrote: >> >>> Hi DimuthuD, >>> >>> While trying to merge this, I found some pom level issues with the >>> integration module that should be fixed. >>> >>> 1. We need to remove the dependencyManagement section in >>> distribution/integration/pom.xml and move all those dependencies to the >>> root pom at carbon4-kernel/parent/pom.xml >>> 2. Submodule pom's should not have versions defined/hard-coded for any >>> dependencies, instead they should be defined at root parent pom. The same >>> applied for maven build plugins sections as-well. >>> >>> So shall we also fix the above with this effort? >>> >>> On Fri, Jan 23, 2015 at 7:39 PM, Dimuthu De Lanerolle <dimut...@wso2.com >>> > wrote: >>> >>>> Hi Kishanthan, >>>> >>>> Yes, we have the updated PR [1] which is compatible with the master >>>> branch to-date. Pls merge. >>>> >>>> [1] https://github.com/wso2/carbon4-kernel/pull/132 >>>> >>>> Regards >>>> >>>> On Thu, Jan 22, 2015 at 11:09 PM, Kishanthan Thangarajah < >>>> kishant...@wso2.com> wrote: >>>> >>>>> Great. Thanks Dimuthu and Krishantha. So we just have to remove the >>>>> old framework from code base right? Also can we get the updated PR on this >>>>> migration sent to master branch, if not already done? >>>>> >>>>> On Wed, Jan 21, 2015 at 11:57 PM, Krishantha Samaraweera < >>>>> krishan...@wso2.com> wrote: >>>>> >>>>>> Hi Dimuthu, >>>>>> >>>>>> Thanks for attending to this. >>>>>> >>>>>> We need to remove the old test framework in kernel and test suite. >>>>>> >>>>>> Thanks, >>>>>> Krishantha. >>>>>> >>>>>> On Wed, Jan 21, 2015 at 8:24 PM, Dimuthu De Lanerolle < >>>>>> dimut...@wso2.com> wrote: >>>>>> >>>>>>> This is completed. Please find the test result for carbon-kernel4 >>>>>>> tests-integration module. >>>>>>> >>>>>>> Test results >>>>>>> SuitePassedFailedSkippedtestng.xml*Total**24**0**0* >>>>>>> carbon-server-startup <http://carbon-server-startup/index.html>2400 >>>>>>> Link <http://carbon-server-startup/testng.xml.html> >>>>>>> >>>>>>> >>>>>>> Regards >>>>>>> >>>>>>> >>>>>>> On Tue, Jan 20, 2015 at 3:07 PM, Dimuthu De Lanerolle < >>>>>>> dimut...@wso2.com> wrote: >>>>>>> >>>>>>>> I have started migrating carbon4-kernel tests inside [1] "tests" >>>>>>>> module to "tests-integration" module which is going to be compatible >>>>>>>> with >>>>>>>> new TAF 4.3.1 framework. Will update progress soon. >>>>>>>> >>>>>>>> [1] >>>>>>>> https://github.com/buddhics/carbon4-kernel/tree/master/distribution/integration >>>>>>>> >>>>>>>> >>>>>>>> Regards >>>>>>>> >>>>>>>> -- >>>>>>>> Dimuthu De Lanerolle >>>>>>>> Software Engineer >>>>>>>> WSO2 Inc. >>>>>>>> lean . enterprise . middlewear. >>>>>>>> http://wso2.com/ >>>>>>>> Tel. : +94 11 2145345 Fax : +94 11 2145300 email : >>>>>>>> dimut...@wso2.com >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dimuthu De Lanerolle >>>>>>> Software Engineer >>>>>>> WSO2 Inc. >>>>>>> lean . enterprise . middlewear. >>>>>>> http://wso2.com/ >>>>>>> Tel. : +94 11 2145345 Fax : +94 11 2145300 email : >>>>>>> dimut...@wso2.com >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Krishantha Samaraweera >>>>>> Senior Technical Lead - Test Automation >>>>>> Mobile: +94 77 7759918 >>>>>> WSO2, Inc.; http://wso2.com/ >>>>>> lean . enterprise . middlewear. >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> *Kishanthan Thangarajah* >>>>> Senior Software Engineer, >>>>> Platform Technologies Team, >>>>> WSO2, Inc. >>>>> lean.enterprise.middleware >>>>> >>>>> Mobile - +94773426635 >>>>> Blog - *http://kishanthan.wordpress.com >>>>> <http://kishanthan.wordpress.com>* >>>>> Twitter - *http://twitter.com/kishanthan >>>>> <http://twitter.com/kishanthan>* >>>>> >>>> >>>> >>>> >>>> -- >>>> Dimuthu De Lanerolle >>>> Software Engineer >>>> WSO2 Inc. >>>> lean . enterprise . middlewear. >>>> http://wso2.com/ >>>> Tel. : +94 11 2145345 Fax : +94 11 2145300 email : dimut...@wso2.com >>>> >>>> >>> >>> >>> -- >>> *Kishanthan Thangarajah* >>> Senior Software Engineer, >>> Platform Technologies Team, >>> WSO2, Inc. >>> lean.enterprise.middleware >>> >>> Mobile - +94773426635 >>> Blog - *http://kishanthan.wordpress.com >>> <http://kishanthan.wordpress.com>* >>> Twitter - *http://twitter.com/kishanthan >>> <http://twitter.com/kishanthan>* >>> >> >> >> >> -- >> Krishantha Samaraweera >> Senior Technical Lead - Test Automation >> Mobile: +94 77 7759918 >> WSO2, Inc.; http://wso2.com/ >> lean . enterprise . middlewear. >> > > > > -- > Dimuthu De Lanerolle > Software Engineer > WSO2 Inc. > lean . enterprise . middlewear. > http://wso2.com/ > Tel. : +94 11 2145345 Fax : +94 11 2145300 email : dimut...@wso2.com > > -- *Kishanthan Thangarajah* Senior Software Engineer, Platform Technologies Team, WSO2, Inc. lean.enterprise.middleware Mobile - +94773426635 Blog - *http://kishanthan.wordpress.com <http://kishanthan.wordpress.com>* Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>*
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
