I can't see any particular reason. +1 to fix it.

On Thu, Feb 19, 2015 at 4:28 PM, Gayan Gunawardana <ga...@wso2.com> wrote:

> Hi,
>
> In user core [1] JDBCUserStoreManager,  persistUser user method contains
> catching Throwable. In general catching Throwable is not a good practice
> because there may be some run time Errors like OutOfMemoryError which are
> not be able to handle. Is there any particular reason to catch Throwable?
>
> [1]
> https://github.com/wso2/carbon4-kernel/blob/master/core/org.wso2.carbon.user.core/src/main/java/org/wso2/carbon/user/core/jdbc/JDBCUserStoreManager.java
> --
> Gayan Gunawardana
> Software Engineer; WSO2 Inc.; http://wso2.com/
> Email: ga...@wso2.com
> Mobile: +94 (71) 8020933
>



-- 
Thanks & Regards,

*Johann Dilantha Nallathamby*
Associate Technical Lead & Product Lead of WSO2 Identity Server
Integration Technologies Team
WSO2, Inc.
lean.enterprise.middleware

Mobile - *+94777776950*
Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>*
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to