Hi Gayan, I don't think it's a good strategy to replicate the same set of tables across different SQL scripts (belong to different components). If some functionality is there to be reused, that needs to be done through the proper high-level APIs exposed by the relevant business components. Making one component depend on a database schema introduced by some other component is a clear indication of the design level issues that may perhaps exist within the implementation of the former, which need to be fixed. Please raise a JIRA and get this fixed, if there's no any strong reason backing up this sort of a design.
Cheers, Prabath On Mon, Feb 23, 2015 at 12:28 PM, Gayan Gunawardana <[email protected]> wrote: > > > On Mon, Feb 23, 2015 at 6:29 AM, Dilan Udara Ariyaratne <[email protected]> > wrote: > >> Hi Gayan, >> >> Does this mean that the ORACLE Script residing inside "identity" >> directory in <emm-script>/dbscripts is redundant >> and not necessary to have? >> > > APIM db script does not contain all tables in IDENTITY db script so > better to keep IDENTITY db script too. > >> >> Thanks. >> >> >> >> *Dilan U. Ariyaratne* >> Software Engineer >> WSO2 Inc. <http://wso2.com/> >> Mobile: +94775149066 >> lean . enterprise . middleware >> >> On Sun, Feb 22, 2015 at 11:02 AM, Gayan Gunawardana <[email protected]> >> wrote: >> >>> >>> >>> On Fri, Feb 20, 2015 at 11:50 PM, Dilan Udara Ariyaratne < >>> [email protected]> wrote: >>> >>>> Hi Folks, >>>> >>>> While checking the database scripts of both API Manager and IDENTITY >>>> modules inside EMM 1.1.0, >>>> it has been found out that there are some DB Table definitions of >>>> IDENTITY repeated inside APIM DB Scripts >>>> as follows. >>>> >>>> IDN_BASE_TABLE >>>> IDN_OAUTH_CONSUMER_APPS >>>> IDN_OAUTH1A_REQUEST_TOKEN >>>> IDN_OAUTH1A_ACCESS_TOKEN >>>> IDN_OAUTH2_AUTHORIZATION_CODE >>>> IDN_OAUTH2_ACCESS_TOKEN >>>> IDN_OPENID_USER_RPS >>>> IDN_THRIFT_SESSION >>>> >>>> Do we have any valid reasons to have such duplication of these table >>>> definitions inside >>>> both APIM and IDENTITY DB Scripts? >>>> >>> check EMM 1.1.0 identity.xml DataSource. I guess it is jdbc/WSO2AM_DB so >>> for IDENTITY and APIM you are using tables inside APIM db script. Even >>> though both DB scripts contains IDN_* tables there is no such a >>> duplication. >>> >>> >>>> >>>> Appreciate your feedback on this. >>>> >>>> Thanks. >>>> >>>> *Dilan U. Ariyaratne* >>>> Software Engineer >>>> WSO2 Inc. <http://wso2.com/> >>>> Mobile: +94775149066 >>>> lean . enterprise . middleware >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> [email protected] >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> Gayan Gunawardana >>> Software Engineer; WSO2 Inc.; http://wso2.com/ >>> Email: [email protected] >>> Mobile: +94 (71) 8020933 >>> >> >> > > > -- > Gayan Gunawardana > Software Engineer; WSO2 Inc.; http://wso2.com/ > Email: [email protected] > Mobile: +94 (71) 8020933 > -- Prabath Abeysekara Associate Technical Lead, Data TG. WSO2 Inc. Email: [email protected] Mobile: +94774171471
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
