Hi Kasun, May I know the progress of this?
Cheers On Tue, Feb 24, 2015 at 4:26 PM, Niranda Perera <[email protected]> wrote: > Hi Kasun, > > Sorry my mistake. I put those in to test an orbit build locally. forgot to > remove it in the commit. > > https://github.com/wso2/orbit/pull/65 > > On Tue, Feb 24, 2015 at 4:20 PM, KasunG Gajasinghe <[email protected]> > wrote: > >> Hi, >> >> Did you push all the changes? I still see that root pom has sub-module >> references. >> >> >> On Tue, Feb 24, 2015 at 4:05 PM, Niranda Perera <[email protected]> wrote: >> >>> Hi Kasun, >>> >>> here are the changes I did. >>> >>> 1. done >>> 2. changed >>> org.wso2.apache.spark >>> org.wso2.apache.hadoop >>> org.wso2.clearspring.analytics >>> org.wso2.json4s >>> org.wso2.uncommons.maths >>> org.wso2.twitter >>> >>> 3. done >>> >>> 4. the todo was to resolve the private packages warnings. But I have to >>> include the private packages. so, I removed the todo item >>> >>> 5. that was how it was done in the 1.1.0 orbit bundle. but the jar >>> imports are optional. they are already in the spark core resources, so >>> deleted those. >>> >>> 6. uncommon-maths do not need any imports >>> >>> Could you please check it. [1] >>> >>> [1] https://github.com/wso2/orbit/pull/65 >>> >>> Thanks >>> >>> On Tue, Feb 24, 2015 at 1:10 PM, KasunG Gajasinghe <[email protected]> >>> wrote: >>> >>>> Hi Niranda, >>>> >>>> Please do the following sugestions on these orbit bundles. There's a >>>> quite number of orbits here, hence the long list! >>>> >>>> 1. Set the dependencies as optional. >>>> >>>> 2. The groupId should start with org.wso2.*. This is a recent addition >>>> to policy to make our orbit bundles compatible with maven central artifact >>>> policies. >>>> >>>> 3. Remove the references from parent orbit pom >>>> >>>> 4. There's a TODO item in the spark-core_2.10 orbit. Can you fix that >>>> before releasing this? >>>> >>>> 5. Why are the conf files created in spark-core_2.10 orbit. It looks >>>> like this is coming from a third-party jar. Please use <Include-Resource> >>>> instruction for this as well like you have done for other config files. >>>> >>>> 6. Use explicit imports in uncommons-maths orbit. >>>> >>>> Thanks. >>>> >>>> >>>> On Tue, Feb 24, 2015 at 12:45 PM, KasunG Gajasinghe <[email protected]> >>>> wrote: >>>> >>>>> >>>>> Sure Sameera. >>>>> >>>>> On Tue, Feb 24, 2015 at 12:32 PM, Sameera Jayasoma <[email protected]> >>>>> wrote: >>>>> >>>>>> KasunG can you have a look at this. >>>>>> >>>>>> >>>>>> On Tue, Feb 24, 2015 at 10:20 AM, Niranda Perera <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Hi Sameera, >>>>>>> >>>>>>> Please review and merge this PR [1] >>>>>>> >>>>>>> It adds the spark core and sql v1.2.1 to the orbit together with, >>>>>>> hadoop-client v2.2.0 >>>>>>> Uncommons Math v1.2.2 >>>>>>> json4s-jackson_2.10 v3.2.10 >>>>>>> twitter chill and java v0.5.0 >>>>>>> stream v2.2.0 >>>>>>> >>>>>>> Would be very grateful if you could attend to this ASAP because we >>>>>>> have scheduled a M1 release by the EOD today 24th Feb. >>>>>>> >>>>>>> I have reviewed the spark core and sql bundles with KIshanthan last >>>>>>> week. Much appreciate if you could go through the poms nevertheless. >>>>>>> >>>>>>> cheers >>>>>>> >>>>>>> [1] https://github.com/wso2/orbit/pull/65 >>>>>>> >>>>>>> -- >>>>>>> *Niranda Perera* >>>>>>> Software Engineer, WSO2 Inc. >>>>>>> Mobile: +94-71-554-8430 >>>>>>> Twitter: @n1r44 <https://twitter.com/N1R44> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Sameera Jayasoma, >>>>>> Software Architect, >>>>>> >>>>>> WSO2, Inc. (http://wso2.com) >>>>>> email: [email protected] >>>>>> blog: http://blog.sameera.org >>>>>> twitter: https://twitter.com/sameerajayasoma >>>>>> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections >>>>>> Mobile: 0094776364456 >>>>>> >>>>>> Lean . Enterprise . Middleware >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. >>>>> email: kasung AT spamfree wso2.com >>>>> linked-in: http://lk.linkedin.com/in/gajasinghe >>>>> blog: http://kasunbg.org >>>>> >>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> >>>> *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. >>>> email: kasung AT spamfree wso2.com >>>> linked-in: http://lk.linkedin.com/in/gajasinghe >>>> blog: http://kasunbg.org >>>> >>>> >>>> >>> >>> >>> >>> -- >>> *Niranda Perera* >>> Software Engineer, WSO2 Inc. >>> Mobile: +94-71-554-8430 >>> Twitter: @n1r44 <https://twitter.com/N1R44> >>> >> >> >> >> -- >> >> *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. >> email: kasung AT spamfree wso2.com >> linked-in: http://lk.linkedin.com/in/gajasinghe >> blog: http://kasunbg.org >> >> >> > > > > -- > *Niranda Perera* > Software Engineer, WSO2 Inc. > Mobile: +94-71-554-8430 > Twitter: @n1r44 <https://twitter.com/N1R44> > -- *Niranda Perera* Software Engineer, WSO2 Inc. Mobile: +94-71-554-8430 Twitter: @n1r44 <https://twitter.com/N1R44>
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
