Changed accordingly. Find the PR in [1] [1] https://github.com/wso2/carbon-identity/pull/102
On Sat, Feb 28, 2015 at 8:06 PM, Johann Nallathamby <[email protected]> wrote: > Please find comments on PR. > > On Fri, Feb 27, 2015 at 11:53 AM, Nuwandi Wickramasinghe < > [email protected]> wrote: > >> Please check updated PR in [1] >> >> [1] https://github.com/wso2/carbon-identity/pull/102 >> >> Thanks >> >> On Thu, Feb 26, 2015 at 2:40 PM, Nuwandi Wickramasinghe < >> [email protected]> wrote: >> >>> Hi, >>> >>> Code review feedback can be found in [1] >>> >>> [1] >>> https://docs.google.com/a/wso2.com/document/d/1KGYP_yX3gXe3HuZmnkjNfnaJCpHsW2bOFoFlnaFLDXE >>> >>> On Wed, Feb 25, 2015 at 4:46 PM, Nuwandi Wickramasinghe < >>> [email protected]> wrote: >>> >>>> Hi, >>>> >>>> Please find the fix for [1] in PR [2] >>>> >>>> Thanks >>>> >>>> [1] https://wso2.org/jira/browse/IDENTITY-3028 >>>> [2] https://github.com/wso2/carbon-identity/pull/102 >>>> >>>> -- >>>> >>>> Best Regards, >>>> >>>> Nuwandi Wickramasinghe >>>> >>>> Software Engineer >>>> >>>> WSO2 Inc. >>>> >>>> Web : http://wso2.com >>>> >>>> Mobile : 0719214873 >>>> >>> >>> >>> >>> -- >>> >>> Best Regards, >>> >>> Nuwandi Wickramasinghe >>> >>> Software Engineer >>> >>> WSO2 Inc. >>> >>> Web : http://wso2.com >>> >>> Mobile : 0719214873 >>> >> >> >> >> -- >> >> Best Regards, >> >> Nuwandi Wickramasinghe >> >> Software Engineer >> >> WSO2 Inc. >> >> Web : http://wso2.com >> >> Mobile : 0719214873 >> > > > > -- > Thanks & Regards, > > *Johann Dilantha Nallathamby* > Associate Technical Lead & Product Lead of WSO2 Identity Server > Integration Technologies Team > WSO2, Inc. > lean.enterprise.middleware > > Mobile - *+94777776950* > Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* > -- Best Regards, Nuwandi Wickramasinghe Software Engineer WSO2 Inc. Web : http://wso2.com Mobile : 0719214873
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
