Yes, we will have to because of the above mentioned reason. On Mon, Mar 30, 2015 at 11:54 AM, Niranda Perera <nira...@wso2.com> wrote:
> Hi Kasun, > > the issue here is these are not orbit bundles. they are available as OSGI > bundles OOTB. > > so, shall we create an orbit bundle with that artifact id? > > rgds > > On Mon, Mar 30, 2015 at 11:52 AM, KasunG Gajasinghe <kas...@wso2.com> > wrote: > >> Hi, >> >> Shall we rename the protobuf-java orbit bundle spark as >> spark-protobuf-java. it's looks meaningful that way as well. Having two >> bundles with same name but different versions will confuse users since >> these two bundles are completely different. >> >> Protobuf was originated from Google, so the artifactId of the google >> protobuf bundle can be kept intact. >> >> >> >> On Fri, Mar 27, 2015 at 11:23 AM, Supun Sethunga <sup...@wso2.com> wrote: >> >>> Hi, >>> >>> Any update on this? ML team is facing the same issue, and has become a >>> blocker for ML M2 release too. >>> >>> Thanks, >>> Supun >>> >>> On Fri, Mar 27, 2015 at 10:05 AM, Niranda Perera <nira...@wso2.com> >>> wrote: >>> >>>> Hi Sameera, >>>> >>>> A kind reminder on this mail. this is actually a blocker for the BAM m3 >>>> release. >>>> >>>> rgds >>>> >>>> On Wed, Mar 18, 2015 at 1:43 PM, Niranda Perera <nira...@wso2.com> >>>> wrote: >>>> >>>>> Hi Sameera, >>>>> >>>>> It seems like Carbon P2 plugin does not allow having same artifact ids >>>>> in different jars. >>>>> >>>>> I created a separate orbit bundle with the following config, >>>>> <groupId>org.wso2.orbit.org.spark-project.protobuf</groupId> >>>>> <artifactId>protobuf-java-wso2</artifactId> >>>>> <version>2.5.0-spark.wso2v1</version> >>>>> >>>>> when I put that as a bundle-def, carbon p2 plugin picks both the jars. >>>>> >>>>> so I see a few solutions here. >>>>> 1. having a separate orbit bundle as above >>>>> 2. make this jar (org.spark-project.protobuf:protobuf-java) a private >>>>> package in the spark core orbit bundle, since it is only used for spark >>>>> 3. make the other jar (com.google.protobuf:protobuf-java) a provaet >>>>> package in the mesos bundle, since it is only used for mesos >>>>> >>>>> please advise me on this. >>>>> >>>>> thanks >>>>> >>>>> On Mon, Mar 16, 2015 at 3:50 PM, Niranda Perera <nira...@wso2.com> >>>>> wrote: >>>>> >>>>>> Hi Sameera, >>>>>> >>>>>> the versions are 2.5.0-spark for org.spark-project. >>>>>> protobuf:protobuf-java and 2.5.0 for com.google. >>>>>> protobuf:protobuf-java >>>>>> >>>>>> is there a workaround to include both these jars in the feature.xml? >>>>>> >>>>>> rgds >>>>>> >>>>>> On Mon, Mar 16, 2015 at 3:33 PM, Sameera Jayasoma <same...@wso2.com> >>>>>> wrote: >>>>>> >>>>>>> Carbon-p2-plugin simply invoke Equinox P2 APIs to generate features? >>>>>>> You can simply scan through the P2 plugin code and see. >>>>>>> >>>>>>> As per our offline chat, versions of these two jars are also very >>>>>>> similar. That may be a problem >>>>>>> >>>>>>> https://github.com/wso2/maven-tools >>>>>>> >>>>>>> On Mon, Mar 16, 2015 at 9:58 AM, Niranda Perera <nira...@wso2.com> >>>>>>> wrote: >>>>>>> >>>>>>>> Hi all, >>>>>>>> >>>>>>>> I have come across an issue in carbon P2 plugin while creating a >>>>>>>> feature. Please consider the following scenario. [1] >>>>>>>> >>>>>>>> I need 2 jars to be bundled with the feature, from 2 different >>>>>>>> packages BUT with the same artifact ID. Please see the highlighted >>>>>>>> text. >>>>>>>> >>>>>>>> <plugin> >>>>>>>> <groupId>org.wso2.maven</groupId> >>>>>>>> <artifactId>carbon-p2-plugin</artifactId> >>>>>>>> <executions> >>>>>>>> <execution> >>>>>>>> <id>4-p2-feature-generation</id> >>>>>>>> <phase>package</phase> >>>>>>>> <goals> >>>>>>>> <goal>p2-feature-gen</goal> >>>>>>>> </goals> >>>>>>>> <configuration> >>>>>>>> >>>>>>>> <id>org.wso2.carbon.analytics.spark.server</id> >>>>>>>> >>>>>>>> <propertiesFile>../../../../etc/feature.properties</propertiesFile> >>>>>>>> <adviceFile> >>>>>>>> <properties> >>>>>>>> >>>>>>>> <propertyDef>org.wso2.carbon.p2.category.type:server >>>>>>>> </propertyDef> >>>>>>>> >>>>>>>> <propertyDef>org.eclipse.equinox.p2.type.group:false >>>>>>>> </propertyDef> >>>>>>>> </properties> >>>>>>>> </adviceFile> >>>>>>>> <bundles> >>>>>>>> >>>>>>>> <bundleDef>org.wso2.carbon.analytics:org.wso2.carbon.analytics.spark.core</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.wso2.carbon.analytics:org.wso2.carbon.analytics.spark.admin</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.wso2.carbon.analytics:org.wso2.carbon.analytics.spark.utils</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.wso2.apache.spark:spark-core_2.10</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.wso2.apache.spark:spark-sql_2.10</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.apache.commons:commons-lang3</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.apache.commons:commons-math3</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.scala-lang:scala-library</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.scala-lang:scala-reflect</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>com.codahale.metrics:metrics-json</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>com.codahale.metrics:metrics-jvm</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>com.codahale.metrics:metrics-core</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>com.codahale.metrics:metrics-graphite</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>com.fasterxml.jackson.core:jackson-databind</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>com.fasterxml.jackson.core:jackson-core</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>com.fasterxml.jackson.core:jackson-annotations</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>com.esotericsoftware.kryo:kryo</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.xerial.snappy:snappy-java</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>io.netty.wso2:netty-all</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>javax.servlet.jsp:javax.servlet.jsp-api</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.apache.tomcat.wso2:tomcat-servlet-api</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.wso2.apache.hadoop:hadoop-client</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.wso2.json4s:json4s-jackson_2.10</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.eclipse.jetty:jetty-continuation</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.eclipse.jetty:jetty-http</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.eclipse.jetty:jetty-io</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.eclipse.jetty:jetty-jndi</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.eclipse.jetty:jetty-security</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.eclipse.jetty:jetty-server</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.eclipse.jetty:jetty-servlet</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.eclipse.jetty:jetty-util</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.eclipse.jetty:jetty-webapp</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.eclipse.jetty:jetty-xml</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>io.netty:netty</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.spark-project.protobuf:protobuf-java</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>com.google.protobuf:protobuf-java</bundleDef> >>>>>>>> >>>>>>>> >>>>>>>> <bundleDef>org.wso2.uncommons.maths:uncommons-maths</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>com.ning:compress-lzf</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>com.google.guava:guava</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.slf4j:slf4j-api</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.slf4j:slf4j-log4j12</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.wso2.twitter:chill_2.10</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.wso2.clearspring.analytics:stream</bundleDef> >>>>>>>> >>>>>>>> <bundleDef>org.wso2.orbit.org.apache.mesos:mesos</bundleDef> >>>>>>>> >>>>>>>> </bundles> >>>>>>>> <importFeatures> >>>>>>>> >>>>>>>> <importFeatureDef>org.wso2.carbon.core:${carbon.kernel.version} >>>>>>>> </importFeatureDef> >>>>>>>> </importFeatures> >>>>>>>> </configuration> >>>>>>>> </execution> >>>>>>>> </executions> >>>>>>>> </plugin> >>>>>>>> >>>>>>>> After building the feature, I found the relevant jars in the >>>>>>>> feature's plugins folder. BUT when I put the feature inside the >>>>>>>> product, >>>>>>>> only the 2nd jar (com.google.protobuf:protobuf-java) is copied to >>>>>>>> the product's plugins folder. >>>>>>>> further looking into the problem, I found out that feature's >>>>>>>> feature.xml file does not contain the 1st jar ( >>>>>>>> org.spark-project.protobuf:protobuf-java), which I think explains >>>>>>>> why it was not copied to the product's plugins folder. >>>>>>>> >>>>>>>> Is this a known issue? does the carbon p2 plugin omits such >>>>>>>> packages when it is creating the feature.xml file? >>>>>>>> >>>>>>>> look forward for your assistance in this regard. >>>>>>>> >>>>>>>> cheers >>>>>>>> >>>>>>>> [1] >>>>>>>> https://github.com/wso2/carbon-analytics/blob/master/features/analytics/analytics-processors/org.wso2.carbon.analytics.spark.server.feature/pom.xml >>>>>>>> >>>>>>>> -- >>>>>>>> *Niranda Perera* >>>>>>>> Software Engineer, WSO2 Inc. >>>>>>>> Mobile: +94-71-554-8430 >>>>>>>> Twitter: @n1r44 <https://twitter.com/N1R44> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Sameera Jayasoma, >>>>>>> Software Architect, >>>>>>> >>>>>>> WSO2, Inc. (http://wso2.com) >>>>>>> email: same...@wso2.com >>>>>>> blog: http://blog.sameera.org >>>>>>> twitter: https://twitter.com/sameerajayasoma >>>>>>> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections >>>>>>> Mobile: 0094776364456 >>>>>>> >>>>>>> Lean . Enterprise . Middleware >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Niranda Perera* >>>>>> Software Engineer, WSO2 Inc. >>>>>> Mobile: +94-71-554-8430 >>>>>> Twitter: @n1r44 <https://twitter.com/N1R44> >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> *Niranda Perera* >>>>> Software Engineer, WSO2 Inc. >>>>> Mobile: +94-71-554-8430 >>>>> Twitter: @n1r44 <https://twitter.com/N1R44> >>>>> >>>> >>>> >>>> >>>> -- >>>> *Niranda Perera* >>>> Software Engineer, WSO2 Inc. >>>> Mobile: +94-71-554-8430 >>>> Twitter: @n1r44 <https://twitter.com/N1R44> >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> Dev@wso2.org >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> *Supun Sethunga* >>> Software Engineer >>> WSO2, Inc. >>> http://wso2.com/ >>> lean | enterprise | middleware >>> Mobile : +94 716546324 >>> >>> _______________________________________________ >>> Dev mailing list >>> Dev@wso2.org >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> >> *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. >> email: kasung AT spamfree wso2.com >> linked-in: http://lk.linkedin.com/in/gajasinghe >> blog: http://kasunbg.org >> >> >> > > > > -- > *Niranda Perera* > Software Engineer, WSO2 Inc. > Mobile: +94-71-554-8430 > Twitter: @n1r44 <https://twitter.com/N1R44> > -- *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. email: kasung AT spamfree wso2.com linked-in: http://lk.linkedin.com/in/gajasinghe blog: http://kasunbg.org
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
