On Tue, Apr 21, 2015 at 2:06 PM, Thilini Anoratna <thili...@wso2.com> wrote:
> Hi all, > > Please find review notes below. > > 1.When including Siddhi queries in test cases, try to make the code more > readable by including query statements in new lines. > > Eg: > from StockExchangeStream[volume<10] > select symbol,volume > insert into StockQuoteStream > > 2.Fix the iteration issues on the callbacks. > 3.Optimize the code to avoid repetition. > 4.No need to log when an exception is caught and thrown. It should be > logged in the level where it is solved. > > Make sure to make the variables private. Move the DateFormatter to instance variable and reuse that when ever possible. Suho > > Thank you. > > On Mon, Apr 20, 2015 at 10:04 AM, dami...@wso2.com <dami...@wso2.com> > wrote: > >> This event has been changed. >> more details » >> <https://www.google.com/calendar/event?action=VIEW&eid=Mm5oamcybGVocXJsajY3ZmoxbmdjMWczczQgZGV2QHdzbzIub3Jn&tok=MTYjZGFtaXRobkB3c28yLmNvbTdhZDAyNTAzNjRhMjZiNWEwODlhOTgyMTNiZTkxMjJhM2Y5OTE0NTY&ctz=Asia/Colombo&hl=en> >> Code Review - Siddhi Time Function Extension >> *When* >> *Changed: *Tue Apr 21, 2015 12pm – 1pm Colombo >> *Where* >> LK Trace Mezzanine Floor Meeting Room - Gondor Ext:1036212 (map >> <https://maps.google.lk/maps?q=LK+Trace+Mezzanine+Floor+Meeting+Room+-+Gondor+Ext:1036212&hl=en> >> ) >> *Video call* >> https://plus.google.com/hangouts/_/wso2.com/code-review >> <https://plus.google.com/hangouts/_/wso2.com/code-review?hceid=ZGFtaXRobkB3c28yLmNvbQ.2nhjg2lehqrlj67fj1ngc1g3s4> >> *Calendar* >> dami...@wso2.com >> *Who* >> • >> Damith Wickramasinghe - organizer >> • >> Ramindu De Silva >> • >> Sachini Jayasekara >> • >> Mohanadarshan Vivekanandalingam >> • >> Sriskandarajah Suhothayan >> • >> Tharik Kanaka >> • >> dev@wso2.org >> • >> Dilini Muthumala >> • >> Lasantha Fernando >> • >> Rajeev Sampath >> >> Going? *Yes >> <https://www.google.com/calendar/event?action=RESPOND&eid=Mm5oamcybGVocXJsajY3ZmoxbmdjMWczczQgZGV2QHdzbzIub3Jn&rst=1&tok=MTYjZGFtaXRobkB3c28yLmNvbTdhZDAyNTAzNjRhMjZiNWEwODlhOTgyMTNiZTkxMjJhM2Y5OTE0NTY&ctz=Asia/Colombo&hl=en> >> - Maybe >> <https://www.google.com/calendar/event?action=RESPOND&eid=Mm5oamcybGVocXJsajY3ZmoxbmdjMWczczQgZGV2QHdzbzIub3Jn&rst=3&tok=MTYjZGFtaXRobkB3c28yLmNvbTdhZDAyNTAzNjRhMjZiNWEwODlhOTgyMTNiZTkxMjJhM2Y5OTE0NTY&ctz=Asia/Colombo&hl=en> >> - No >> <https://www.google.com/calendar/event?action=RESPOND&eid=Mm5oamcybGVocXJsajY3ZmoxbmdjMWczczQgZGV2QHdzbzIub3Jn&rst=2&tok=MTYjZGFtaXRobkB3c28yLmNvbTdhZDAyNTAzNjRhMjZiNWEwODlhOTgyMTNiZTkxMjJhM2Y5OTE0NTY&ctz=Asia/Colombo&hl=en>* >> more options » >> <https://www.google.com/calendar/event?action=VIEW&eid=Mm5oamcybGVocXJsajY3ZmoxbmdjMWczczQgZGV2QHdzbzIub3Jn&tok=MTYjZGFtaXRobkB3c28yLmNvbTdhZDAyNTAzNjRhMjZiNWEwODlhOTgyMTNiZTkxMjJhM2Y5OTE0NTY&ctz=Asia/Colombo&hl=en> >> >> Invitation from Google Calendar <https://www.google.com/calendar/> >> >> You are receiving this courtesy email at the account dev@wso2.org >> because you are an attendee of this event. >> >> To stop receiving future updates for this event, decline this event. >> Alternatively you can sign up for a Google account at >> https://www.google.com/calendar/ and control your notification settings >> for your entire calendar. >> >> _______________________________________________ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > > *Thilini Anoratna* > Software Engineer > WSO2 Inc.; http://wso2.com > lean.enterprise.middleware > > mobile: +94 778955654 <+94+778955654> > > * <http://lk.linkedin.com/in/thilinianoratna>* > > -- *S. Suhothayan* Technical Lead & Team Lead of WSO2 Complex Event Processor *WSO2 Inc. *http://wso2.com * <http://wso2.com/>* lean . enterprise . middleware *cell: (+94) 779 756 757 | blog: http://suhothayan.blogspot.com/ <http://suhothayan.blogspot.com/>twitter: http://twitter.com/suhothayan <http://twitter.com/suhothayan> | linked-in: http://lk.linkedin.com/in/suhothayan <http://lk.linkedin.com/in/suhothayan>*
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
