Hi Supun,
let me understand the scenario here.
say there are 2 OSGI bundle in the environment spark v 1.3.0 and spark v
1.2.1 and we have a component org.wso2.analytics.spark.core which imports
org.apache.spark version [1.2.1, 1.4.0).
then AFAIK in the OSGI environment, org.wso2.analytics.spark.core gets
wired to the latest version in the runtime.
@carbon team pls correct me if I'm wrong
but I do not think it has anything to do with the <Export-Package> tag in
the orbit bundle.
rgds
On Wed, Apr 29, 2015 at 10:22 AM, Supun Sethunga <sup...@wso2.com> wrote:
> Hi Niranda,
>
> are you referring to this?
>> <Export-Package>
>> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
>> </Export-Package>
>
>
> Yes exactly. My concern was, what if multiple versions of the same package
> were in the same osgi environment.. I know its very highly unlikely, but
> IF such a case happens, then I think spark (or any bundle) will pick up
> only one of the versions.
>
> Thanks,
> Supun
>
> On Mon, Apr 27, 2015 at 10:55 AM, Niranda Perera <nira...@wso2.com> wrote:
>
>> Hi Supun,
>>
>> are you referring to this?
>> <Export-Package>
>> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
>> </Export-Package>
>>
>> well, AFAIK what export-package does is, it exposes the
>> org.apache.spark.* classes in the OSGI environment. since we are not doing
>> any patching for the original classes, I dont think we have to change the
>> version to 1.3.0.wso2v1
>>
>> @sameera, pls correct me if I'm wrong.
>>
>> rgds
>>
>> On Wed, Apr 22, 2015 at 9:06 AM, Supun Sethunga <sup...@wso2.com> wrote:
>>
>>> Hi Sameera/Niranda,
>>>
>>> With parallel to this, Im in the process of migrating the spark Ml-Lib
>>> and spark streaming versions for product ML. Just wanted to clear myself,
>>> shouldn't the export-package-version of all spark packages be 1.3.0.wso2v1,
>>> rather than 1.3.0?
>>>
>>> Thanks,
>>> Supun
>>>
>>> On Fri, Apr 17, 2015 at 4:39 PM, Niranda Perera <nira...@wso2.com>
>>> wrote:
>>>
>>>> oh. are you referring to the
>>>> <Bundle-Classpath>patch.jar,.</Bundle-Classpath>
>>>> line?
>>>> I did not include it in the orbit bundle.
>>>>
>>>> but I checked the bundles in a fresh carbon server and it seems like
>>>> the patch gets attached successfully.
>>>>
>>>> Screenshot from 2015-04-17 16:20:15.png
>>>> <https://docs.google.com/a/wso2.com/file/d/0B1GsnfycTl32bDMyNG5DMDhRcHc/edit?usp=drive_web>
>>>>
>>>> I checked it with BAM pack also.
>>>>
>>>> <bundle-classpath> tag, is it mandatory to be in the for the orbit
>>>> bundle, for the patch to get attached?
>>>>
>>>> the patch pom is as follows
>>>>
>>>> https://github.com/nirandaperera/carbon-analytics/blob/clustering%2B130%2BMT/components/analytics/analytics-processors/org.wso2.carbon.analytics.spark.patch/pom.xml
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Thu, Apr 16, 2015 at 3:05 PM, Anjana Fernando <anj...@wso2.com>
>>>> wrote:
>>>>
>>>>> Niranda, yeah, we would have to put that part to be able to later
>>>>> patch it. A sample can be found here [1].
>>>>>
>>>>> [1]
>>>>> https://github.com/wso2/orbit/blob/master/tomcat/7.0.59.wso2v2/pom.xml
>>>>>
>>>>> Cheers,
>>>>> Anjana.
>>>>>
>>>>> On Thu, Apr 16, 2015 at 3:00 PM, Sameera Jayasoma <same...@wso2.com>
>>>>> wrote:
>>>>>
>>>>>> I meant to say, do we need to add the patch.jar line to the spark
>>>>>> bundle as we've done in Tomcat bundle.
>>>>>>
>>>>>> Thanks,
>>>>>> Sameera.
>>>>>>
>>>>>> On Thu, Apr 16, 2015 at 12:31 PM, Niranda Perera <nira...@wso2.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi Sameera,
>>>>>>>
>>>>>>> No its not. The patch is in org.wso2.analytics.spark.patch
>>>>>>> component. Its still not committed to carbon - analytics
>>>>>>>
>>>>>>> Rgds
>>>>>>>
>>>>>>> On Thu, Apr 16, 2015, 12:17 Sameera Jayasoma <same...@wso2.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Hi Niranda,
>>>>>>>>
>>>>>>>> Does this include fragment-bundle/patch modification also?
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Sameera.
>>>>>>>>
>>>>>>>> On Thu, Apr 16, 2015 at 8:03 AM, Niranda Perera <nira...@wso2.com>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> Kind reminder on this.
>>>>>>>>>
>>>>>>>>> Best regards
>>>>>>>>>
>>>>>>>>> Niranda Perera
>>>>>>>>> Software Engineer, WSO2 Inc.
>>>>>>>>> Mobile: +94-71-554-8430
>>>>>>>>> Twitter: @n1r44
>>>>>>>>> On Apr 14, 2015 19:17, "Niranda Perera" <nira...@wso2.com> wrote:
>>>>>>>>>
>>>>>>>>>> Hi Sameera,
>>>>>>>>>>
>>>>>>>>>> Could you please review this PR [1] for Spark 1.3.0.
>>>>>>>>>>
>>>>>>>>>> this upgrades 1.2.1 to 1.3.0. this upgrade is done, because 1.3.0
>>>>>>>>>> comes with some major API changes and we wanted to include those API
>>>>>>>>>> changes before the DAS (BAM) 3.0.0 alpha
>>>>>>>>>>
>>>>>>>>>> cheers
>>>>>>>>>>
>>>>>>>>>> [1] https://github.com/wso2/orbit/pull/83
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> *Niranda Perera*
>>>>>>>>>> Software Engineer, WSO2 Inc.
>>>>>>>>>> Mobile: +94-71-554-8430
>>>>>>>>>> Twitter: @n1r44 <https://twitter.com/N1R44>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Sameera Jayasoma,
>>>>>>>> Software Architect,
>>>>>>>>
>>>>>>>> WSO2, Inc. (http://wso2.com)
>>>>>>>> email: same...@wso2.com
>>>>>>>> blog: http://blog.sameera.org
>>>>>>>> twitter: https://twitter.com/sameerajayasoma
>>>>>>>> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
>>>>>>>> Mobile: 0094776364456
>>>>>>>>
>>>>>>>> Lean . Enterprise . Middleware
>>>>>>>>
>>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Sameera Jayasoma,
>>>>>> Software Architect,
>>>>>>
>>>>>> WSO2, Inc. (http://wso2.com)
>>>>>> email: same...@wso2.com
>>>>>> blog: http://blog.sameera.org
>>>>>> twitter: https://twitter.com/sameerajayasoma
>>>>>> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
>>>>>> Mobile: 0094776364456
>>>>>>
>>>>>> Lean . Enterprise . Middleware
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Anjana Fernando*
>>>>> Senior Technical Lead
>>>>> WSO2 Inc. | http://wso2.com
>>>>> lean . enterprise . middleware
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> *Niranda Perera*
>>>> Software Engineer, WSO2 Inc.
>>>> Mobile: +94-71-554-8430
>>>> Twitter: @n1r44 <https://twitter.com/N1R44>
>>>>
>>>> _______________________________________________
>>>> Dev mailing list
>>>> Dev@wso2.org
>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>>
>>>>
>>>
>>>
>>> --
>>> *Supun Sethunga*
>>> Software Engineer
>>> WSO2, Inc.
>>> http://wso2.com/
>>> lean | enterprise | middleware
>>> Mobile : +94 716546324
>>>
>>
>>
>>
>> --
>> *Niranda Perera*
>> Software Engineer, WSO2 Inc.
>> Mobile: +94-71-554-8430
>> Twitter: @n1r44 <https://twitter.com/N1R44>
>>
>
>
>
> --
> *Supun Sethunga*
> Software Engineer
> WSO2, Inc.
> http://wso2.com/
> lean | enterprise | middleware
> Mobile : +94 716546324
>
--
*Niranda Perera*
Software Engineer, WSO2 Inc.
Mobile: +94-71-554-8430
Twitter: @n1r44 <https://twitter.com/N1R44>
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev
