Hi Lasitha, I think the fix has some issues. The method you have changed is an Util method. The same method is invoked from various other places.
If one of those places currently sends tenant aware username as expected with your change it again extracts tenant aware username for the second time. This will be an issue if we have enable EmailUserName in the system. E.g. "joh...@gmail.com@wso2.com" would become just "johann" where as tenant aware username should be "joh...@gmail.com". E.g. check the "unlockUserAccount()" of "UserIdentityManagementAdminService". This is a Admin service which sends the tenant aware username. In this flow also the method you changed gets executed and as I saw tenant aware username is being called at least twice on the username that is passed in. You may need to go through all the service operations in this component and test to make sure everything is working as expected for super tenant and tenants, primary and secondary user stores and email and non email usernames. Thanks, Johann. On Mon, Apr 20, 2015 at 7:41 PM, Lasitha Wattaladeniya <lasit...@wso2.com> wrote: > Hi, > > This is the fix [1] for the Jira [2]. > > > [1]. https://github.com/wso2/carbon-identity/pull/205 > [2]. https://wso2.org/jira/browse/IDENTITY-3204 > > -- > Lasitha Wattaladeniya > Software Engineer > WSO2, Inc. | http://wso2.com > lean. enterprise. middleware > > Mobile : +94719397528 > Blog : techreadme.blogspot.com > -- Thanks & Regards, *Johann Dilantha Nallathamby* Technical Lead & Product Lead of WSO2 Identity Server Integration Technologies Team WSO2, Inc. lean.enterprise.middleware Mobile - *+94777776950* Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>*
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
