"Block" is un-clickable in API Publisher when a subscription is in ON_HOLD state. So the subscription is only allowed to be blocked if approved by the admin-workflow. If rejected it'll be disappeared from the publisher.
Kasun Gunasekara Software Engineering Intern - WSO2 Mobile : +94 77 6986482 Twitter <https://twitter.com/KaluMallii> | Google+ <https://plus.google.com/+KaZGunasekara/> | LinkedIn <http://www.linkedin.com/in/kasun32> On Tue, May 19, 2015 at 12:14 PM, Abimaran Kugathasan <abima...@wso2.com> wrote: > OK, What if ON_HOLD subscription was blocked through API Publisher before > it get approved via admin-workflow? Even it's blocked, I guess, admin can > approve or reject the subscription. That will be the staus of the > subscription. > > Depends on the order of execution whether admin-workflow or API publisher > blocking runs first, previous status will be overridn by the other. So, > there won't be a consistent state. > > It's OK to show ON_HOLD subscription, but, admin sholdn't be able to block > until the subscription approved/rejected via admin-workflow. > > > > On Tue, May 19, 2015 at 11:21 AM, Kasun Gunasekara <kas...@wso2.com> > wrote: > >> Hi Abimaran, >> >> I noticed that earlier. But ON_HOLD status is already handled in API >> Publisher using a tip saying that the subscription is pending for approval. >> Does it still has to be removed? If yes I will do the necessary changes. >> >> >> Kasun Gunasekara >> Software Engineering Intern - WSO2 >> Mobile : +94 77 6986482 >> Twitter <https://twitter.com/KaluMallii> | Google+ >> <https://plus.google.com/+KaZGunasekara/> | LinkedIn >> <http://www.linkedin.com/in/kasun32> >> >> On Tue, May 19, 2015 at 11:17 AM, Abimaran Kugathasan <abima...@wso2.com> >> wrote: >> >>> Hi Kasun, >>> >>> Following are status' of API subscription >>> >>> public static class SubscriptionStatus { >>> public static final String BLOCKED = "BLOCKED"; >>> public static final String PROD_ONLY_BLOCKED = "PROD_ONLY_BLOCKED"; >>> public static final String UNBLOCKED = "UNBLOCKED"; >>> public static final String ON_HOLD = "ON_HOLD"; >>> public static final String REJECTED = "REJECTED"; >>> } >>> >>> >>> Only subscription with BLOCKED, PROD_ONLY_BLOCKED, UNBLOCKED status >>> should be listed in subscription tab of the API Publisher. REJECTED, >>> ON_HOLD staus cann't be considered as successfull subscriptions. >>> >>> Can you please filer ON_HOLD status also here with addition to REJECTED? >>> >>> I'm reopning the bug. >>> >>> >>> On Fri, May 15, 2015 at 4:41 PM, Kasun Gunasekara <kas...@wso2.com> >>> wrote: >>> >>>> Hi Abimaran, >>>> >>>> I had some misunderstanding about the issue and the earlier PR was for >>>> the API Store. Did revert the earlier commit and updated the PR with >>>> relevant changes to the API Publisher. >>>> >>>> Please review and merge PR[1] >>>> >>>> [1] https://github.com/wso2/carbon-apimgt/pull/383 >>>> >>>> >>>> >>>> Kasun Gunasekara >>>> Software Engineering Intern - WSO2 >>>> Mobile : +94 77 6986482 >>>> Twitter <https://twitter.com/KaluMallii> | Google+ >>>> <https://plus.google.com/+KaZGunasekara/> | LinkedIn >>>> <http://www.linkedin.com/in/kasun32> >>>> >>>> On Fri, May 15, 2015 at 2:38 PM, Abimaran Kugathasan <abima...@wso2.com >>>> > wrote: >>>> >>>>> Hi Kasun, >>>>> >>>>> What is the status of this issue? >>>>> >>>>> On Wed, May 13, 2015 at 4:55 PM, Kasun Gunasekara <kas...@wso2.com> >>>>> wrote: >>>>> >>>>>> Hi Abimaran, >>>>>> >>>>>> I checked on this and found out that API Provider's Subscriptions >>>>>> page uses getAllAPIUsageByProvider() to load subscriptions and I have >>>>>> only >>>>>> changed getPaginatedSubscribedAPIs() which is used by API Store. >>>>>> >>>>>> This change doesn't affect API Provider as far as I understand. >>>>>> >>>>>> >>>>>> Kasun Gunasekara >>>>>> Software Engineering Intern - WSO2 >>>>>> Mobile : +94 77 6986482 >>>>>> Twitter <https://twitter.com/KaluMallii> | Google+ >>>>>> <https://plus.google.com/+KaZGunasekara/> | LinkedIn >>>>>> <http://www.linkedin.com/in/kasun32> >>>>>> >>>>>> On Wed, May 13, 2015 at 2:52 PM, Abimaran Kugathasan < >>>>>> abima...@wso2.com> wrote: >>>>>> >>>>>>> Hi Kasun, >>>>>>> >>>>>>> In the Subscription page of the API Publisher, We have to show, >>>>>>> BLOCKED, UNBLOCKED API Subscription. But, with this pull request, you >>>>>>> made >>>>>>> changes to list on the UNBLOCKED API Subscription. >>>>>>> >>>>>>> It we don't show the BLOCKED API Subscription, we won't be able to >>>>>>> unblock them through the publisher. >>>>>>> >>>>>>> On Wed, May 13, 2015 at 2:47 PM, Kasun Gunasekara <kas...@wso2.com> >>>>>>> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> Please review and merge PR [1] for jira [2]. >>>>>>>> >>>>>>>> [1] https://github.com/wso2/carbon-apimgt/pull/383 >>>>>>>> [2] https://wso2.org/jira/browse/APIMANAGER-3550 >>>>>>>> >>>>>>>> Regards. >>>>>>>> >>>>>>>> Kasun Gunasekara >>>>>>>> Software Engineering Intern - WSO2 >>>>>>>> Mobile : +94 77 6986482 >>>>>>>> Twitter <https://twitter.com/KaluMallii> | Google+ >>>>>>>> <https://plus.google.com/+KaZGunasekara/> | LinkedIn >>>>>>>> <http://www.linkedin.com/in/kasun32> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Thanks >>>>>>> Abimaran Kugathasan >>>>>>> >>>>>>> Software Engineer | WSO2 Inc >>>>>>> Data & APIs Technologies Team >>>>>>> Mobile : +94 773922820 >>>>>>> >>>>>>> <http://stackoverflow.com/users/515034> >>>>>>> <http://lk.linkedin.com/in/abimaran> >>>>>>> <http://www.lkabimaran.blogspot.com/> >>>>>>> <https://github.com/abimarank> <https://twitter.com/abimaran> >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks >>>>> Abimaran Kugathasan >>>>> >>>>> Software Engineer | WSO2 Inc >>>>> Data & APIs Technologies Team >>>>> Mobile : +94 773922820 >>>>> >>>>> <http://stackoverflow.com/users/515034> >>>>> <http://lk.linkedin.com/in/abimaran> >>>>> <http://www.lkabimaran.blogspot.com/> <https://github.com/abimarank> >>>>> <https://twitter.com/abimaran> >>>>> >>>>> >>>> >>> >>> >>> -- >>> Thanks >>> Abimaran Kugathasan >>> >>> Software Engineer | WSO2 Inc >>> Data & APIs Technologies Team >>> Mobile : +94 773922820 >>> >>> <http://stackoverflow.com/users/515034> >>> <http://lk.linkedin.com/in/abimaran> >>> <http://www.lkabimaran.blogspot.com/> <https://github.com/abimarank> >>> <https://twitter.com/abimaran> >>> >>> >> > > > -- > Thanks > Abimaran Kugathasan > > Software Engineer | WSO2 Inc > Data & APIs Technologies Team > Mobile : +94 773922820 > > <http://stackoverflow.com/users/515034> > <http://lk.linkedin.com/in/abimaran> > <http://www.lkabimaran.blogspot.com/> <https://github.com/abimarank> > <https://twitter.com/abimaran> > >
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
