Hi Niranjan, Thanks for guiding me to do this in correct way. Please find the created JIRA [1] for this issue and the pull request to master in git hub also [2]. I have written integration tests in dss 3.2.2. will send a pull request with integration tests to the kernel.
[1] https://wso2.org/jira/browse/CARBON-15261 [2] https://github.com/wso2/wso2-axis2/pull/51 Thanks, Madhawa On Mon, Jun 8, 2015 at 11:40 AM, Niranjan Karunanandham <[email protected]> wrote: > Hi Madhawa, > > I had an offline chat with KasunG with regard to where this issue should > be in the JIRA. He suggested to created a public JIRA in Carbon (to upload > the patch and pull requests) and in the DSS JIRA [1] refer to the Carbon > JIRA. > > In a related note, please send the the pull request to master in Github > also [2]. > > [1] - https://wso2.org/jira/browse/DS-1053 > [2] - https://github.com/wso2/wso2-axis2/ > > Regards, > Nira > > On Mon, Jun 8, 2015 at 10:02 AM, Niranjan Karunanandham <[email protected] > > wrote: > >> Hi Madhawa, >> >> Previously when there was an issue in axis2 json (GSON) for DSS usecase, >> a public JIRA was opened in CARBON [1] and mentioned that this was DSS. >> This will be easy to track and merge requests by the team. Since this is a >> change to AbstractJSONMessageFormatter (axis2), (Please correct me if am >> wrong) shouldn't the JIRA be in CARBON. >> >> [1] - https://wso2.org/jira/browse/CARBON-15203 >> >> Regards, >> Nira >> >> On Mon, Jun 8, 2015 at 9:14 AM, Niranjan Karunanandham <[email protected] >> > wrote: >> >>> Hi all, >>> >>> I will look into this. >>> >>> Regards, >>> Nira >>> >>> On Mon, Jun 8, 2015 at 8:21 AM, Madhawa Gunasekara <[email protected]> >>> wrote: >>> >>>> Hi All, >>>> >>>> Please apply this patch, I just wanted to wait till I write the test >>>> case for this patch. All are fine. >>>> >>>> Thanks, >>>> Madhawa >>>> >>>> On Fri, Jun 5, 2015 at 7:29 PM, Madhawa Gunasekara <[email protected]> >>>> wrote: >>>> >>>>> Please ignore the patch >>>>> >>>>> Thanks, >>>>> Madhawa >>>>> >>>>> On Fri, Jun 5, 2015 at 6:15 PM, Madhawa Gunasekara <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi Devs, >>>>>> >>>>>> Please find the attached patch for the fix [1]. >>>>>> >>>>>> [1] https://wso2.org/jira/browse/DS-1053 >>>>>> >>>>>> -- >>>>>> *Madhawa Gunasekara* >>>>>> Software Engineer >>>>>> WSO2 Inc.; http://wso2.com >>>>>> lean.enterprise.middleware >>>>>> >>>>>> mobile: +94 719411002 <+94+719411002> >>>>>> blog: *http://madhawa-gunasekara.blogspot.com >>>>>> <http://madhawa-gunasekara.blogspot.com>* >>>>>> linkedin: *http://lk.linkedin.com/in/mgunasekara >>>>>> <http://lk.linkedin.com/in/mgunasekara>* >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> *Madhawa Gunasekara* >>>>> Software Engineer >>>>> WSO2 Inc.; http://wso2.com >>>>> lean.enterprise.middleware >>>>> >>>>> mobile: +94 719411002 <+94+719411002> >>>>> blog: *http://madhawa-gunasekara.blogspot.com >>>>> <http://madhawa-gunasekara.blogspot.com>* >>>>> linkedin: *http://lk.linkedin.com/in/mgunasekara >>>>> <http://lk.linkedin.com/in/mgunasekara>* >>>>> >>>> >>>> >>>> >>>> -- >>>> *Madhawa Gunasekara* >>>> Software Engineer >>>> WSO2 Inc.; http://wso2.com >>>> lean.enterprise.middleware >>>> >>>> mobile: +94 719411002 <+94+719411002> >>>> blog: *http://madhawa-gunasekara.blogspot.com >>>> <http://madhawa-gunasekara.blogspot.com>* >>>> linkedin: *http://lk.linkedin.com/in/mgunasekara >>>> <http://lk.linkedin.com/in/mgunasekara>* >>>> >>> >>> >>> >>> -- >>> >>> *Niranjan Karunanandham* >>> Senior Software Engineer - WSO2 Inc. >>> WSO2 Inc.: http://www.wso2.com >>> >> >> >> >> -- >> >> *Niranjan Karunanandham* >> Senior Software Engineer - WSO2 Inc. >> WSO2 Inc.: http://www.wso2.com >> > > > > -- > > *Niranjan Karunanandham* > Senior Software Engineer - WSO2 Inc. > WSO2 Inc.: http://www.wso2.com > -- *Madhawa Gunasekara* Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: +94 719411002 <+94+719411002> blog: *http://madhawa-gunasekara.blogspot.com <http://madhawa-gunasekara.blogspot.com>* linkedin: *http://lk.linkedin.com/in/mgunasekara <http://lk.linkedin.com/in/mgunasekara>*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
