Have you tested the other inbound type after the change? On Mon, Jul 20, 2015 at 10:50 AM, Shakila Sivagnanarajah <shak...@wso2.com> wrote:
> Hi Malaka, > > I have modified the code according to your comment. Please find the PR [1]. > [1] https://github.com/wso2/carbon-mediation/pull/294 > > Thank you > > On Fri, Jul 17, 2015 at 5:21 PM, Malaka Silva <mal...@wso2.com> wrote: > >> Hi Shakila, >> >> Added some comments. >> >> Did you check other inbound protocols with this change? >> >> Don't we need to apply the same for update page as well? >> >> On Fri, Jul 17, 2015 at 4:55 PM, Shakila Sivagnanarajah <shak...@wso2.com >> > wrote: >> >>> Hi Malaka, >>> >>> Please review and merge PR[1] for $subject. >>> >>> [1] https://github.com/wso2/carbon-mediation/pull/294 >>> >>> >>> Thank you >>> -- >>> Shakila Sivagnanarajah >>> Associate Software Engineer >>> Mobile :+94 (0) 770 760240 >>> shak...@wso2.com >>> >> >> >> >> -- >> >> Best Regards, >> >> Malaka Silva >> Senior Tech Lead >> M: +94 777 219 791 >> Tel : 94 11 214 5345 >> Fax :94 11 2145300 >> Skype : malaka.sampath.silva >> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 >> Blog : http://mrmalakasilva.blogspot.com/ >> >> WSO2, Inc. >> lean . enterprise . middleware >> http://www.wso2.com/ >> http://www.wso2.com/about/team/malaka-silva/ >> <http://wso2.com/about/team/malaka-silva/> >> >> Save a tree -Conserve nature & Save the world for your future. Print this >> email only if it is absolutely necessary. >> > > > > -- > Shakila Sivagnanarajah > Associate Software Engineer > Mobile :+94 (0) 770 760240 > shak...@wso2.com > -- Best Regards, Malaka Silva Senior Tech Lead M: +94 777 219 791 Tel : 94 11 214 5345 Fax :94 11 2145300 Skype : malaka.sampath.silva LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 Blog : http://mrmalakasilva.blogspot.com/ WSO2, Inc. lean . enterprise . middleware http://www.wso2.com/ http://www.wso2.com/about/team/malaka-silva/ <http://wso2.com/about/team/malaka-silva/> Save a tree -Conserve nature & Save the world for your future. Print this email only if it is absolutely necessary.
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
