Hi All, Please refer following code review feedbacks.
- Verify that XML parsing/JSON parsing is not needed for event publishing - Change implementation to build the event using strings with the help of pre-populated lists for better performance (for JSON, XML) - Check usage of TreeMap in EventPublisher and keep the data structure HashMap within the actual output adapter for performance considerations. - Use guava ThreadFactoryBuilder to put create named thread pools as we have used in ExecutionPlanParser.java of Siddhi. Regards, On Wed, Jul 29, 2015 at 3:07 PM, Ramindu De Silva <ramin...@wso2.com> wrote: > more details » > <https://www.google.com/calendar/event?action=VIEW&eid=OWdtN2ZxZHBoZzZjdWNya3VqOWwxODZhMWcgdGhhcmlrQHdzbzIuY29t&tok=MTcjcmFtaW5kdXNAd3NvMi5jb21hOWQ4ZDNhNWU0M2NkYzM4MzMxMDc0MTZlMGNiZjg3NzQ4MmM3NDc3&ctz=Asia/Colombo&hl=en> > Code review on XML output mapper > *When* > Wed Jul 29, 2015 3pm – 4pm Colombo > *Where* > LK Trace Ground Floor Meeting Room - Moria Ext:1036214 (map > <https://maps.google.com/maps?q=LK+Trace+Ground+Floor+Meeting+Room+-+Moria+Ext:1036214&hl=en> > ) > *Video call* > https://plus.google.com/hangouts/_/wso2.com/code-review-on > <https://plus.google.com/hangouts/_/wso2.com/code-review-on?hceid=cmFtaW5kdXNAd3NvMi5jb20.9gm7fqdphg6cucrkuj9l186a1g> > *Calendar* > tha...@wso2.com > *Who* > • > Ramindu De Silva - organizer > • > Lasantha Fernando > • > Tharik Kanaka > • > Sriskandarajah Suhothayan > • > Dilini Muthumala > • > thili...@wso2.com > • > Thilina Rathnayake > • > saji...@wso2.com > > Going? *Yes > <https://www.google.com/calendar/event?action=RESPOND&eid=OWdtN2ZxZHBoZzZjdWNya3VqOWwxODZhMWcgdGhhcmlrQHdzbzIuY29t&rst=1&tok=MTcjcmFtaW5kdXNAd3NvMi5jb21hOWQ4ZDNhNWU0M2NkYzM4MzMxMDc0MTZlMGNiZjg3NzQ4MmM3NDc3&ctz=Asia/Colombo&hl=en> > - Maybe > <https://www.google.com/calendar/event?action=RESPOND&eid=OWdtN2ZxZHBoZzZjdWNya3VqOWwxODZhMWcgdGhhcmlrQHdzbzIuY29t&rst=3&tok=MTcjcmFtaW5kdXNAd3NvMi5jb21hOWQ4ZDNhNWU0M2NkYzM4MzMxMDc0MTZlMGNiZjg3NzQ4MmM3NDc3&ctz=Asia/Colombo&hl=en> > - No > <https://www.google.com/calendar/event?action=RESPOND&eid=OWdtN2ZxZHBoZzZjdWNya3VqOWwxODZhMWcgdGhhcmlrQHdzbzIuY29t&rst=2&tok=MTcjcmFtaW5kdXNAd3NvMi5jb21hOWQ4ZDNhNWU0M2NkYzM4MzMxMDc0MTZlMGNiZjg3NzQ4MmM3NDc3&ctz=Asia/Colombo&hl=en>* > more options » > <https://www.google.com/calendar/event?action=VIEW&eid=OWdtN2ZxZHBoZzZjdWNya3VqOWwxODZhMWcgdGhhcmlrQHdzbzIuY29t&tok=MTcjcmFtaW5kdXNAd3NvMi5jb21hOWQ4ZDNhNWU0M2NkYzM4MzMxMDc0MTZlMGNiZjg3NzQ4MmM3NDc3&ctz=Asia/Colombo&hl=en> > > Invitation from Google Calendar <https://www.google.com/calendar/> > > You are receiving this email at the account tha...@wso2.com because you > are subscribed for invitations on calendar tha...@wso2.com. > > To stop receiving these emails, please log in to > https://www.google.com/calendar/ and change your notification settings > for this calendar. > > Forwarding this invitation could allow any recipient to modify your RSVP > response. Learn More > <https://support.google.com/calendar/answer/37135#forwarding>. > -- *Tharik Kanaka* WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: tha...@wso2.com | Web: www.wso2.com
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
