Hi Imesh/Pubudu,
Please find my comments inline.
On Tue, Aug 25, 2015 at 12:31 AM, Pubudu Gunatilaka <pubu...@wso2.com>
wrote:
> Hi,
>
> build.sh file fails when there are no plugins in the {product/plugins}
> folder. We need to change the scripts as well.
>
pushd ${wso2_product_plugin_path}
cp * ${script_path}/plugins
popd
The above 'cp *" command will not fail if there are no files inside '
wso2_product_plugin_path'. But however it will fail if there's no '
wso2_product_plugin_path'or'script_path}/plugins'which I guess is not
possible.
> I could see the same syntax errors in the other docker images as well.
> Will do the needful.
>
> Thank you!
>
> On Mon, Aug 24, 2015 at 11:47 PM, Imesh Gunaratne <im...@wso2.com> wrote:
>
>> One other problem I noticed with this build.sh file is that it does not
>> copy the plugin files to plugins folder when executed with clean.
>>
>> On Mon, Aug 24, 2015 at 11:41 PM, Imesh Gunaratne <im...@wso2.com> wrote:
>>
>>> Hi,
>>>
>>> I found the following issue in ESB 4.8.1 build.sh file and fixed:
>>>
>>> echo "-----------------------------------"
>>> - echo "Building" ${wso2_product_type^^} - ${wso2_product_version}
>>> "template module"
>>> + echo "Building" ${wso2_product_type} - ${wso2_product_version}
>>> "template module"
>>> echo "-----------------------------------"
>>>
>>>
>>> https://github.com/wso2/product-private-paas/commit/f2f763e7612eeae1a1e211b1fd97a970b5c369f1
>>>
>>> This in-fact will change the 'wso2_product_type' to uppercase. However
it will not work with bash versions below v4.0.
So it's ok to remove them for now.
> --
>>> *Imesh Gunaratne*
>>> Senior Technical Lead
>>> WSO2 Inc: http://wso2.com
>>> T: +94 11 214 5345 M: +94 77 374 2057
>>> W: http://imesh.gunaratne.org
>>> Lean . Enterprise . Middleware
>>>
>>>
>>
>>
>> --
>> *Imesh Gunaratne*
>> Senior Technical Lead
>> WSO2 Inc: http://wso2.com
>> T: +94 11 214 5345 M: +94 77 374 2057
>> W: http://imesh.gunaratne.org
>> Lean . Enterprise . Middleware
>>
>>
>> _______________________________________________
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
>
> *Pubudu Gunatilaka*
> Software Engineer
> WSO2, Inc.: http://wso2.com
> lean.enterprise.middleware
> mobile: +94 77 4078049
>
Thanks,
--
*Lasindu Charith*
Software Engineer, WSO2 Inc.
Committer & PMC Member, Apache Stratos
Mobile: +94714427192 | Web: blog.lasindu.com
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev
