Hi Prasanna,

Comment RXT is specific to G-Reg hence it's ok to move but Server RXT
should belong to governance layer, ATM there are number of features we
implemented such as DiscoveryAgent and DiscoveryAgentTask in
carbon-governance project but without server.rxt there is no mean to keep
that code there, also conceptually Server RXT has number of  governance use
cases but we just haven't implemented in 5.0.0.

Can you please move back Server.rxt into carbon-governance project ?

Thanks !

On Wed, Jul 22, 2015 at 7:46 PM, <git...@wso2.org> wrote:

> Repository : https://github.com/wso2/carbon-governance
>
> On branch  : master
> Link       :
> https://github.com/wso2/carbon-governance/compare/ee0cb3f83b5784b2e169ca3d25464f96a7a47778...32da5d082967543b1d3abe1eb41609459c466ae9
>
> >---------------------------------------------------------------
>
> commit b99ab7c087e89615e16f52fcb66d63600d6d527c
> Author: prasa7 <prasannadanga...@gmail.com>
> Date:   Wed Jul 22 09:37:00 2015 +0530
>
>     Removed server and comment rxts from governance layer.
>     These rxt are G-Reg specific rxts. Hence these rxt will be bundled to
> G-Reg pack in product level(in org.wso2.registry.extension.server.feature).
>
>
> >---------------------------------------------------------------
>
> b99ab7c087e89615e16f52fcb66d63600d6d527c
>  .../resources/p2.inf                               |    2 -
>  .../resources/rxts/comment.rxt                     |   42 -----------
>  .../resources/rxts/server.rxt                      |   77
> --------------------
>  3 files changed, 0 insertions(+), 121 deletions(-)
>
> diff --git
> a/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/p2.inf
> b/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/p2.inf
> index a5bb89d..f884525 100644
> ---
> a/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/p2.inf
> +++
> b/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/p2.inf
> @@ -12,8 +12,6 @@
> org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../featur
>
>  
> org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/wadl.rxt,target:${installFolder}/../../resources/rxts/wadl.rxt,overwrite:true);\
>
>  
> org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/wsdl.rxt,target:${installFolder}/../../resources/rxts/wsdl.rxt,overwrite:true);\
>
>  
> org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/soapservice.rxt,target:${installFolder}/../../resources/rxts/soapservice.rxt,overwrite:true);\
>
> -org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/comment.rxt,target:${installFolder}/../../resources/rxts/comment.rxt,overwrite:true);\
>
> -org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/server.rxt,target:${installFolder}/../../resources/rxts/server.rxt,overwrite:true);\
>
>  
> org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxt.xsd,target:${installFolder}/../../resources/rxt.xsd,overwrite:true);\
>
>  
> org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/service-ui-config.xsd,target:${installFolder}/../../resources/service-ui-config.xsd,overwrite:true);\
>
>  
> org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/services-config.xml,target:${installFolder}/../../resources/services-config.xml,overwrite:true);\
> diff --git
> a/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/rxts/comment.rxt
> b/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/rxts/comment.rxt
> deleted file mode 100644
> index 5e7df5a..0000000
> ---
> a/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/rxts/comment.rxt
> +++ /dev/null
> @@ -1,42 +0,0 @@
> -<artifactType type="application/vnd.wso2-comments+xml"
> shortName="comments" singularLabel="Comment" pluralLabel="Comments"
> hasNamespace="false" iconSet="9">
> -    <storagePath>/publisher_comments/@{overview_hash}</storagePath>
> -    <nameAttribute>overview_resourcepath</nameAttribute>
> -    <ui>
> -        <list>
> -            <column name="resourcepath">
> -                <data type="path" value="overview_resourcepath"
> href="/publisher_comments/@{overview_hash}"/>
> -            </column>
> -        </list>
> -    </ui>
> -    <content>
> -        <table name="Overview">
> -            <field type="text" required="true" path="true">
> -                <name>resourcepath</name>
> -            </field>
> -            <field type="text" required="true">
> -                <name>hash</name>
> -            </field>
> -            <field type="text-area" required="true">
> -                <name>comment</name>
> -            </field>
> -            <field type="text" required="false">
> -                <name>replypath</name>
> -            </field>
> -            <field type="options">
> -                <name label="Comment Visibility">visibility</name>
> -                <values>
> -                    <value>Owner</value>
> -                    <value>role</value>
> -                    <value>public</value>
> -                </values>
> -            </field>
> -            <field type="options">
> -                <name label="Comment Status">status</name>
> -                <values>
> -                    <value>Open</value>
> -                    <value>Resolved</value>
> -                </values>
> -            </field>
> -        </table>
> -    </content>
> -</artifactType>
> \ No newline at end of file
> diff --git
> a/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/rxts/server.rxt
> b/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/rxts/server.rxt
> deleted file mode 100644
> index 1aae317..0000000
> ---
> a/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/rxts/server.rxt
> +++ /dev/null
> @@ -1,77 +0,0 @@
> -<?xml version="1.0"?>
> -<artifactType type="application/vnd.wso2-server+xml" shortName="server"
> singularLabel="Server" pluralLabel="Servers" hasNamespace="false"
> iconSet="20">
> -       <storagePath>/trunk/servers/@{name}</storagePath>
> -       <nameAttribute>overview_name</nameAttribute>
> -
> -       <ui>
> -               <list>
> -                       <column name="Name">
> -                               <data type="path" value="overview_name"
> href="@{storagePath}"/>
> -                       </column>
> -               </list>
> -       </ui>
> -
> -    <content>
> -        <table name="Overview">
> -            <field type="text" required="true">
> -                <name>Name</name>
> -            </field>
> -
> -            <field type="options">
> -                   <name label="Type">Type</name>
> -                   <values>
> -                       <value>Generic Server</value>
> -                       <value>WSO2 AS</value>
> -                       <value>WSO2 ESB</value>
> -                       <value>WSO2 BPS</value>
> -                       <value>WSO2 BRS</value>
> -                       <value>WSO2 DSS</value>
> -                       <value>WSO2 IS</value>
> -                       <value>WSO2 BAM</value>
> -                       <value>WSO2 CEP</value>
> -                   </values>
> -             </field>
> -        </table>
> -
> -       <table name="Root URL" columns="1"  maxoccurs="unbounded">
> -           <field type="text" url="true">
> -               <name label="URL">URL</name>
> -           </field>
> -       </table>
> -
> -       <table name="Credentials" columns="2" >
> -               <field type="checkbox">
> -                       <name label="BasicAuth">BasicAuth</name>
> -               </field>
> -
> -               <field type="checkbox">
> -                       <name label="OAuth">OAuth</name>
> -               </field>
> -       </table>
> -
> -       <table name="BasicAuth" columns="2" >
> -               <field type="text">
> -                       <name>User Name</name>
> -               </field>
> -               <field type="text">
> -                       <name>Password</name>
> -               </field>
> -       </table>
> -
> -       <table name="OAuth" columns="2" >
> -               <field type="text">
> -                       <name>Permission Grant Type</name>
> -               </field>
> -               <field type="text">
> -                       <name>Key</name>
> -               </field>
> -               <field type="text">
> -                       <name>Secret</name>
> -               </field>
> -               <field type="text">
> -                       <name>Access Code</name>
> -               </field>
> -       </table>
> -
> -    </content>
> -</artifactType>
> \ No newline at end of file
>
> _______________________________________________
> Commits mailing list
> comm...@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/commits
>



-- 
Sagara Gunathunga

Architect; WSO2, Inc.;  http://wso2.com
V.P Apache Web Services;    http://ws.apache.org/
Linkedin; http://www.linkedin.com/in/ssagara
Blog ;  http://ssagara.blogspot.com
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to