It is ok to redefined the python-pip module in configurator module since currently it is used in PCA and configurator only.
But this might be a issue with other python libraries as well if that commonly used among the python modules.Also if there is several python modules exists we need to redefined the libraries everywhere.IMO we may need to include separate module for python and that module we can include the common libraries for python. Thanks, Gayan On Sun, Sep 6, 2015 at 9:25 AM, Akila Ravihansa Perera <raviha...@wso2.com> wrote: > Hi Raj, > > Yes, I meant python-pip should not be removed from PCA module but should > be installed for configurator as well. > > I think it should be redefined for configurator module since python-pip is > not a compulsory package. We can use Java agent without it. > > Thanks. > > On Sun, Sep 6, 2015 at 6:17 AM, Rajkumar Rajaratnam <rajkum...@wso2.com> > wrote: > >> >> >> On Sun, Sep 6, 2015 at 7:45 AM, Akila Ravihansa Perera < >> raviha...@wso2.com> wrote: >> >>> Hi Raj, >>> >>> I think we should not remove python-pip from PCA module since those >>> dependencies should be installed for PCA to function. >>> >> >> In the very similar way, python-pip should be installed for configurator >> to function as well :). So if I am using java agent instead of python >> agent, how would configurator work without python-pip? IMO, we can either >> move python-pip to stratos_base or use [1] to redfine python-pip package in >> configurator if it is not already defined anywhere else. >> >> [1] >> http://stackoverflow.com/questions/15266347/puppet-test-if-a-package-already-defined >> >> Thanks, >> Raj. >> >>> >>> @Anuruddha: I still see that jinja2 is packed from PCA module [1]. Shall >>> we move this to configurator module? >>> >>> [1] >>> https://github.com/wso2/product-private-paas/blob/master/cartridges/vm/puppet/modules/python_agent/manifests/initialize.pp#L57 >>> >>> Thanks. >>> >>> On Sat, Sep 5, 2015 at 3:21 PM, Anuruddha Liyanarachchi < >>> anurudd...@wso2.com> wrote: >>> >>>> Hi Raj, >>>> >>>> Thanks for pointing this out. I have now added the jinja2 dependency to >>>> configurator module and removed from PCA. [1] >>>> >>>> [1] >>>> https://github.com/wso2/product-private-paas/blob/master/cartridges/vm/puppet/modules/configurator/manifests/init.pp#L32 >>>> >>>> On Sat, Sep 5, 2015 at 3:14 PM, Rajkumar Rajaratnam <rajkum...@wso2.com >>>> > wrote: >>>> >>>>> Hi, >>>>> >>>>> I think python-pip & jinja2 should be installed by configurator >>>>> puppet module, not by python agent. >>>>> >>>>> I am using vagrant, puppet and configurator to setup my development >>>>> environment, but I am not using python agent. Since $subject is not done, >>>>> I >>>>> had to modify configurator puppet module. >>>>> >>>>> It would be better if we do the $subject. >>>>> >>>>> Thanks, >>>>> Raj. >>>>> >>>>> -- >>>>> Rajkumar Rajaratnam >>>>> Committer & PMC Member, Apache Stratos >>>>> Software Engineer, WSO2 >>>>> >>>>> Mobile : +94777568639 >>>>> Blog : rajkumarr.com >>>>> >>>>> _______________________________________________ >>>>> Dev mailing list >>>>> Dev@wso2.org >>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> *Thanks and Regards,* >>>> Anuruddha Lanka Liyanarachchi >>>> Software Engineer - WSO2 >>>> Mobile : +94 (0) 712762611 >>>> Tel : +94 112 145 345 >>>> a <thili...@wso2.com>nurudd...@wso2.com >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> Dev@wso2.org >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> Akila Ravihansa Perera >>> WSO2 Inc.; http://wso2.com/ >>> >>> Blog: http://ravihansa3000.blogspot.com >>> >> >> >> >> -- >> Rajkumar Rajaratnam >> Committer & PMC Member, Apache Stratos >> Software Engineer, WSO2 >> >> Mobile : +94777568639 >> Blog : rajkumarr.com >> > > > > -- > Akila Ravihansa Perera > WSO2 Inc.; http://wso2.com/ > > Blog: http://ravihansa3000.blogspot.com > > _______________________________________________ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Gayan Gunarathne Technical Lead, WSO2 Inc. (http://wso2.com) Committer & PMC Member, Apache Stratos email : gay...@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
