Yes. rpc library inherited from the feature as Manu said. The problem was not in the rpc library. It was in with the carbon-dashboard version which we include in the UES release. Current carbon-dashboard version is 1.5.0.SNAPSHOT but in my product-ues pom file it was 1.4.0. Also in the product-ues GitHub, it is mentioned as* <carbon.dashboards.version>1.0.4</carbon.dashboards.version> *but in the carbon-dashboard pom file it is *<carbon.dashboards.version>1.0.5-SNAPSHOT</carbon.dashboards.version>* Shouldn't we sync those two versions?
Dashboard json file slightly changes in carbon-dashboard version 1.4.0 and carbon-dashboard version 1.5.0. SNAPSHOT. That was the root cause for this issue. I fixed the code according to the new version. @Sameera, I commit the changes and please review and marge below PRs. https://github.com/wso2/carbon-dashboards/pull/53 for https://wso2.org/jira/browse/UES-585 https://github.com/wso2/carbon-dashboards/pull/54 for https://wso2.org/jira/browse/UES-573 @Ayesha, Please review and merge https://github.com/wso2/carbon-dashboards/pull/60 for https://wso2.org/jira/browse/UES-595 *Sajith Abeywardhana* | Software Engineer WSO2, Inc | lean. enterprise. middleware. #20, Palm Grove, Colombo 03, Sri Lanka. Mobile: +94772260485 Email: saji...@wso2.com | Web: www.wso2.com On Sat, Oct 3, 2015 at 10:09 PM, Manuranga Perera <m...@wso2.com> wrote: > the rpc library should come automatically whit with Feature tag for set > pref. no need to include it manually. > > On Fri, Oct 2, 2015 at 7:36 PM, Sajith Abeywardhana <saji...@wso2.com> > wrote: > >> Hi Sameera, >> >> On Wed, Sep 30, 2015 at 1:12 PM, Sajith Abeywardhana <saji...@wso2.com> >> wrote: >> >>> Please review and merge >>> https://github.com/wso2/carbon-dashboards/pull/53 for >>> https://wso2.org/jira/browse/UES-585 >>> >>> For this we need to have rpc.js as a library. When I was testing it I >> directly included it to the index.xml as *<script >> src="http://sandbox.ig.gmodules.com/gadgets/js/rpc.js >> <http://sandbox.ig.gmodules.com/gadgets/js/rpc.js>"></script>.* But when >> you were trying, we didn't include that rpc library. That was the reason >> for the conflict. >> Now I have changed the designer.js to loads the rpc library along with UI >> initialization(This is the time set_pref get registered) and I added rcp.js >> to the portal/js/ folder. >> Please let me know If you have any concerns. >> >> *Sajith Abeywardhana* | Software Engineer >> WSO2, Inc | lean. enterprise. middleware. >> #20, Palm Grove, Colombo 03, Sri Lanka. >> Mobile: +94772260485 >> Email: saji...@wso2.com | Web: www.wso2.com >> >> >> >> >>> >>> *Sajith Abeywardhana* | Software Engineer >>> WSO2, Inc | lean. enterprise. middleware. >>> #20, Palm Grove, Colombo 03, Sri Lanka. >>> Mobile: +94772260485 >>> Email: saji...@wso2.com | Web: www.wso2.com >>> >> >> > > > -- > With regards, > *Manu*ranga Perera. > > phone : 071 7 70 20 50 > mail : m...@wso2.com >
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
