Hi Ayyoob, If JNA packages are used only where the waffle packages are used, it is okay to export JNA with waffle. But if JNA is used separately from waffle, it will not be good to export JNA from waffle.
Kernel team please confirm. Thanks, Maduranga. On Mon, Oct 5, 2015 at 3:25 PM, Ayyoob Hamza <[email protected]> wrote: > Hi, > I was planning to update orbit waffle bundle[1] due to [2]. And found that > JNA package is exported along with the waffle[3]. Further studying it found > that waffle apis requires JNA objects as parameters[4]. So Wondering > whether is it a good practice to bundle two separate orbit bundles or > export both together in on same bundle with its correct version or leave > the same version as it is on [3]. > > [1] https://github.com/wso2/orbit/blob/master/waffle/1.6.wso2v2/pom.xml > [2] https://wso2.org/jira/browse/IDENTITY-3574 > [3] > https://github.com/wso2/orbit/blob/master/waffle/1.6.wso2v2/pom.xml#L87 > [4] > https://github.com/wso2/carbon-identity/blob/master/components/oauth/org.wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/token/handlers/grant/iwa/ntlm/NTLMAuthenticationGrantHandler.java#L120-L122 > > Thanks > *Ayyoob Hamza* > *Software Engineer* > WSO2 Inc.; http://wso2.com > email: [email protected] cell: +94 77 1681010 <%2B94%2077%207779495> > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Maduranga Siriwardena Software Engineer WSO2 Inc. email: [email protected] mobile: +94718990591
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
