Hi Sajitha, Yes. There is an issue with the if condition as you pointed, You are welcome to send a PR for this :)
Thanks Godwin On Sat, Nov 21, 2015 at 8:52 AM, Sajith Ariyarathna <[email protected]> wrote: > Hi IS team, > > When looking at the > "org.wso2.carbon.identity.sso.saml.processors.SPInitLogoutRequestProcessor" > class, I noticed that the same condition is checked twice in line 71 [1], > and line 79 [2]. According to the error message in line 80 [3], checked > if-condition in line 79 is incorrect. > > Suggesting Fix: change the if-condition in line 79 to > StringUtils.isBlank(sessionIndex) > > [1] > https://github.com/wso2/carbon-identity/blob/master/components/sso-saml/org.wso2.carbon.identity.sso.saml/src/main/java/org/wso2/carbon/identity/sso/saml/processors/SPInitLogoutRequestProcessor.java#L71 > [2] > https://github.com/wso2/carbon-identity/blob/master/components/sso-saml/org.wso2.carbon.identity.sso.saml/src/main/java/org/wso2/carbon/identity/sso/saml/processors/SPInitLogoutRequestProcessor.java#L79 > [3] > https://github.com/wso2/carbon-identity/blob/master/components/sso-saml/org.wso2.carbon.identity.sso.saml/src/main/java/org/wso2/carbon/identity/sso/saml/processors/SPInitLogoutRequestProcessor.java#L80 > > Thanks. > -- > Sajith Ariyarathna > Software Engineer; WSO2, Inc.; http://wso2.com/ > mobile: +94 77 6602284, +94 71 3951048 > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- *Godwin Amila Shrimal* Senior Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: *+94772264165* linkedin: *http://lnkd.in/KUum6D <http://lnkd.in/KUum6D>* twitter: https://twitter.com/godwinamila
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
