On Wed, Jan 13, 2016 at 10:52 PM, Sajith Kariyawasam <[email protected]> wrote:
> Hi, > > Fileset exclude / include can be much more simplified to something like > following, instead of the pattern available at the moment [1] > > <includes> > <include>files/**</include> > <include>manifests/**</include> > <include>templates/**</include> > <include>metadata.json</include> > </includes> > <excludes> > <exclude>**/*.zip</exclude> > <exclude>**/*.jar</exclude> > <exclude>**/*.tar.gz</exclude> > <exclude>**/.git*</exclude> <!-- Excludes all git related > hidden files --> > </excludes> > > This focus on adding only the relevant folders of the top level and then > filtering out unnecessary files using excludes. > +1. We can further avoid any irrelevant additions by using *.pp and *.erb in manifests and templates, instead of including everything. > which eases maintenance > and also it avoids the need of adding more patterns for exclusion when > discovered, for eg at the moment only IntelliJ related project config > files are excluded, > but Eclipse based project files are not excluded :). In order for those to > exclude, a new pattern need to be added (<exclude>**/.project</exclude>) > > [1] > https://github.com/wso2/puppet-modules/blob/master/wso2brs/package.xml#L10-L28 > > Thanks, > Sajith > > -- > Sajith Kariyawasam > *Committer and PMC member, Apache Stratos, * > *WSO2 Inc.; http://wso2.com <http://wso2.com>* > *Mobile: 0772269575 <0772269575>* > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Thanks and Regards, Isuru H. +94 716 358 048* <http://wso2.com/>*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
