Thanks Samiyuru, Will attend to this.
I'm not quite sure whether we can do the formatting though. Regards Awanthika Awanthika Senarath Software Engineer, WSO2 Inc. Mobile: +94717681791 On Mon, Feb 8, 2016 at 2:27 PM, Samiyuru Senarathne <samiy...@wso2.com> wrote: > Hi, > > Structure and the used pattern looks fine. Apart from them, > > - We have to remove NotFoundException from the API and implementation > since that is not how MSF4J send responses in error cases. > - We can remove ApiResponseMessage class. > - Can we fix the formatting of the generated code? > - Can we remove the unused imports? (IE import java.io.InputStream; in > StockQuoteApiService) > > Best Regards, > Samiyuru > > On Mon, Feb 8, 2016 at 1:50 PM, Awanthika Senarath <awanth...@wso2.com> > wrote: > >> Hi Samyuru, >> >> I have edited the swagger codegen tool configurations and removed all >> unnecessary code being generated. This includes the servlet related codes >> and swagger annotations >> >> Please verify the attached folder structure and content to be of the >> expected form for the MSF4J server. >> >> >> Please let me know of any further modifications needed. >> >> Regards >> Awanthika >> >> Awanthika Senarath >> Software Engineer, WSO2 Inc. >> Mobile: +94717681791 >> >> >> >> On Fri, Feb 5, 2016 at 7:00 PM, Awanthika Senarath <awanth...@wso2.com> >> wrote: >> >>> Hi Samiyuru, >>> >>> Thanks! will try with a simpler use case. >>> >>> Regards >>> Awanthika >>> >>> Awanthika Senarath >>> Software Engineer, WSO2 Inc. >>> Mobile: +94717681791 >>> >>> >>> >>> On Fri, Feb 5, 2016 at 9:55 AM, Samiyuru Senarathne <samiy...@wso2.com> >>> wrote: >>> >>>> Hi, >>>> >>>> Those classes you were refering are not MSF4J service classes. >>>> Therefore, we don't have to consider them with the tool. IMO, since >>>> Pet-Sore sample is bit complex it's better if you could first work with >>>> samples other than the Pet-Store to get the tool running. >>>> >>>> Best Regards, >>>> Samiyuru >>>> >>>> On Thu, Feb 4, 2016 at 11:27 AM, Awanthika Senarath <awanth...@wso2.com >>>> > wrote: >>>> >>>>> >>>>> Hi Samiyuru, >>>>> >>>>> MSF4J tool generated code build fails with the following errors [1]. >>>>> >>>>> These imports are introduced by the swagger codegen library we are >>>>> using. I am working on changing these imports to the imports that are >>>>> supported by the MSF4J team. >>>>> >>>>> In going through your petstore sample I could observe the imports [3] >>>>> in the class [2]. >>>>> >>>>> I tried building the petstore sample and it builds fine. Could you >>>>> please let me know what causes the build break in the gen code of the >>>>> swagger codegen library? I have attached the gen code. >>>>> >>>>> >>>>> [1] >>>>> >>>>> [ERROR] Failed to execute goal >>>>> org.apache.maven.plugins:maven-compiler-plugin:3.3:compile >>>>> (default-compile) on project SampleTestProjectUsed: Compilation failure: >>>>> Compilation failure: >>>>> [ERROR] >>>>> /home/awanthika/WSO2/master-source/mss-tooling/eclipse-project/runtime-New_configuration/SampleTestProjectUsed/src/main/java/org/wso2/sampole/api/ApiOriginFilter.java:[5,1] >>>>> package javax.servlet does not exist >>>>> [ERROR] >>>>> /home/awanthika/WSO2/master-source/mss-tooling/eclipse-project/runtime-New_configuration/SampleTestProjectUsed/src/main/java/org/wso2/sampole/api/ApiOriginFilter.java:[6,26] >>>>> package javax.servlet.http does not exist >>>>> [ERROR] >>>>> /home/awanthika/WSO2/master-source/mss-tooling/eclipse-project/runtime-New_configuration/SampleTestProjectUsed/src/main/java/org/wso2/sampole/api/ApiOriginFilter.java:[9,54] >>>>> package javax.servlet does not exist >>>>> >>>>> >>>>> [2]package >>>>> org.wso2.msf4j.examples.petstore.util.fe.security.LoginFilter.java; >>>>> >>>>> [3] >>>>> import javax.servlet.ServletException; >>>>> import javax.servlet.ServletRequest; >>>>> import javax.servlet.ServletResponse; >>>>> import javax.servlet.http.HttpServletRequest; >>>>> import javax.servlet.http.HttpServletResponse; >>>>> >>>>> >>>>> Regards >>>>> Awanthika Senarath >>>>> Software Engineer, WSO2 Inc. >>>>> Mobile: +94717681791 >>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Samiyuru Senarathne >>>> *Software Engineer* >>>> Mobile : +94 (0) 71 134 6087 >>>> samiy...@wso2.com >>>> >>> >>> >> > > > -- > Samiyuru Senarathne > *Software Engineer* > Mobile : +94 (0) 71 134 6087 > samiy...@wso2.com >
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
