Merged. Cheers, Anjana.
On Fri, Feb 26, 2016 at 4:37 PM, Supun Sethunga <sup...@wso2.com> wrote: > Added the changes as per code review. Please merge [1]. > > [1] https://github.com/wso2/carbon-analytics/pull/159 > > Thanks, > Supun > > On Fri, Feb 26, 2016 at 11:30 AM, Anjana Fernando <anj...@wso2.com> wrote: > >> Please schedule a code review for this. >> >> Cheers, >> Anjana. >> >> On Fri, Feb 26, 2016 at 11:03 AM, Supun Sethunga <sup...@wso2.com> wrote: >> >>> Hi, >>> >>> Please find the PR [1] for adding string compression to the event >>> analytics relational provider. >>> >>> [1] https://github.com/wso2/carbon-analytics/pull/159 >>> >>> Regards, >>> Supun >>> >>> On Wed, Feb 24, 2016 at 3:35 PM, Supun Sethunga <sup...@wso2.com> wrote: >>> >>>> Thanks! >>>> >>>> Regards, >>>> Supun >>>> >>>> On Wed, Feb 24, 2016 at 2:20 PM, Anjana Fernando <anj...@wso2.com> >>>> wrote: >>>> >>>>> Merged the PR. >>>>> >>>>> Cheers, >>>>> Anjana. >>>>> >>>>> On Wed, Feb 24, 2016 at 1:00 PM, Supun Sethunga <sup...@wso2.com> >>>>> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> I have done the changes suggested during the code review. Please >>>>>> review and merge [1]. >>>>>> >>>>>> Will send a separate PR for Compressing the json string. >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Supun >>>>>> >>>>>> On Fri, Feb 19, 2016 at 3:37 PM, Anjana Fernando <anj...@wso2.com> >>>>>> wrote: >>>>>> >>>>>>> Hi Supun, >>>>>>> >>>>>>> Can you please schedule a code review for this. >>>>>>> >>>>>>> Cheers, >>>>>>> Anjana. >>>>>>> >>>>>>> On Tue, Feb 16, 2016 at 4:30 PM, Supun Sethunga <sup...@wso2.com> >>>>>>> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> Attached [1] is the PR for $subject. Please review and merge. >>>>>>>> >>>>>>>> [1] https://github.com/wso2/carbon-analytics/pull/156 >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Supun >>>>>>>> >>>>>>>> -- >>>>>>>> *Supun Sethunga* >>>>>>>> Software Engineer >>>>>>>> WSO2, Inc. >>>>>>>> http://wso2.com/ >>>>>>>> lean | enterprise | middleware >>>>>>>> Mobile : +94 716546324 >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Anjana Fernando* >>>>>>> Senior Technical Lead >>>>>>> WSO2 Inc. | http://wso2.com >>>>>>> lean . enterprise . middleware >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Supun Sethunga* >>>>>> Software Engineer >>>>>> WSO2, Inc. >>>>>> http://wso2.com/ >>>>>> lean | enterprise | middleware >>>>>> Mobile : +94 716546324 >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> *Anjana Fernando* >>>>> Senior Technical Lead >>>>> WSO2 Inc. | http://wso2.com >>>>> lean . enterprise . middleware >>>>> >>>> >>>> >>>> >>>> -- >>>> *Supun Sethunga* >>>> Software Engineer >>>> WSO2, Inc. >>>> http://wso2.com/ >>>> lean | enterprise | middleware >>>> Mobile : +94 716546324 >>>> >>> >>> >>> >>> -- >>> *Supun Sethunga* >>> Software Engineer >>> WSO2, Inc. >>> http://wso2.com/ >>> lean | enterprise | middleware >>> Mobile : +94 716546324 >>> >> >> >> >> -- >> *Anjana Fernando* >> Senior Technical Lead >> WSO2 Inc. | http://wso2.com >> lean . enterprise . middleware >> > > > > -- > *Supun Sethunga* > Software Engineer > WSO2, Inc. > http://wso2.com/ > lean | enterprise | middleware > Mobile : +94 716546324 > -- *Anjana Fernando* Senior Technical Lead WSO2 Inc. | http://wso2.com lean . enterprise . middleware
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
