it would be worth while to expose transaction isolation as well [1] [1] https://github.com/brettwooldridge/HikariCP/blob/dev/src/main/java/com/zaxxer/hikari/HikariConfig.java#L696
On Thu, Apr 28, 2016 at 7:03 PM, Ramith Jayasinghe <[email protected]> wrote: > Hi, > Currently, It seems like our wrapper does not expose some of > configurations available in Hikari [1]. > At minimum we need following : 'autoCommit', and ability to add data > source properties [2]. > > Can we have a release with this change? > > [1] > https://github.com/wso2/carbon-datasources/blob/master/components/org.wso2.carbon.datasource.core/src/main/java/org/wso2/carbon/datasource/rdbms/hikari/HikariConfiguration.java > [2] > https://github.com/brettwooldridge/HikariCP/blob/dev/src/main/java/com/zaxxer/hikari/HikariConfig.java#L369 > [3] > https://github.com/brettwooldridge/HikariCP/blob/dev/src/main/java/com/zaxxer/hikari/HikariConfig.java#L285 > > > > On Tue, Feb 23, 2016 at 6:03 PM, Anjana Fernando <[email protected]> wrote: > >> Hi Ruwan, >> >> HikariCP says that, they use the JDBC4's Connection#isValid method to >> check for connection liveness, where it seems to be a native way to check >> if connections are stale or not. This itself seems like a good improvement >> over the earlier mechanism used in DBCP/JDBC-Pool. >> >> Cheers, >> Anjana. >> >> On Tue, Feb 23, 2016 at 4:44 PM, Ruwan Abeykoon <[email protected]> wrote: >> >>> Hi All, >>> Is there something compatible to "testWhileIdle" (DBCP/TomcatCP) in >>> HikariCP ?, This is something which can be helpful to prevent connection >>> pool exhaustion due to some firewall behaviour [1]. >>> I think we need to add this in our wrapper, if it is not supported OOB >>> in HikariCP. >>> >>> [1]https://groups.google.com/forum/#!topic/hikari-cp/E4D-3owIug4 (Brett >>> Wooldridge) >>> >>> Cheers, >>> Ruwan >>> >>> On Tue, Feb 23, 2016 at 2:55 PM, Dinusha Boteju <[email protected]> >>> wrote: >>> >>>> Hi all, >>>> >>>> We are in the process of implementing data sources for C5. As the jdbc >>>> connection pool implementation we are hoping to use HikariCP [1]. For >>>> previous Carbon versions tomcat jdbc connection pooling is used as the >>>> connection pool implementation. The reasons behind migrating from tomcat >>>> connection pool to HikariCP is mainly performance, reliability and ease of >>>> use. Comparison among connection pools can be found in [2]. Please share >>>> your thoughts on this. >>>> >>>> [1] - https://github.com/brettwooldridge/HikariCP >>>> [2] - https://github.com/brettwooldridge/HikariCP/wiki/Pool-Analysis >>>> >>>> Thanks, >>>> -- >>>> *Dinusha Boteju* >>>> *WSO2, Inc. http://wso2.com <http://wso2.com/> * >>>> *lean.enterprise.middleware.* >>>> >>>> email: [email protected] <[email protected]> >>>> phone:(+94) 779701986 <%28%2B94%29%20777739736> >>>> >>>> _______________________________________________ >>>> Architecture mailing list >>>> [email protected] >>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>> >>>> >>> >>> >>> -- >>> >>> *Ruwan Abeykoon* >>> *Architect,* >>> *WSO2, Inc. http://wso2.com <http://wso2.com/> * >>> *lean.enterprise.middleware.* >>> >>> email: [email protected] >>> >>> _______________________________________________ >>> Architecture mailing list >>> [email protected] >>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>> >>> >> >> >> -- >> *Anjana Fernando* >> Senior Technical Lead >> WSO2 Inc. | http://wso2.com >> lean . enterprise . middleware >> >> _______________________________________________ >> Architecture mailing list >> [email protected] >> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >> >> > > > -- > Ramith Jayasinghe > Technical Lead > WSO2 Inc., http://wso2.com > lean.enterprise.middleware > > E: [email protected] > P: +94 772534930 > -- Ramith Jayasinghe Technical Lead WSO2 Inc., http://wso2.com lean.enterprise.middleware E: [email protected] P: +94 772534930
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
