Hi Chamila,

On Mon, May 9, 2016 at 1:50 PM, Chamila De Alwis <chami...@wso2.com> wrote:

> Hi,
>
> In wso2base/manifests/init.pp [1], we do a Hiera lookup
> for wso2::secure_vault_configs, without checking if SecureVault
> configurations are needed. IMO we should only do this lookup if the
> previous lookup for wso2::enable_secure_vault is true.
>

Yes, we need to do lookup for  wso2::secure_vault_configs only if secure
vault is enabled. Will do the needed changes.

Thanks.

Otherwise wso2::secure_vault_configs[key_store_password] has to be added
> even if SecureVault is not enabled.
>
> [1] -
> https://github.com/wso2/puppet-modules/blob/master/modules/wso2base/manifests/init.pp#L61-L63
>
>
> Regards,
> Chamila de Alwis
> Committer and PMC Member - Apache Stratos
> Software Engineer | WSO2 | +94772207163
> Blog: code.chamiladealwis.com
>
>
>


-- 
Thanuja Uruththirakodeeswaran
Software Engineer
WSO2 Inc.;http://wso2.com
lean.enterprise.middleware

mobile: +94 774363167
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to