Hi all, +1. This is about failure of first action of app creation, if it is failed, just show error message and continue. No need to update database.
thank you. On Mon, Jul 18, 2016 at 9:18 AM, Mahesh Chinthaka <mahe...@wso2.com> wrote: > Yes adding a failure pop up message would be enough IMO. I forgot to > mention that in my previous reply. Thanks Danushka > > On Mon, Jul 18, 2016 at 9:13 AM, Danushka Fernando <danush...@wso2.com> > wrote: > >> To be specific, AFAIK even we name these as events, This is not for data >> publishing kind of a thing. This is only to render the ui. Then there is an >> issue of UI when its broken in earlier stages it don't show the msg box >> with msg of application creation failed. So before showing that it should >> show a red 'X' mark in-front of particular action. eg: Building Docker >> Image. >> IIRC when the all events got removed from DB, UI keep spinning with empty >> table. So lets not add the entry of failed event. And then when there are >> no events in event table for configured time lets popup failure message. >> @Manjula: WDYT? >> >> Thanks & Regards >> Danushka Fernando >> Senior Software Engineer >> WSO2 inc. http://wso2.com/ >> Mobile : +94716332729 >> >> On Mon, Jul 18, 2016 at 8:50 AM, Mahesh Chinthaka <mahe...@wso2.com> >> wrote: >> >>> Hi All, >>> >>> Isnt it better to avoid adding an event at this point ? >>> Since nothing has been created related to application , no need of >>> adding an event right ? >>> >>> WDYT ? >>> >>> On Sat, Jul 9, 2016 at 8:19 AM, Amalka Subasinghe <ama...@wso2.com> >>> wrote: >>> >>>> Hi, >>>> >>>> In our app creation logic, we have number of steps and when each step >>>> failed/succeeded, we add a event to a event table. >>>> >>>> We found a situation, where the createAppInDataBase step failed, then >>>> the addAppCreationEvent also getting failed. >>>> That's because, in createAppInDataBase we add application and version >>>> data to the database and then in addAppCreationEvent we query the >>>> AC_VERSION table to get the application version. >>>> >>>> How we fix this issue? although the createAppInDataBase step failed, >>>> addAppCreationEvent cannot be failed. >>>> >>>> [1] https://wso2.org/jira/browse/APPCLOUD-206 >>>> >>>> Thanks >>>> Amalka >>>> >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> Dev@wso2.org >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> *Mahesh Chinthaka Vidanagama* | Software Engineer >>> WSO2, Inc | lean. enterprise. middleware. >>> #20, Palm Grove, Colombo 03, Sri Lanka >>> Mobile: +94 71 63 63 083 | Work: +94 112 145 345 >>> Email: mahe...@wso2.com | Web: www.wso2.com >>> >> >> > > > -- > *Mahesh Chinthaka Vidanagama* | Software Engineer > WSO2, Inc | lean. enterprise. middleware. > #20, Palm Grove, Colombo 03, Sri Lanka > Mobile: +94 71 63 63 083 | Work: +94 112 145 345 > Email: mahe...@wso2.com | Web: www.wso2.com > -- Manjula Rathnayaka Associate Technical Lead WSO2, Inc. Mobile:+94 77 743 1987
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
