Hi , We have reviewed and merged.
*Thank youVivekananthan Sivanayagam* *Associate Software Engineer | WSO2* *E:vivekanant...@wso2.com <e%3avivekanant...@wso2.com>* *M:+94752786138* On Thu, Aug 4, 2016 at 3:12 PM, Vivekananthan Sivanayagam < vivekanant...@wso2.com> wrote: > Hi Malaka, > > Noted. > > > > > *Thank youVivekananthan Sivanayagam* > > *Associate Software Engineer | WSO2* > > *E:vivekanant...@wso2.com <e%3avivekanant...@wso2.com>* > *M:+94752786138 <%2B94752786138>* > > On Thu, Aug 4, 2016 at 2:49 PM, Malaka Silva <mal...@wso2.com> wrote: > >> Thx for the information Kim. >> >> @Vivekananthan - Can we check this and merge? >> >> On Thu, Aug 4, 2016 at 1:54 PM, 김대경 <dkg....@gmail.com> wrote: >> >>> Hi Silva, >>> >>> I sent all information about improvement by email before... >>> >>> Did you mean.. >>> create issue in wso2 jira? >>> >>> Code change is about 6 line. >>> I think this is so simple change.. >>> >>> What should I do..? >>> >>> ============ sent before =========== >>> Hi Silva. >>> >>> This is about Pull request. >>> https://github.com/wso2-extensions/esb-integration-base/pull/3 >>> >>> In other language in UTF-8 like ko_KR.UTF-8, one char is not 4 byte. >>> >>> So, split response stream by 1024 byte may cause split one character.. >>> >>> For example assume that '한글's bit is '010100110111' and it is located >>> on 1024th byte. >>> >>> Then, current code will split it into xxxxxxx~xxx01010011 and >>> 0111xxx~xxx. >>> And then it will be casted to string by new String(byte[]). >>> In this case '한글' will be converted to similarly '한�'. >>> >>> I improved this case by read response stream by BufferedReader and char >>> array. >>> >>> Please check the code, I commited. >>> >>> Sincerely. >>> >>> 2016. 8. 4. 오후 5:12에 "Malaka Silva" <mal...@wso2.com>님이 작성: >>> >>> Hi Kim, >>>> >>>> Please send us more details about the improvement and will check and >>>> merge the request. >>>> >>>> Find more information in [1] >>>> >>>> [1] >>>> https://docs.wso2.com/display/ESBCONNECTORS/Creating+a+Third+Party+Connector+and+Publishing+in+WSO2+Store >>>> >>>> ---------- Forwarded message ---------- >>>> From: 김대경 <dkg....@gmail.com> >>>> Date: Wed, Aug 3, 2016 at 1:21 PM >>>> Subject: wso2-extensions contribution.. >>>> To: malaka.si...@gmail.com >>>> >>>> >>>> Dear Silva. >>>> >>>> Thank you for read this mail. >>>> >>>> I'm writing to inquire about github contribution.. >>>> >>>> I'm testing wso2 esb's functionalites. >>>> >>>> While.. I found a little improvement. >>>> >>>> So I recently created pull request to >>>> wso2-extensions/esb-integration-base. >>>> >>>> But.. I think no one see this request. >>>> >>>> How I can resolve this problem? >>>> >>>> I want this improvement could be applied next release. >>>> >>>> I look forward to hearing from you. >>>> >>>> Sincerely. >>>> from Daekyung Kim. >>>> >>>> On Thu, Aug 4, 2016 at 7:04 AM, Malaka Silva <malaka.si...@gmail.com> >>>> wrote: >>>> >>>>> Hi Kim, >>>>> >>>>> Please send us more details about the imporvement and will check and >>>>> merge the request. >>>>> >>>>> Find more information in [1] >>>>> >>>>> [1] >>>>> https://docs.wso2.com/display/ESBCONNECTORS/Creating+a+Third+Party+Connector+and+Publishing+in+WSO2+Store >>>>> >>>>> ---------- Forwarded message ---------- >>>>> From: 김대경 <dkg....@gmail.com> >>>>> Date: Wed, Aug 3, 2016 at 1:21 PM >>>>> Subject: wso2-extensions contribution.. >>>>> To: malaka.si...@gmail.com >>>>> >>>>> >>>>> Dear Silva. >>>>> >>>>> Thank you for read this mail. >>>>> >>>>> I'm writing to inquire about github contribution.. >>>>> >>>>> I'm testing wso2 esb's functionalites. >>>>> >>>>> While.. I found a little improvement. >>>>> >>>>> So I recently created pull request to >>>>> wso2-extensions/esb-integration-base. >>>>> >>>>> But.. I think no one see this request. >>>>> >>>>> How I can resolve this problem? >>>>> >>>>> I want this improvement could be applied next release. >>>>> >>>>> I look forward to hearing from you. >>>>> >>>>> Sincerely. >>>>> from Daekyung Kim. >>>>> >>>>> >>>> >>>> >>>> -- >>>> >>>> Best Regards, >>>> >>>> Malaka Silva >>>> Senior Technical Lead >>>> M: +94 777 219 791 >>>> Tel : 94 11 214 5345 >>>> Fax :94 11 2145300 >>>> Skype : malaka.sampath.silva >>>> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 >>>> Blog : http://mrmalakasilva.blogspot.com/ >>>> >>>> WSO2, Inc. >>>> lean . enterprise . middleware >>>> https://wso2.com/signature >>>> http://www.wso2.com/about/team/malaka-silva/ >>>> <http://wso2.com/about/team/malaka-silva/> >>>> https://store.wso2.com/store/ >>>> >>>> Don't make Trees rare, we should keep them with care >>>> >>> >> >> >> -- >> >> Best Regards, >> >> Malaka Silva >> Senior Technical Lead >> M: +94 777 219 791 >> Tel : 94 11 214 5345 >> Fax :94 11 2145300 >> Skype : malaka.sampath.silva >> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 >> Blog : http://mrmalakasilva.blogspot.com/ >> >> WSO2, Inc. >> lean . enterprise . middleware >> https://wso2.com/signature >> http://www.wso2.com/about/team/malaka-silva/ >> <http://wso2.com/about/team/malaka-silva/> >> https://store.wso2.com/store/ >> >> Don't make Trees rare, we should keep them with care >> > >
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
