Hi Vishanth,

Thanks for pointing this, I have updated the config path to be relative to
the source root.

Thanks
Abhishek

On Thu, Aug 4, 2016 at 10:36 AM, Vishanth Balasubramaniam <
vishan...@wso2.com> wrote:

> Hi Abhishek,
>
> I see that you have given absolute path for "TestConfigPath" in
> "common/test-context.go". Why don't we give relative path from the project
> directory for this?
>
> Regards,
> Vishanth
>
> On Mon, Jul 11, 2016 at 5:22 PM, Imesh Gunaratne <im...@wso2.com> wrote:
>
>> Hi Abhishek,
>>
>> On Mon, Jul 11, 2016 at 1:53 PM, Abhishek Tiwari <
>> abhishek.tiwari0...@gmail.com> wrote:
>>
>>> Hi Mentors,
>>>
>>> I have been working on migrating the WSO2 Dockerfiles test framework
>>> from bash and python to use Golang. I must say, its been quite a ride but
>>> finally the migration has been successful. I am happy to offload many
>>> important features (logging, JSON parsing etc) to existing Golang packages.
>>>
>>
>>> I have also implemented interval based polling with linear backoff for
>>> exposed ports and carbon server status. The changes are committed to the
>>> repo [1], would love to get your feedback/comments.
>>>
>>
>> ​Very nice to hear this!​
>>
>> ​We will go through the code. May be you can arrange a session to review
>> this.
>>
>>
>>>
>>> Since I am totally new to this language and completely blank on its
>>> coding standards, I am following the coding standards used in the open
>>> source Kubernetes [2].
>>>
>>
>> ​+1 for following K8S coding standards. A bunch of Google developers are
>> involved in that​
>>
>> ​project and AFAIK coding standards are at their best.
>>
>>>
>>> I absolutely love Golang and those who are interested, I would highly
>>> recommend gobyexample [3], I was able to get up to speed within hours.
>>>
>>
>> ​Yeah [3] is really useful. We also did couple of sessions on Golang at
>> WSO2 [4]
>>
>> [4] http://www.slideshare.net/imesh/an-introduction-to-go-55991343
>>
>> Thanks
>> ​
>>
>>
>>>
>>> Thanks,
>>> Abhishek
>>>
>>> [1]. https://github.com/abhishek0198/test-framework/
>>> [2]. https://github.com/kubernetes/kubernetes
>>> [3]. https://gobyexample.com/
>>>
>>
>>
>>
>> --
>> *Imesh Gunaratne*
>> Software Architect
>> WSO2 Inc: http://wso2.com
>> T: +94 11 214 5345 M: +94 77 374 2057
>> W: https://medium.com/@imesh TW: @imesh
>>
>>
>
>
> --
> *Vishanth Balasubramaniam*
> Committer & PMC Member, Apache Stratos,
> Software Engineer, WSO2 Inc.; http://wso2.com
>
> mobile: *+94 77 17 377 18*
> about me: *http://about.me/vishanth <http://about.me/vishanth>*
>
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to