Noted Malaka.

On Wed, Nov 16, 2016 at 11:35 AM, Malaka Silva <[email protected]> wrote:

> Hi Thulasika,
>
> As we discussed offline please check the fix.
>
> On Wed, Nov 16, 2016 at 10:30 AM, Farasath Ahamed <[email protected]>
> wrote:
>
>> Hi Malaka/Thulasika,
>>
>> Since we can't fix this for IS 5.2.0 now as it is already released. Shall
>> we fix it from JWT bearer grant connector side for IS 5.2.0 only?
>> Otherwise, we won't have a JWT connector that is working with IS 5.2.0.
>>
>> WDYT?
>>
>> Thanks,
>>
>> Farasath Ahamed
>> Software Engineer, WSO2 Inc.; http://wso2.com
>> Mobile: +94777603866
>> Blog: blog.farazath.com
>> Twitter: @farazath619 <https://twitter.com/farazath619>
>> <http://wso2.com/signature>
>>
>>
>>
>> On Wed, Nov 16, 2016 at 10:18 AM, Thulasika Vijayanathan <
>> [email protected]> wrote:
>>
>>> yes Malaka, It doesn't work with fresh 5.2.0 pack.
>>>
>>> On Tue, Nov 15, 2016 at 1:57 PM, Malaka Silva <[email protected]> wrote:
>>>
>>>> If this does not work with fresh pack we can't say it's supported.
>>>>
>>>> On Tue, Nov 15, 2016 at 9:38 AM, Thulasika Vijayanathan <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> I have applied this fixed as a patch in 5.2.0 it works.
>>>>>
>>>>> Thanks,
>>>>> Thulasika.
>>>>>
>>>>> On Mon, Nov 14, 2016 at 12:25 AM, Farasath Ahamed <[email protected]>
>>>>> wrote:
>>>>>
>>>>>> Yes. This is now fixed with [1] by Maduranga. Now we can enable to
>>>>>> disable custom grant types using the Service Provider UI.
>>>>>>
>>>>>> Shall we update the JWT Grant Type connector docs with this change?
>>>>>>
>>>>>>
>>>>>> [1] https://wso2.org/jira/browse/IDENTITY-5260
>>>>>>
>>>>>> Thanks,
>>>>>> Farasath Ahamed
>>>>>> Software Engineer, WSO2 Inc.; http://wso2.com
>>>>>> Mobile: +94777603866
>>>>>> Blog: blog.farazath.com
>>>>>> Twitter: @farazath619 <https://twitter.com/farazath619>
>>>>>> <http://wso2.com/signature>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Fri, Nov 11, 2016 at 5:36 PM, Malaka Silva <[email protected]>
>>>>>> wrote:
>>>>>>
>>>>>>> So the fix needs to come from IS side I guess?
>>>>>>>
>>>>>>> On Fri, Nov 11, 2016 at 4:44 PM, Maduranga Siriwardena <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi Thulasika,
>>>>>>>>
>>>>>>>> This issue is already reported with [1].
>>>>>>>>
>>>>>>>> As a fix we are planning to add the custom grant types also to the
>>>>>>>> OAuth application configuration page to enable or disable.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Maduranga.
>>>>>>>>
>>>>>>>> [1] https://wso2.org/jira/browse/IDENTITY-5260
>>>>>>>>
>>>>>>>> On Nov 11, 2016 4:23 PM, "Thulasika Vijayanathan" <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi ,
>>>>>>>>>
>>>>>>>>> I have checked the JWT grant type[1] in IS 5.2.0. It does not
>>>>>>>>>  work, when validating the grant type it throws the exception[2].
>>>>>>>>>
>>>>>>>>> We need to get the  Allowed grant types as JWT,  but there is no
>>>>>>>>> option to thick the JWT grant type in UI. is there any way to get the 
>>>>>>>>> JWT
>>>>>>>>> grant type?
>>>>>>>>> [image: Inline image 2]
>>>>>>>>>
>>>>>>>>> [1] https://github.com/wso2-extensions/identity-oauth2-grant
>>>>>>>>> -jwt/blob/master/component/grant-type/src/main/java/org/wso2
>>>>>>>>> /carbon/identity/oauth2/grant/jwt/JWTBearerGrantHandler.java#L125
>>>>>>>>>
>>>>>>>>> [2] https://github.com/wso2-extensions/identity-inbound-auth
>>>>>>>>> -oauth/blob/v5.1.3/components/org.wso2.carbon.identity.oauth
>>>>>>>>> /src/main/java/org/wso2/carbon/identity/oauth2/token/handler
>>>>>>>>> s/grant/AbstractAuthorizationGrantHandler.java#L507
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Thulasika.
>>>>>>>>> --
>>>>>>>>> Thulasika
>>>>>>>>> Associate Software Engineer
>>>>>>>>> Mobile:0778014295
>>>>>>>>> email: [email protected] <[email protected]>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>>
>>>>>>> Best Regards,
>>>>>>>
>>>>>>> Malaka Silva
>>>>>>> Senior Technical Lead
>>>>>>> M: +94 777 219 791
>>>>>>> Tel : 94 11 214 5345
>>>>>>> Fax :94 11 2145300
>>>>>>> Skype : malaka.sampath.silva
>>>>>>> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77
>>>>>>> Blog : http://mrmalakasilva.blogspot.com/
>>>>>>>
>>>>>>> WSO2, Inc.
>>>>>>> lean . enterprise . middleware
>>>>>>> https://wso2.com/signature
>>>>>>> http://www.wso2.com/about/team/malaka-silva/
>>>>>>> <http://wso2.com/about/team/malaka-silva/>
>>>>>>> https://store.wso2.com/store/
>>>>>>>
>>>>>>> Don't make Trees rare, we should keep them with care
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Thulasika
>>>>> Associate Software Engineer
>>>>> Mobile:0778014295
>>>>> email: [email protected] <[email protected]>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> Best Regards,
>>>>
>>>> Malaka Silva
>>>> Senior Technical Lead
>>>> M: +94 777 219 791
>>>> Tel : 94 11 214 5345
>>>> Fax :94 11 2145300
>>>> Skype : malaka.sampath.silva
>>>> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77
>>>> Blog : http://mrmalakasilva.blogspot.com/
>>>>
>>>> WSO2, Inc.
>>>> lean . enterprise . middleware
>>>> https://wso2.com/signature
>>>> http://www.wso2.com/about/team/malaka-silva/
>>>> <http://wso2.com/about/team/malaka-silva/>
>>>> https://store.wso2.com/store/
>>>>
>>>> Don't make Trees rare, we should keep them with care
>>>>
>>>
>>>
>>>
>>> --
>>> Thulasika
>>> Associate Software Engineer
>>> Mobile:0778014295
>>> email: [email protected] <[email protected]>
>>>
>>
>>
>
>
> --
>
> Best Regards,
>
> Malaka Silva
> Senior Technical Lead
> M: +94 777 219 791
> Tel : 94 11 214 5345
> Fax :94 11 2145300
> Skype : malaka.sampath.silva
> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77
> Blog : http://mrmalakasilva.blogspot.com/
>
> WSO2, Inc.
> lean . enterprise . middleware
> https://wso2.com/signature
> http://www.wso2.com/about/team/malaka-silva/
> <http://wso2.com/about/team/malaka-silva/>
> https://store.wso2.com/store/
>
> Don't make Trees rare, we should keep them with care
>



-- 
Thulasika
Associate Software Engineer
Mobile:0778014295
email: [email protected] <[email protected]>
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to