IMO, changing layout of a page that comes from another component is wrong
as it might break the UX of that page. Instead, there should be a way to
configure the layout of that page. In that way, the developer of the page
is intentionally giving an extension point to change the layout.

e.g.

In the error page:

{{layout @config.errorPageLayout}}
...

In the component.yaml file:

...
config:
     errorPageLayout: "default"
...


In your app's component.yaml file:

...
config:
     errorPageLayout: "main"
...



On Mon, Jan 23, 2017 at 5:52 PM, Manuranga Perera <m...@wso2.com> wrote:

> https://github.com/wso2/carbon-uuf/issues/156
>
> On Sat, Jan 21, 2017 at 5:54 AM, Danushka Fernando <danush...@wso2.com>
> wrote:
>
>> Not sure which components its coming from. For example 404 error page is
>> a default error page coming from UUF.
>>
>> Thanks & Regards
>> Danushka Fernando
>> Senior Software Engineer
>> WSO2 inc. http://wso2.com/
>> Mobile : +94716332729 <+94%2071%20633%202729>
>>
>> On Sat, Jan 21, 2017 at 10:18 AM, SajithAR Ariyarathna <sajit...@wso2.com
>> > wrote:
>>
>>> On Sat, Jan 21, 2017 at 6:20 AM, Danushka Fernando <danush...@wso2.com>
>>>> wrote:
>>>>
>>>>> Hi All
>>>>> I found that default error pages like 404 error page which comes from
>>>>> UUF doesn't use app's basic layout. And I couldn't find a way to override
>>>>> it. Is there a way of achieving this.
>>>>>
>>>> Are you referring to the error pages comes from "
>>> org.wso2.carbon.uuf.common.foundation.ui" component?
>>>
>>> On Sat, Jan 21, 2017 at 8:49 AM, Danushka Fernando <danush...@wso2.com>
>>> wrote:
>>>
>>>> Nisala
>>>> This means we have to write whole error page right? But what if we need
>>>> just layout to be changed. Isn't there an option other than duplicating?
>>>> Because we will change basically the header and footer only.
>>>>
>>>> Thanks & Regards
>>>> Danushka Fernando
>>>> Senior Software Engineer
>>>> WSO2 inc. http://wso2.com/
>>>> Mobile : +94716332729 <+94%2071%20633%202729>
>>>>
>>>> On Sat, Jan 21, 2017 at 8:12 AM, Nisala Nanayakkara <nis...@wso2.com>
>>>> wrote:
>>>>
>>>>> Hi Danushka,
>>>>>
>>>>> You can define your own error pages and its' layout as follows. As an
>>>>> example you need to add below configuration to app.yaml.
>>>>>
>>>>> *errorPages: *
>>>>> *404: "/foundation/error/404"*
>>>>> * default: **"/foundation/error/default**"*
>>>>>
>>>>> Please find related app.yaml[1] and the error pages here[2].
>>>>>
>>>>> [1] - https://github.com/wso2/carbon-uuf/blob/master/samples/apps/
>>>>> org.wso2.carbon.uuf.sample.pets-store.app/src/main/app.yaml
>>>>> [2] - https://github.com/wso2/carbon-uuf/tree/master/samples/compo
>>>>> nents/org.wso2.carbon.uuf.sample.foundation.ui/src/main/pages/error
>>>>>
>>>>> Thanks,
>>>>> Nisala
>>>>>
>>>>>
>>>>>
>>>>> On Sat, Jan 21, 2017 at 6:20 AM, Danushka Fernando <danush...@wso2.com
>>>>> > wrote:
>>>>>
>>>>>> Hi All
>>>>>> I found that default error pages like 404 error page which comes from
>>>>>> UUF doesn't use app's basic layout. And I couldn't find a way to override
>>>>>> it. Is there a way of achieving this.
>>>>>>
>>>>>> Thanks & Regards
>>>>>> Danushka Fernando
>>>>>> Senior Software Engineer
>>>>>> WSO2 inc. http://wso2.com/
>>>>>> Mobile : +94716332729 <+94%2071%20633%202729>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Dev mailing list
>>>>>> Dev@wso2.org
>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Nisala Niroshana Nanayakkara,*
>>>>> Software Engineer
>>>>> Mobile:(+94)717600022
>>>>> WSO2 Inc., http://wso2.com/
>>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Dev mailing list
>>>> Dev@wso2.org
>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>>
>>>>
>>>
>>>
>>> --
>>> Sajith Janaprasad Ariyarathna
>>> Software Engineer; WSO2, Inc.;  http://wso2.com/
>>> <https://wso2.com/signature>
>>>
>>
>>
>> _______________________________________________
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> With regards,
> *Manu*ranga Perera.
>
> phone : 071 7 70 20 50
> mail : m...@wso2.com
>



-- 
Sajith Janaprasad Ariyarathna
Software Engineer; WSO2, Inc.;  http://wso2.com/
<https://wso2.com/signature>
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to