On Sat, Jan 28, 2017 at 4:33 AM, Niranjan Karunanandham <niran...@wso2.com> wrote:
> Hi SajithAR, > > We should not be having absolute link as it is pointing to the master > branch. When the repo is released, the links in the tag will be pointing to > the master branch, but it should point to the tag's link, Instead of having > the sample in another repo, is it possible to have a simple sample into > this repo and give relative paths like in [1]. > Agreed. Will create an issue for this. Thanks. > > [1] - https://github.com/wso2/carbon-kernel/blob/master/README.md > > Regards, > Nira > > On Mon, Jan 23, 2017 at 12:04 PM, SajithAR Ariyarathna <sajit...@wso2.com> > wrote: > >> Thanks for the PR Kalpa. PR [1] has been merged. >> >> [1] https://github.com/wso2/carbon-uuf-maven-tools/pull/49 >> >> On Sun, Jan 22, 2017 at 7:48 PM, Kalpa Welivitigoda <callka...@gmail.com> >> wrote: >> >>> Hi Ayesha, >>> >>> Thanks for reporting, [1] fixes the reported issue. >>> >>> [1] https://github.com/wso2/carbon-uuf-maven-tools/pull/49 >>> >>> On Sun, Jan 22, 2017 at 6:30 PM, Ayesha Dissanayaka <aye...@wso2.com> >>> wrote: >>> >>>> Hi, >>>> >>>> I observe $subject while going through [1] readme. >>>> >>>> - simple-oauth component sample here >>>> >>>> <https://github.com/wso2/carbon-uuf/tree/master/samples/components/org.wso2.carbon.uuf.sample.simple-auth> >>>> - green’ theme sample here >>>> >>>> <https://github.com/wso2/carbon-uuf/tree/master/samples/themes/org.wso2.carbon.uuf.sample.theme.green> >>>> . >>>> - pets-store sample here >>>> >>>> <https://github.com/wso2/carbon-uuf/tree/master/samples/apps/org.wso2.carbon.uuf.sample.pets-store> >>>> >>>> [1] https://github.com/wso2/carbon-uuf-maven-tools/tree/master/plugin >>>> >>>> Thanks! >>>> -Ayesha >>>> >>>> -- >>>> *Ayesha Dissanayaka* >>>> Software Engineer, >>>> WSO2, Inc : http://wso2.com >>>> <http://www.google.com/url?q=http%3A%2F%2Fwso2.com&sa=D&sntz=1&usg=AFQjCNEZvyc0uMD1HhBaEGCBxs6e9fBObg> >>>> 20, Palmgrove Avenue, Colombo 3 >>>> E-Mail: aye...@wso2.com <ayshsa...@gmail.com> >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> Dev@wso2.org >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> Best Regards, >>> >>> Kalpa Welivitigoda >>> +65 82265081 <+65%208226%205081> >>> http://about.me/callkalpa >>> >>> _______________________________________________ >>> Dev mailing list >>> Dev@wso2.org >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> Sajith Janaprasad Ariyarathna >> Software Engineer; WSO2, Inc.; http://wso2.com/ >> <https://wso2.com/signature> >> >> _______________________________________________ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > > > *Niranjan Karunanandham* > Associate Technical Lead - WSO2 Inc. > WSO2 Inc.: http://www.wso2.com > > -- Sajith Janaprasad Ariyarathna Software Engineer; WSO2, Inc.; http://wso2.com/ <https://wso2.com/signature>
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev