Hi Roshan, Thanks for the PR. I have put some comments, please have a look.
Thanks. On Thu, Feb 16, 2017 at 3:01 PM, Roshan Wijesena <ros...@wso2.com> wrote: > It seems Kasun is right, > > the object "data" is by-default coming as html/text. so we don't need use > it as 'data.html' . > > Since this is a blocker for APIM C5 - M1 release for now I have sent a > pull request with a fix. Please review and merge. > > https://github.com/wso2/carbon-uuf-common/pull/41/files > > > On Tue, Feb 14, 2017 at 10:42 AM, Kasun Thennakoon <kasu...@wso2.com> > wrote: > >> Hi all, >> >> Experience the $subject when using UUF-Client for rendering hbs fragments. >> As I understand, the response of >> *http://localhost:9090/publisher/fragments/{fragment-name} >> <http://localhost:9090/publisher/fragments/%7Bfragment-name%7D> *contains >> an HTML string and in this line[1] it is looking for *.html* attribute >> in the response object when calling *pushContent* method. Which pass an >> *undefined >> *value.IMHO this is what cause to display no content in the target zone. >> >> >> [1]: https://github.com/wso2/carbon-uuf-common/blob/master/c >> omponents/org.wso2.carbon.uuf.common.foundation.ui/src/main/ >> fragments/uuf-client/public/uuf-client/uuf-client.js#L226 >> >> -- >> *Kasun Thennakoon* >> Software Engineer >> WSO2, Inc. >> Mobile:+94 711661919 >> >> _______________________________________________ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > Roshan Wijesena. > Senior Software Engineer-WSO2 Inc. > Mobile: *+94719154640 <+94%2071%20915%204640>* > Email: ros...@wso2.com > *WSO2, Inc. :** wso2.com <http://wso2.com/>* > lean.enterprise.middleware. > -- Sajith Janaprasad Ariyarathna Software Engineer; WSO2, Inc.; http://wso2.com/ <https://wso2.com/signature>
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
