Hi Ishara,

On Mon, Jan 16, 2017 at 10:26 AM, Ishara Karunarathna <isha...@wso2.com>
wrote:

>
>
> On Mon, Jan 16, 2017 at 10:24 AM, Niranjan Karunanandham <
> niran...@wso2.com> wrote:
>
>> Hi IsharaK,
>>
>> AFAIR we did not have a code review on this. Can you organize one please
>> before we can merge the PR?
>>
> Niranjan We did this after the Thanus one, and we need thanus PR merged
>
As per the offline discussion, can we schedule a code review for this.


>
>> Regards,
>> Nira
>>
>> On Sun, Jan 15, 2017 at 7:14 AM, Samuel Gnaniah <sam...@wso2.com> wrote:
>>
>>> I checked the readme in Github and it doesn't have any content added. Is
>>> it possible to provide tested steps for this for documentation?
>>>
>>> Also, will this be common to all C5 products or is it only for IS?
>>>
>>> *Samuel Gnaniah*
>>> Lead Technical Writer
>>>
>>> WSO2 (pvt.) Ltd.
>>> Colombo, Sri Lanka
>>> (+94) 773131798 <+94%2077%20313%201798>
>>>
>>> On Sat, Jan 14, 2017 at 10:41 PM, KasunG Gajasinghe <kas...@wso2.com>
>>> wrote:
>>>
>>>>
>>>>
>>>> On Sat, Jan 14, 2017 at 9:29 PM, Ishara Karunarathna <isha...@wso2.com>
>>>> wrote:
>>>>
>>>>> Hi Kasun,
>>>>>
>>>>> On Sat, Jan 14, 2017 at 6:58 PM, KasunG Gajasinghe <kas...@wso2.com>
>>>>> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Opening this thread to keep track of the LDAP userstore feature that
>>>>>> goes into the M1. We are on the final stage of this implementation which 
>>>>>> is
>>>>>> maintained at [1]. @Ishara is working on this.
>>>>>>
>>>>> Are we going to track all the features via mails ?
>>>>> I think all should be tracked with users stories.
>>>>>
>>>>
>>>> Yes. User stories and mails serve for two different purposes, isn't it?
>>>> This is to have discussions, make sure that everyone is on the same page.
>>>>
>>>>
>>>>
>>>>>
>>>>>> We need to get the PR for carbon-jndi merged [2] since the current
>>>>>> JNDI impl does not load JNDI provides coming from the JRE.
>>>>>>
>>>>>> @Samuel, please note on docs.
>>>>>>
>>>>>> [1] https://github.com/wso2-extensions/carbon-security-user-
>>>>>> store-ldap
>>>>>> [2] https://github.com/wso2/carbon-jndi/pull/32
>>>>>>
>>>>>> --
>>>>>>
>>>>>> *Kasun Gajasinghe*Associate Technical Lead, WSO2 Inc.
>>>>>> email: kasung AT spamfree wso2.com
>>>>>> linked-in: http://lk.linkedin.com/in/gajasinghe
>>>>>> blog: http://kasunbg.org
>>>>>> phone: +1 650-745-4499 <(650)%20745-4499>, 77 678 0813
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Ishara Karunarathna
>>>>> Associate Technical Lead
>>>>> WSO2 Inc. - lean . enterprise . middleware |  wso2.com
>>>>>
>>>>> email: isha...@wso2.com,   blog: isharaaruna.blogspot.com,   mobile:
>>>>> +94717996791 <071%20799%206791>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> *Kasun Gajasinghe*Associate Technical Lead, WSO2 Inc.
>>>> email: kasung AT spamfree wso2.com
>>>> linked-in: http://lk.linkedin.com/in/gajasinghe
>>>> blog: http://kasunbg.org
>>>> phone: +1 650-745-4499 <(650)%20745-4499>, 77 678 0813
>>>>
>>>>
>>>
>>>
>>
>>
>> --
>>
>>
>> *Niranjan Karunanandham*
>> Associate Technical Lead - WSO2 Inc.
>> WSO2 Inc.: http://www.wso2.com
>>
>>
>
>
> --
> Ishara Karunarathna
> Associate Technical Lead
> WSO2 Inc. - lean . enterprise . middleware |  wso2.com
>
> email: isha...@wso2.com,   blog: isharaaruna.blogspot.com,   mobile:
> +94717996791 <+94%2071%20799%206791>
>
>
>
Regards,
Nira

-- 


*Niranjan Karunanandham*
Associate Technical Lead - WSO2 Inc.
WSO2 Inc.: http://www.wso2.com
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to