Hi Kasun,

I don't think we need to do this because,

1. This is the model we follow for some other files as well.
claim-config.xml
identity-event.properties

2. This content goes not only to the super tenant but also to tenants as
default email templates. So if we change it in the middle tenants created
until then will have a different default template and the ones created
after that will have a different default template.

I don't think we have any problems with current model. If we do this we
need to change our migration, etc. If the issue here is clarity for the
users it is better we explain it using better wordings in the docs.

Regards,
Johann.

---------- Forwarded message ----------
From: Kasun Gajasinghe (JIRA) <j...@wso2.org>
Date: Wed, Jul 19, 2017 at 1:54 AM
Subject: [jira] (IDENTITY-6167) Need to honor modifications to
email-admin-config.xml file
To: joh...@wso2.com


Kasun Gajasinghe
<https://wso2.org/jira/secure/ViewProfile.jspa?name=kasung%40wso2.com>
*created* an issue

WSO2 Identity Server <https://wso2.org/jira/browse/IDENTITY> / [image:
Improvement] <https://wso2.org/jira/browse/IDENTITY-6167> IDENTITY-6167
<https://wso2.org/jira/browse/IDENTITY-6167>
Need to honor modifications to email-admin-config.xml file
<https://wso2.org/jira/browse/IDENTITY-6167>
Issue Type: [image: Improvement] Improvement
Affects Versions: 5.3.0-GA
Assignee: Johann Nallathamby
<https://wso2.org/jira/secure/ViewProfile.jspa?name=johann%40wso2.com>
Created: 19/Jul/17 1:53 AM
Fix Versions: 5.4.0-GA
Priority: [image: High] High
Reporter: Kasun Gajasinghe
<https://wso2.org/jira/secure/ViewProfile.jspa?name=kasung%40wso2.com>

At the moment, we save the email-admin-config.xml in the registry during
the very first server startup. After that, changes to the file are not
picked up. So, users are forced to go to the registry to update the config.

This is a bit confusing since a user probably expects that the changes to
the file will be honored especially since it is located under
repository/conf folder.

We can do some hashing mechanism and verify whether the contents in the
registry and the file matches. And, then we can update the registry
accordingly.
[image: Add Comment]
<https://wso2.org/jira/browse/IDENTITY-6167#add-comment> Add Comment
<https://wso2.org/jira/browse/IDENTITY-6167#add-comment>

This message was sent by Atlassian JIRA (v7.2.2#72004-sha1:9d51328)
[image: Atlassian logo]



-- 
Thanks & Regards,

*Johann Dilantha Nallathamby*
Senior Lead Solutions Engineer
WSO2, Inc.
lean.enterprise.middleware

Mobile - *+94777776950*
Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>*
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to