Hi, The #replace operations pointed in this jira are actually a no-ops since the original string and the replacement string are the same!
@Indunil, it seems above code segment was introduced by the following commit. Can you enlighten the reason for this? https://github.com/wso2-extensions/identity-inbound-auth-oauth/commit/f40fd2acc9682117bb7e4780c7a274fd5f93c248#diff-3bcd1e69e27d53fa42e00cdc31c36b7bR713 Thanks, Kasun On Wed, Jul 26, 2017 at 2:48 PM, Kasun Gajasinghe (JIRA) <j...@wso2.org> wrote: > Kasun Gajasinghe > <https://wso2.org/jira/secure/ViewProfile.jspa?name=kasung%40wso2.com> > *commented* on [image: Improvement] IDENTITY-6168 > <https://wso2.org/jira/browse/IDENTITY-6168> > > Re: Ambiguous code segment <https://wso2.org/jira/browse/IDENTITY-6168> > > Hi, > > I checked the code, the #replace is actually a no-op here since the > original string and the replacement string are the same! > > @Indunil, it seems above code segment was introduced by the following > commit. Can you enlighten the reason for this? > > https://github.com/wso2-extensions/identity-inbound-auth-oauth/commit/ > f40fd2acc9682117bb7e4780c7a274fd5f93c248#diff- > 3bcd1e69e27d53fa42e00cdc31c36b7bR713 > > Thanks, > KasunG > [image: Add Comment] > <https://wso2.org/jira/browse/IDENTITY-6168#add-comment> Add Comment > <https://wso2.org/jira/browse/IDENTITY-6168#add-comment> > > This message was sent by Atlassian JIRA (v7.2.2#72004-sha1:9d51328) > [image: Atlassian logo] > > _______________________________________________ > Carbon-jira mailing list > carbon-j...@wso2.org > https://wso2.org/cgi-bin/mailman/listinfo/carbon-jira > > -- *Kasun Gajasinghe*Associate Technical Lead, WSO2 Inc. email: kasung AT spamfree wso2.com linked-in: http://lk.linkedin.com/in/gajasinghe blog: http://kasunbg.org phone: +1 650-745-4499, 77 678 0813
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
