On Thu, Aug 24, 2017 at 3:57 AM, Isura Karunaratne <[email protected]> wrote:
> > On Thu, Aug 24, 2017 at 1:27 AM Johann Nallathamby <[email protected]> > wrote: > >> https://github.com/wso2/carbon-identity-framework/commit/1f2 >> df5faf2a46258791bdaf1d4c94741626e34a1 >> >> How is *resourceType* attribute mapped to *userType*? And why is >> AttributeID still *mail*? >> > > This is scim2 dialect. when we add a user, its resorceTyoe is user. Then > the email address of that user becomes as user. That was the issue. > So isn't calling *resourceType* as *userType* wrong? We could have had the local claim also as *resourceType*. Correct? No need to change now I think because it may introduce migration. Better be careful in future when mapping claims to have meaningful names and not conflict with other claims. Another question is in SCIM2 we have multiple resource types - users, groups and extensions. Each of these resource types can have attributes. However in our user.core implementation we don't support resource types other than user. So we can't properly support group resource. And we can't have attributes for groups. *So does it make sense to have a claim called resourceType for users?* Because that's the only resource type we can support so why not hard code it at the SCIM2 implementation level. At least it will avoid overhead of mapping an additional claim. And how do we deal with group resources? Where we do we store the resource type? Do we hard code it for groups? In that case isn't it logical to hard code it for users as well? Regards, Johann. > I think scim1 dialect uses userType claim local claim for this. remote > dialect's attributeId is not required in new claim management module, > instead it uses local mapped claim. > So are we still maintaining these attribute mappings to work with the old claim-mgt component to be backward compatible? But even in that case I feel we have to maintain two claim-mgt configuration files. One for the new implementation and one for the old one. The new one can be the default. And in our docs we can mention how we can use the old one (rename to claim-config.xml). Does it make sense? Otherwise the current config file is very confusing for new users. Regards, Johann. > Thanks > Isura > >> >> Regards, >> Johann. >> >> -- >> >> *Johann Dilantha Nallathamby* >> Senior Lead Solutions Engineer >> WSO2, Inc. >> lean.enterprise.middleware >> >> Mobile - *+94777776950* >> Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* >> > -- > > *Isura Dilhara Karunaratne* > Associate Technical Lead | WSO2 > Email: [email protected] > Mob : +94 772 254 810 <+94%2077%20225%204810> > Blog : http://isurad.blogspot.com/ > > > > -- Thanks & Regards, *Johann Dilantha Nallathamby* Senior Lead Solutions Engineer WSO2, Inc. lean.enterprise.middleware Mobile - *+94777776950* Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
