Noted. I didn't know that :) I would suggest that in this case, when we merge the PR, it would be better for the person who merged it, to close the Git Issue itself.
Regards, Nira On Fri, Sep 8, 2017 at 10:47 AM, Chanaka Cooray <[email protected]> wrote: > Hi Niranjan, > > That has happened because that PR is sent for the 4.4.x branch, not the > master branch. For the PRs those are being sent to the master > branch(default branch) will only close the issues automatically. So for the > PRs those are sent for the branches other than default branch, issues > should be closed manually. > > Thanks, > Chanaka. > > On Thu, Sep 7, 2017 at 8:09 PM, Niranjan Karunanandham <[email protected]> > wrote: > >> Hi all, >> >> This PR does not refer the git issue properly. Thus even though this was >> merge, the issue is not closed :( >> >> Regards, >> Nira >> >> >> On 7 Sep 2017 3:49 p.m., "Chanaka Cooray" <[email protected]> wrote: >> >> Hi Piraveena, >> >> Merged the PR. >> >> Thanks, >> Chanaka. >> >> On Wed, Aug 30, 2017 at 9:16 PM, Piraveena Paralogarajah < >> [email protected]> wrote: >> >>> Hi, >>> >>> I fixed the issue IDENTITY-6313 >>> <https://wso2.org/jira/browse/IDENTITY-6313>. Please review and merge >>> the PR [1]. >>> [1]- https://github.com/wso2/carbon-kernel/pull/1507 >>> >>> Thanks, >>> Piraveena >>> >>> *Piraveena Paralogarajah* >>> Intern- Software Engineering | WSO2 >>> *Email *: [email protected] >>> *Mobile* : +94776099594 <+94%2077%20609%209594> >>> <http://wso2.com/signature> >>> >> >> >> >> -- >> Chanaka Cooray >> Software Engineer, WSO2 Inc. http://wso2.com >> Email: [email protected] >> Mobile: +94713149860 <+94%2071%20314%209860> >> <https://wso2.com/signature> >> >> >> > > > -- > Chanaka Cooray > Software Engineer, WSO2 Inc. http://wso2.com > Email: [email protected] > Mobile: +94713149860 <+94%2071%20314%209860> > <https://wso2.com/signature> > -- *Niranjan Karunanandham* Associate Technical Lead - WSO2 Inc. WSO2 Inc.: http://www.wso2.com
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
