Hi all , I changed the siddhi-io-jms code as discussed above. Also I found some other issues in the siddhi-io-jms as mentioned below: Couldn't cast some variable's type to string[1]. Couldn't check the resultcontainer's content [2][3] in the unit test. I made the changes[4] to fix the above issues. Could you please review those changes?
[1] https://github.com/wso2-extensions/siddhi-io-jms/blob/master/component/src/main/java/org/wso2/extension/siddhi/io/jms/sink/JMSPublisher.java#L76 [2] https://github.com/wso2-extensions/siddhi-io-jms/blob/master/component/src/test/java/org/wso2/extension/siddhi/io/jms/sink/util/QueueConsumer.java#L70 [3] https://github.com/wso2-extensions/siddhi-io-jms/blob/master/component/src/test/java/org/wso2/extension/siddhi/io/jms/sink/util/TopicConsumer.java#L72 [4] https://github.com/wso2-extensions/siddhi-io-jms/pull/13/commits/729c8d350997e953f7ade09be06024b76813e886 Regards, Kalaiyarasi Ganeshalingam Associate Software Engineer| WSO2 WSO2 Inc : http://wso2.org <http://www.google.com/url?q=http%3A%2F%2Fwso2.org&sa=D&sntz=1&usg=AFQjCNE_eTDfyl2ibPcq0hcXvRDNVuQmMg> Tel:+94 076 6792895 LinkedIn :www.linkedin.com/in/kalaiyarasiganeshalingam Blogs : https://kalaiyarasig.blogspot.com/ <http://kalai4.blogspot.com/> On Tue, Oct 24, 2017 at 5:09 PM, Sriskandarajah Suhothayan <s...@wso2.com> wrote: > Then please change the code accept ByteBuffer and we don't need to support > byte[] > > Regards > Suho > > On Tue, Oct 24, 2017 at 4:42 PM, Kalaiyarasi Ganeshalingam < > kalaiyar...@wso2.com> wrote: > >> Hi, >> >> I tried with the binary mapper, But in the BinarySinkMapper, >> getOutputEventClasses() [1] method returns ByteBuffer.class. So is it >> possible to to convert Siddhi events to byte[] ? >> [1]https://github.com/wso2-extensions/siddhi-map-binary/blob >> /master/component/src/main/java/org/wso2/extension/siddhi >> /map/binary/sinkmapper/BinarySinkMapper.java#L76 >> >> Regards, >> >> Kalaiyarasi Ganeshalingam >> Associate Software Engineer| WSO2 >> WSO2 Inc : http://wso2.org >> <http://www.google.com/url?q=http%3A%2F%2Fwso2.org&sa=D&sntz=1&usg=AFQjCNE_eTDfyl2ibPcq0hcXvRDNVuQmMg> >> Tel:+94 076 6792895 <076%20679%202895> >> LinkedIn :www.linkedin.com/in/kalaiyarasiganeshalingam >> Blogs : https://kalaiyarasig.blogspot.com/ <http://kalai4.blogspot.com/> >> >> On Tue, Oct 24, 2017 at 1:43 PM, Kalaiyarasi Ganeshalingam < >> kalaiyar...@wso2.com> wrote: >> >>> Hi, >>> >>> Ok. I will work on this. >>> >>> Regards, >>> >>> Kalaiyarasi Ganeshalingam >>> Associate Software Engineer| WSO2 >>> WSO2 Inc : http://wso2.org >>> <http://www.google.com/url?q=http%3A%2F%2Fwso2.org&sa=D&sntz=1&usg=AFQjCNE_eTDfyl2ibPcq0hcXvRDNVuQmMg> >>> Tel:+94 076 6792895 <+94%2076%20679%202895> >>> LinkedIn :www.linkedin.com/in/kalaiyarasiganeshalingam >>> Blogs : https://kalaiyarasig.blogspot.com/ <http://kalai4.blogspot.com/> >>> >>> On Tue, Oct 24, 2017 at 11:10 AM, Sriskandarajah Suhothayan < >>> s...@wso2.com> wrote: >>> >>>> First, there should be a way of sending byte[] via JMS broker. >>>> Then we can use the binary mapper to convert Siddhi events to byte[] >>>> and send that to JMS broker via JMSPublisher.java. >>>> >>>> Please let me know if this did not work. >>>> >>>> On Tue, Oct 24, 2017 at 10:58 AM, Kalaiyarasi Ganeshalingam < >>>> kalaiyar...@wso2.com> wrote: >>>> >>>>> Hi all, >>>>> Currently I'm working on the unit testing for siddhi-io-jms.In the >>>>> handleCarbonMessage(Object payload)[1] method, I tried to write the test >>>>> case for payload instanceof Byte[] [2] condition.Can you give an idea to >>>>> solve this issue? >>>>> [1] https://github.com/wso2-extensions/siddhi-io- >>>>> jms/blob/master/component/src/main/java/org/wso2/extension/s >>>>> iddhi/io/jms/sink/JMSPublisher.java#L65 >>>>> [2] https://github.com/wso2-extensions/siddhi-io-jms/blob/master >>>>> /component/src/main/java/org/wso2/extension/siddhi/io/jms/si >>>>> nk/JMSPublisher.java#L76 >>>>> >>>>> Regards, >>>>> Kalaiyarasi Ganeshalingam >>>>> Associate Software Engineer| WSO2 >>>>> WSO2 Inc : http://wso2.org >>>>> <http://www.google.com/url?q=http%3A%2F%2Fwso2.org&sa=D&sntz=1&usg=AFQjCNE_eTDfyl2ibPcq0hcXvRDNVuQmMg> >>>>> Tel:+94 076 6792895 <076%20679%202895> >>>>> LinkedIn :www.linkedin.com/in/kalaiyarasiganeshalingam >>>>> Blogs : https://kalaiyarasig.blogspot.com/ >>>>> <http://kalai4.blogspot.com/> >>>>> >>>> >>>> >>>> >>>> -- >>>> >>>> *S. Suhothayan* >>>> Associate Director / Architect >>>> *WSO2 Inc. *http://wso2.com >>>> * <http://wso2.com/>* >>>> lean . enterprise . middleware >>>> >>>> >>>> *cell: (+94) 779 756 757 <+94%2077%20975%206757> | blog: >>>> http://suhothayan.blogspot.com/ <http://suhothayan.blogspot.com/>twitter: >>>> http://twitter.com/suhothayan <http://twitter.com/suhothayan> | linked-in: >>>> http://lk.linkedin.com/in/suhothayan >>>> <http://lk.linkedin.com/in/suhothayan>* >>>> >>> >>> >> > > > -- > > *S. Suhothayan* > Associate Director / Architect > *WSO2 Inc. *http://wso2.com > * <http://wso2.com/>* > lean . enterprise . middleware > > > *cell: (+94) 779 756 757 <+94%2077%20975%206757> | blog: > http://suhothayan.blogspot.com/ <http://suhothayan.blogspot.com/>twitter: > http://twitter.com/suhothayan <http://twitter.com/suhothayan> | linked-in: > http://lk.linkedin.com/in/suhothayan <http://lk.linkedin.com/in/suhothayan>* >
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
