Adding Chanka. @Chanka what would be the best here. To ignore or commit it? @Menuka it seems we can ignore it from the .gitignire as per you reference issues. Let's add a pull request and fix it.
On Thu, Nov 2, 2017 at 1:41 PM, Menuka Warushavithana <men...@wso2.com> wrote: > Hi all, > I have created a GitHub issue for $subject. [1] > AFAIK package-lock.json files should either be committed or ignored (added > to .gitignore) to avoid unexpected results. [2] > Or the generation of package-lock.json could be disabled altogether by > adding the line 'package-lock=false' to the .npmrc file. [3] > > > [1] https://github.com/wso2/carbon-apimgt/issues/4676 > [2] https://github.com/nodejs/citgm/issues/451 > [3] https://github.com/hapijs/contrib/issues/114 > > Regards > > *Menuka Warushavithana* > *Software Engineering Intern* > *WSO2* > > *Moblie: + <%2B%2094%2011%202145345%20%C2%A0Ext.%205737> 94 77 > 6979690* > *LinkedIn: **https://www.linkedin.com/in/menukawarushavithana/ > <https://www.linkedin.com/in/menukawarushavithana/>* > *GitHub: **https://github.com/menuka94/ > <https://github.com/menuka94/>* > > > -- Harsha Kumara Software Engineer, WSO2 Inc. Mobile: +94775505618 Blog:harshcreationz.blogspot.com
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
