Code Review Minutes:
- Add missing license headers - DONE
- Javascript strings should be inside single quotes - DONE
- Don't create MUI theme using createTheme(), use instead
this.props.theme - DONE
- Fix typos "Summery" => "Summary" - DONE
- Change faultyProviderConfig to isFaultyProviderconfig - DONE
- Change _handleDataReceived => remove underscore - DONE
- Remove () in resize event handler - Giving error when removing it
- Remove console errors - We don't need them - DONE
- Define an object with all the texts and remove the switch case and
cloning + see more link - DONE
- Don't use the variables for the percentages. Use them in the place
where need them - DONE
- Initialize state variables instead of cloning initial object - DONE
- change widgetConfig => AttemptCounts - Removed the object - DONE
- Don't calculate the percentages when initialize => hard code the 0 or
move it to a different function - DONE
- Remove dispatch event after set state - DONE
- Rename setReceivedMsg => onReceiveMessage & receivedMsg => message -
DONE
- Don't assign widget type to another variable - DONE
- Remove unwanted definitions from siddhi app - DONE
- Do not need to set see more link in assemble query - DONE
- Change the if condition for widgetType check to increase readability -
DONE
- Define three queries in provider config and set the correct query to
providerconfig query - DONE
- Data provider error - Message change (Use same case) - DONE
- Assign this.state.height to a variable let {width, height} =
this.state - DONE
- Use <br/> instead of iterating in map - Having Issues - Paragraph
going out of the component (Not wrapping correctly)
- Remove excess if condition in render, Show numchart anyways and show
pie chart if data length is greater than 0 - DONE
On Wed, Aug 15, 2018 at 11:22 AM Thisaru Guruge <[email protected]> wrote:
> more details »
> <https://www.google.com/calendar/event?action=VIEW&eid=NHFhNTk4NjJycjZxOWRwdjBnMzg0MWFxMTkgYW5hbHl0aWNzLWdyb3VwQHdzMDIuY29t&tok=MTYjdGhpc2FydUB3c28yLmNvbWFhNzNiYmE0ZDYwMTU4NWE4ODUxY2EzMTEwZDExZjBmMjEzMGI3YzM&ctz=Asia%2FColombo&hl=en&es=0>
> [Code Review]: Is Analytics - Dashboard Widgets
>
> *When*
> Wed Aug 15, 2018 2:30pm – 3:30pm India Standard Time - Colombo
> *Where*
> LK 3rd Floor Meeting Room - Tungsten Ext:1005360 (map
> <https://maps.google.com/maps?q=LK+3rd+Floor+Meeting+Room+-+Tungsten+Ext:1005360&hl=en>
> )
> *Calendar*
> Analytics Group
> *Who*
> •
> Thisaru Guruge - organizer
> •
> [email protected]
> •
> Niveathika Rajendran
> •
> Lasantha Samarakoon
> •
> Sriskandarajah Suhothayan
> •
> Ambujaa Satchithananthan
> •
> Analytics Group
> This is to review the dashboard widgets written for WSO2 Identity Server
> Analytics.
>
> Going? *Yes
> <https://www.google.com/calendar/event?action=RESPOND&eid=NHFhNTk4NjJycjZxOWRwdjBnMzg0MWFxMTkgYW5hbHl0aWNzLWdyb3VwQHdzMDIuY29t&rst=1&tok=MTYjdGhpc2FydUB3c28yLmNvbWFhNzNiYmE0ZDYwMTU4NWE4ODUxY2EzMTEwZDExZjBmMjEzMGI3YzM&ctz=Asia%2FColombo&hl=en&es=0>
> - Maybe
> <https://www.google.com/calendar/event?action=RESPOND&eid=NHFhNTk4NjJycjZxOWRwdjBnMzg0MWFxMTkgYW5hbHl0aWNzLWdyb3VwQHdzMDIuY29t&rst=3&tok=MTYjdGhpc2FydUB3c28yLmNvbWFhNzNiYmE0ZDYwMTU4NWE4ODUxY2EzMTEwZDExZjBmMjEzMGI3YzM&ctz=Asia%2FColombo&hl=en&es=0>
> - No
> <https://www.google.com/calendar/event?action=RESPOND&eid=NHFhNTk4NjJycjZxOWRwdjBnMzg0MWFxMTkgYW5hbHl0aWNzLWdyb3VwQHdzMDIuY29t&rst=2&tok=MTYjdGhpc2FydUB3c28yLmNvbWFhNzNiYmE0ZDYwMTU4NWE4ODUxY2EzMTEwZDExZjBmMjEzMGI3YzM&ctz=Asia%2FColombo&hl=en&es=0>*
> more options »
> <https://www.google.com/calendar/event?action=VIEW&eid=NHFhNTk4NjJycjZxOWRwdjBnMzg0MWFxMTkgYW5hbHl0aWNzLWdyb3VwQHdzMDIuY29t&tok=MTYjdGhpc2FydUB3c28yLmNvbWFhNzNiYmE0ZDYwMTU4NWE4ODUxY2EzMTEwZDExZjBmMjEzMGI3YzM&ctz=Asia%2FColombo&hl=en&es=0>
>
> Invitation from Google Calendar <https://www.google.com/calendar/>
>
> You are receiving this courtesy email at the account
> [email protected] because you are an attendee of this event.
>
> To stop receiving future updates for this event, decline this event.
> Alternatively you can sign up for a Google account at
> https://www.google.com/calendar/ and control your notification settings
> for your entire calendar.
>
> Forwarding this invitation could allow any recipient to modify your RSVP
> response. Learn More
> <https://support.google.com/calendar/answer/37135#forwarding>.
>
--
Thanks and Best Regards,
Thisaru Guruge
Software Engineer
Mobile: +94 71 720 9720
WSO2 Inc.: http://www.wso2.com
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev
