Malintha can you please look into that PR? On Wed, Aug 22, 2018, 6:34 AM Thusitha Thilina Dayaratne < [email protected]> wrote:
> Hi Malintha, > > AFAIK this was not implemented. > It seems like there is an open PR relate to this. IMHO that can be merged > to get the PATCH support if the PR looks good. > > [1] - https://github.com/wso2/msf4j/pull/546 > > On Wed, Aug 8, 2018 at 3:29 AM Malintha Amarasinghe <[email protected]> > wrote: > >> Hi all, >> >> Just wanted to check whether we were able to implement this? Looking at >> the code I guess we do not support PATCH in msf4j yet [1]. We have some >> requirements to implement partial update operations in SCIM2 API via msf4j: >> Eg: Adding a user to an existing group without updating the whole group at >> once [2] >> >> [1] >> https://github.com/wso2/msf4j/blob/master/core/src/main/java/org/wso2/msf4j/internal/router/MicroserviceMetadata.java#L120-L127 >> [2] https://tools.ietf.org/html/rfc7644#page-32 >> >> Thanks! >> Malintha >> >> >> On Mon, Feb 27, 2017 at 9:01 AM, Thusitha Thilina Dayaratne < >> [email protected]> wrote: >> >>> Created issue[1] to track this. >>> >>> [1] - https://github.com/wso2/msf4j/issues/357 >>> >>> Thanks >>> Thusitha >>> >>> On Mon, Feb 27, 2017 at 8:41 AM, Afkham Azeez <[email protected]> wrote: >>> >>>> >>>> >>>> On Mon, Feb 27, 2017 at 6:21 AM, Thusitha Thilina Dayaratne < >>>> [email protected]> wrote: >>>> >>>>> Hi Azeez, >>>>> >>>>> Since we restructured swagger support as a separate dependency, if we >>>>> use swagger PATCH annotation then we have to bring swagger dependency >>>>> again >>>>> to the core. That will increase the minimum jar size. Therefore IMHO it >>>>> would be better if we implement the PATCH annotation without depending on >>>>> Swagger. >>>>> WDYT? >>>>> >>>> >>>> Yeah since it is a simple annotation we may add that to the msf4j core >>>> itself. >>>> >>>>> >>>>> Thanks >>>>> Thusitha >>>>> >>>>> On Mon, Feb 27, 2017 at 12:00 AM, Gayan Gunawardana <[email protected]> >>>>> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Sun, Feb 26, 2017 at 11:48 PM, Afkham Azeez <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Someone suggested on SO to use the PATCH annotation from >>>>>>> io.swagger.jaxrs >>>>>>> >>>>>>> That may be a good alternative since we already support Swagger. >>>>>>> >>>>>> Thanks for the alternative so we can go with io.swagger.jaxrs.PATCH. >>>>>> >>>>>>> >>>>>>> On Sun, Feb 26, 2017 at 11:46 PM, Afkham Azeez <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> We can add that annotation to MSF4J itself. >>>>>>>> >>>>>>>> On Sun, Feb 26, 2017 at 11:28 PM, Gayan Gunawardana <[email protected] >>>>>>>> > wrote: >>>>>>>> >>>>>>>>> Hi All, >>>>>>>>> >>>>>>>>> Since javax.ws.rs does not provide http verb PATCH we have to >>>>>>>>> have custom Patch annotation as below. >>>>>>>>> >>>>>>>>> @Target({ElementType.METHOD})@Retention(RetentionPolicy.RUNTIME)@HttpMethod("PATCH")public >>>>>>>>> @interface PATCH {} >>>>>>>>> >>>>>>>>> Is it ok to have this annotation in component level or is there >>>>>>>>> any common place we can put this annotation ? >>>>>>>>> >>>>>>>>> Alternatively we can use "X-HTTP-Method-Override" header too. >>>>>>>>> >>>>>>>>> WDYT ? >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Gayan >>>>>>>>> >>>>>>>>> -- >>>>>>>>> >>>>>>>>> Gayan Gunawardana >>>>>>>>> Software Engineer; WSO2 Inc.; http://wso2.com/ >>>>>>>>> Email: [email protected] >>>>>>>>> Mobile: +94 (71) 8020933 >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> *Afkham Azeez* >>>>>>>> Senior Director, Platform Architecture; WSO2, Inc.; http://wso2.com >>>>>>>> Member; Apache Software Foundation; http://www.apache.org/ >>>>>>>> * <http://www.apache.org/>* >>>>>>>> *email: **[email protected]* <[email protected]> >>>>>>>> * cell: +94 77 3320919 <077%20332%200919>blog: * >>>>>>>> *http://blog.afkham.org* <http://blog.afkham.org> >>>>>>>> *twitter: **http://twitter.com/afkham_azeez* >>>>>>>> <http://twitter.com/afkham_azeez> >>>>>>>> *linked-in: **http://lk.linkedin.com/in/afkhamazeez >>>>>>>> <http://lk.linkedin.com/in/afkhamazeez>* >>>>>>>> >>>>>>>> *Lean . Enterprise . Middleware* >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Afkham Azeez* >>>>>>> Senior Director, Platform Architecture; WSO2, Inc.; http://wso2.com >>>>>>> Member; Apache Software Foundation; http://www.apache.org/ >>>>>>> * <http://www.apache.org/>* >>>>>>> *email: **[email protected]* <[email protected]> >>>>>>> * cell: +94 77 3320919 <+94%2077%20332%200919>blog: * >>>>>>> *http://blog.afkham.org* <http://blog.afkham.org> >>>>>>> *twitter: **http://twitter.com/afkham_azeez* >>>>>>> <http://twitter.com/afkham_azeez> >>>>>>> *linked-in: **http://lk.linkedin.com/in/afkhamazeez >>>>>>> <http://lk.linkedin.com/in/afkhamazeez>* >>>>>>> >>>>>>> *Lean . Enterprise . Middleware* >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Gayan Gunawardana >>>>>> Software Engineer; WSO2 Inc.; http://wso2.com/ >>>>>> Email: [email protected] >>>>>> Mobile: +94 (71) 8020933 >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Thusitha Dayaratne >>>>> Software Engineer >>>>> WSO2 Inc. - lean . enterprise . middleware | wso2.com >>>>> >>>>> Mobile +94712756809 <071%20275%206809> >>>>> Blog alokayasoya.blogspot.com >>>>> About http://about.me/thusithathilina >>>>> <http://wso2.com/signature> >>>>> >>>>> >>>> >>>> >>>> -- >>>> *Afkham Azeez* >>>> Senior Director, Platform Architecture; WSO2, Inc.; http://wso2.com >>>> Member; Apache Software Foundation; http://www.apache.org/ >>>> * <http://www.apache.org/>* >>>> *email: **[email protected]* <[email protected]> >>>> * cell: +94 77 3320919 <+94%2077%20332%200919>blog: * >>>> *http://blog.afkham.org* <http://blog.afkham.org> >>>> *twitter: **http://twitter.com/afkham_azeez* >>>> <http://twitter.com/afkham_azeez> >>>> *linked-in: **http://lk.linkedin.com/in/afkhamazeez >>>> <http://lk.linkedin.com/in/afkhamazeez>* >>>> >>>> *Lean . Enterprise . Middleware* >>>> >>> >>> >>> >>> -- >>> Thusitha Dayaratne >>> Software Engineer >>> WSO2 Inc. - lean . enterprise . middleware | wso2.com >>> >>> Mobile +94712756809 >>> Blog alokayasoya.blogspot.com >>> About http://about.me/thusithathilina >>> <http://wso2.com/signature> >>> >>> >>> _______________________________________________ >>> Dev mailing list >>> [email protected] >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> Malintha Amarasinghe >> *WSO2, Inc. - lean | enterprise | middleware* >> http://wso2.com/ >> >> Mobile : +94 712383306 >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> > > > -- > *Thusitha Thilina Dayaratne* > PhD Student - Cybersecurity Lab > Monash University > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev >
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
