Hi Tharindu,

If I have not mistaken you have used double underscore for the namespace
and single underscore for config variables. As we are using camel case in
Java, variables cannot have underscore.

+1 for the change.

Thank you!

On Wed, Oct 24, 2018 at 11:38 PM Tharindu Dharmarathna <[email protected]>
wrote:

> Hi Sajith,
>
> As per my findings, we couldn't have variable names with underscores as
> the config created from the configuration class we wrote. If we write
> variable names with underscores it didn't get broke as it check for the
> first part of environment variable as a namespace.
>
> Thanks
>
> On Wed, Oct 24, 2018 at 11:31 PM Sajith Ariyarathna <[email protected]>
> wrote:
>
>> Hi Tharindu,
>>
>> What if there are underscores in the variable name? How do we deal with
>> that?
>>
>> Thanks.
>>
>> On Wed, Oct 24, 2018 at 11:16 PM Danesh Kuruppu <[email protected]> wrote:
>>
>>> +1 for the change.
>>>
>>> @Vidura Nanayakkara <[email protected]> Can you please review these
>>> changes.
>>>
>>> Thanks
>>> Danesh
>>>
>>> On Wed, Oct 24, 2018 at 10:52 PM Tharindu Dharmarathna <
>>> [email protected]> wrote:
>>>
>>>> Hi All,
>>>>
>>>> We had come across the following issue when configuring environment
>>>> variables for API Manager 3.0.
>>>>
>>>> We had the following type of deployment.yaml as default.
>>>>
>>>> wso2.configuration:
>>>>   complexBean:
>>>>     name: default
>>>>     Bean:
>>>>       name: default
>>>>
>>>>
>>>> in order to set the environment variable for *name *under complexBean,
>>>> we have to write environment variable as follows.
>>>>
>>>> WSO2.CONFIGURATION_COMPLEXTESTBEAN_NAME="default"
>>>>
>>>> Which is not supported to create an environment variable couldn't have
>>>> a dot (.) in the name.
>>>>
>>>> In order to fix this issue, I had come up with make Underscore ( _ )
>>>> in namespace value. Once it fixed it looks like follows.
>>>>
>>>> WSO2_CONFIGURATION_COMPLEXTESTBEAN_NAME="default"
>>>>
>>>> Please find the git issue create [1] and pull request for fix [2].
>>>>
>>>> [1] - https://github.com/wso2/carbon-config/issues/66
>>>> [2]  - https://github.com/wso2/carbon-config/issues/66
>>>>
>>>>
>>>> Thanks
>>>>
>>>> *Tharindu Dharmarathna*Associate Technical Lead
>>>> WSO2 Inc.; http://wso2.com
>>>> lean.enterprise.middleware
>>>>
>>>
>>>
>>> --
>>>
>>> *Danesh Kuruppu*
>>> Associate Technical Lead | WSO2
>>>
>>> Email: [email protected]
>>> Mobile: +94 (77) 1690552
>>> Web: WSO2 Inc <https://wso2.com/signature>
>>>
>>>
>>> _______________________________________________
>>> Dev mailing list
>>> [email protected]
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>
>>
>> --
>> Sajith Janaprasad Ariyarathna
>> WSO2, Inc.;  http://wso2.com/
>> <https://wso2.com/signature>
>>
>
>
> --
>
> *Tharindu Dharmarathna*Associate Technical Lead
> WSO2 Inc.; http://wso2.com
> lean.enterprise.middleware
>
> mobile: *+94779109091*
> _______________________________________________
> Dev mailing list
> [email protected]
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>


-- 
*Pubudu Gunatilaka*
Committer and PMC Member - Apache Stratos
Associate Technical Lead
WSO2, Inc.: http://wso2.com
mobile : +94774078049 <%2B94772207163>
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to